-
Notifications
You must be signed in to change notification settings - Fork 23
Update generated code for DPF 251_daily on master #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bc2d0b6 to
1f6fa73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed since contained by Ans.Dpf.PythonPluginWrapper, apparently not loaded during code generation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will become public
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1834 +/- ##
=======================================
Coverage 88.10% 88.10%
=======================================
Files 83 83
Lines 9951 9951
=======================================
Hits 8767 8767
Misses 1184 1184 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hidden kept hidden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hidden kept hidden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will become public
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed as contained by Ans.Dpf.FlowDiagram apparently not loaded during code generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BClappe hey isn't Ans.Dpf.FlowDiagran supposed to be loaded by default by DPF?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with Bruno this should be removed as Ans.Dpf.FlowDiagram is not yet exposed publicly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hidden kept hidden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will become public
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will become public
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Ans.Dpf.Hdf5, hidden kept hidden. Hi @oparreno is it alright for this operator to not appear as ansys.dpf.core.operators.math.nodal_density anymore? Same for elemental_density. If you want you can make it public, it is currently hidden and its spec should be improved if made public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not exposed
An update of generated code has been triggered either manually or by an update in the dpf-standalone repository.