Skip to content

Conversation

@pyansys-ci-bot
Copy link
Collaborator

An update of generated code has been triggered either manually or by an update in the dpf-standalone repository.

@pyansys-ci-bot pyansys-ci-bot requested a review from a team as a code owner October 24, 2024 15:49
@pyansys-ci-bot pyansys-ci-bot force-pushed the maint/update_code_for_251_daily_on_master branch from bc2d0b6 to 1f6fa73 Compare October 24, 2024 15:49
@pyansys-ci-bot pyansys-ci-bot added the server-sync DO NOT USE, Related to automatic synchronization with the server label Oct 24, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed since contained by Ans.Dpf.PythonPluginWrapper, apparently not loaded during code generation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will become public

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (aa61495) to head (1f6fa73).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1834   +/-   ##
=======================================
  Coverage   88.10%   88.10%           
=======================================
  Files          83       83           
  Lines        9951     9951           
=======================================
  Hits         8767     8767           
  Misses       1184     1184           

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hidden kept hidden

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hidden kept hidden

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will become public

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed as contained by Ans.Dpf.FlowDiagram apparently not loaded during code generation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BClappe hey isn't Ans.Dpf.FlowDiagran supposed to be loaded by default by DPF?

Copy link
Contributor

@PProfizi PProfizi Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with Bruno this should be removed as Ans.Dpf.FlowDiagram is not yet exposed publicly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hidden kept hidden

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will become public

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will become public

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Ans.Dpf.Hdf5, hidden kept hidden. Hi @oparreno is it alright for this operator to not appear as ansys.dpf.core.operators.math.nodal_density anymore? Same for elemental_density. If you want you can make it public, it is currently hidden and its spec should be improved if made public.

Copy link
Contributor

@PProfizi PProfizi Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not exposed

@PProfizi PProfizi closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server-sync DO NOT USE, Related to automatic synchronization with the server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants