-
Notifications
You must be signed in to change notification settings - Fork 23
feat: improve contribute section documentation #2085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
e1c64c5
feat: improve contribute documentation
moe-ad c627a76
feat: source files added
moe-ad e320c29
feat: adjustments to user.rst
moe-ad 57ebb65
feat: adjustments to documentarian.rst file
moe-ad 1d6f3d0
Merge branch 'master' into feat/improve-contribution-documentation
moe-ad 74b7edf
feat: corrections
moe-ad e1ec1a3
Merge branch 'master' into feat/improve-contribution-documentation
moe-ad b8f40eb
feat: added convenant code of conduct admonition
moe-ad d800c76
Merge branch 'master' into feat/improve-contribution-documentation
moe-ad 86ac1ff
Merge branch 'master' into feat/improve-contribution-documentation
moe-ad b6a3171
Merge branch 'master' into feat/improve-contribution-documentation
moe-ad 1d5e9b0
Merge branch 'master' into feat/improve-contribution-documentation
moe-ad 03e3056
Merge branch 'master' into feat/improve-contribution-documentation
moe-ad 4844ba3
feat: apply suggestions from Revathy's review
moe-ad cf4cc90
Merge branch 'master' into feat/improve-contribution-documentation
moe-ad 47757c0
feat: corrections
moe-ad 094d8b3
Merge branch 'master' into feat/improve-contribution-documentation
moe-ad deb50bc
feat: apply suggestions from Revathy's review
moe-ad f3e111d
feat: apply suggestions from Revathy's review
moe-ad c71e485
Merge branch 'master' into feat/improve-contribution-documentation
moe-ad afc62ee
feat: review suggestion correction plus pypandoc(#1944)
moe-ad 02a25ba
feat: apply suggestions from Revathy's review
moe-ad 053b4a8
Merge branch 'master' into feat/improve-contribution-documentation
moe-ad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,268 @@ | ||
| Contributing as a developer | ||
| ########################### | ||
|
|
||
| .. grid:: 1 1 3 3 | ||
|
|
||
moe-ad marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| .. grid-item-card:: :fa:`download` Clone the repository | ||
| :padding: 2 2 2 2 | ||
moe-ad marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| :link: clone-the-repository | ||
| :link-type: ref | ||
|
|
||
| Download your own copy in your local machine. | ||
|
|
||
| .. grid-item-card:: :fa:`download` Install for developers | ||
| :padding: 2 2 2 2 | ||
moe-ad marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| :link: install-for-developers | ||
| :link-type: ref | ||
|
|
||
| Install the project in editable mode. | ||
|
|
||
| .. grid-item-card:: :fa:`vial-circle-check` Run the tests | ||
| :padding: 2 2 2 2 | ||
moe-ad marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| :link: run-tests | ||
| :link-type: ref | ||
|
|
||
| Verify your changes by testing the project. | ||
|
|
||
|
|
||
| .. _clone-the-repository: | ||
|
|
||
| Clone the repository | ||
| ==================== | ||
|
|
||
| Clone the latest version of PyDPF-Core in | ||
| development mode by running this code: | ||
|
|
||
| .. code-block:: bash | ||
| git clone https://github.com/ansys/pydpf-core | ||
| .. _install-for-developers: | ||
|
|
||
| Install for developers | ||
| ====================== | ||
|
|
||
| Installing PyDPF-Core in development mode allows you to perform changes to the code | ||
| and see the changes reflected in your environment without having to reinstall | ||
| the library every time you make a change. | ||
|
|
||
| Virtual environment | ||
| ------------------- | ||
|
|
||
| Start by navigating to the project's root directory by running: | ||
|
|
||
| .. code-block:: | ||
moe-ad marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| cd pydpf-core | ||
| Then, create a new virtual environment named ``.venv`` to isolate your system's | ||
| Python environment by running: | ||
|
|
||
| .. code-block:: text | ||
moe-ad marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| python -m venv .venv | ||
| Finally, activate this environment by running: | ||
|
|
||
| .. tab-set:: | ||
|
|
||
| .. tab-item:: Windows | ||
|
|
||
| .. tab-set:: | ||
|
|
||
| .. tab-item:: CMD | ||
|
|
||
| .. code-block:: text | ||
moe-ad marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| .venv\Scripts\activate.bat | ||
| .. tab-item:: PowerShell | ||
|
|
||
| .. code-block:: text | ||
| .venv\Scripts\Activate.ps1 | ||
| .. tab-item:: macOS/Linux/UNIX | ||
|
|
||
| .. code-block:: text | ||
| source .venv/bin/activate | ||
| Development mode | ||
| ---------------- | ||
|
|
||
| Now, install PyDPF-Core in editable mode by running: | ||
|
|
||
| .. code-block:: text | ||
| python -m pip install --editable . | ||
| Verify the installation by checking the version of the library: | ||
|
|
||
|
|
||
| .. code-block:: python | ||
| from ansys.dpf.core import __version__ | ||
| print(f"PyDPF-Core version is {__version__}") | ||
| .. jinja:: | ||
|
|
||
| .. code-block:: text | ||
moe-ad marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| >>> PyDPF-Core version is {{ PYDPF_CORE_VERSION }} | ||
| Install Tox | ||
| ----------- | ||
|
|
||
| Once the project is installed, you can install `Tox`_. This is a cross-platform | ||
| automation tool. The main advantage of Tox is that it eases routine tasks like project | ||
| testing, documentation generation, and wheel building in separate and isolated Python | ||
| virtual environments. To install Tox, run: | ||
|
|
||
| .. code-block:: text | ||
| python -m pip install tox tox-uv | ||
| Finally, verify the installation by listing all the different environments | ||
| (automation rules) for PyDPF-Core: | ||
|
|
||
| .. code-block:: text | ||
| python -m tox list | ||
| .. jinja:: toxenvs | ||
|
|
||
| .. dropdown:: Default Tox environments | ||
| :animate: fade-in | ||
| :icon: three-bars | ||
|
|
||
| .. list-table:: | ||
| :header-rows: 1 | ||
| :widths: auto | ||
|
|
||
| * - Environment | ||
| - Description | ||
| {% for environment in envs %} | ||
| {% set name, description = environment.split("->") %} | ||
| * - {{ name }} | ||
| - {{ description }} | ||
| {% endfor %} | ||
|
|
||
| .. _run-tests: | ||
|
|
||
| Run the tests | ||
| ============= | ||
|
|
||
| Once you have made your changes, you can run the tests to verify that your | ||
| modifications did not break the project. PyDPF-Core tests are organized into groups and require additional steps | ||
| during execution to ensure tests run as expected without errors, therefore, PyDPF-Core tox configuration | ||
| supports different markers to account for this. These markers are associated with a | ||
| dedicated `Tox`_ environment. To also allow flexibity required during development, different DPF Server installation | ||
| can also be used as explained in the subsections that follow. | ||
|
|
||
| Unified DPF Server installation or specific DPF Server installation using ANSYS_DPF_PATH environment variable | ||
| ------------------------------------------------------------------------------------------------------------- | ||
|
|
||
| These two installation DPF Server installation methods i.e. (unified or via ANSYS_DPF_PATH) require no special handling. | ||
| Individual test groups can be simply run with the following commands: | ||
|
|
||
| .. jinja:: toxenvs | ||
|
|
||
| .. dropdown:: Testing individual groups | ||
| :animate: fade-in | ||
| :icon: three-bars | ||
|
|
||
| .. list-table:: | ||
| :header-rows: 1 | ||
| :widths: auto | ||
|
|
||
| * - Environment | ||
| - Command | ||
| {% for environment in envs %} | ||
| {% set name, description = environment.split("->") %} | ||
| {% if name.startswith("test-")%} | ||
| * - {{ name }} | ||
| - python -m tox -e pretest,{{ name }},posttest,kill-servers | ||
| {% endif %} | ||
| {% endfor %} | ||
|
|
||
| Multiple tests can be run in different ways by specifying appropriate tox command: | ||
|
|
||
| .. dropdown:: Testing more than one group sequentially | ||
| :animate: fade-in | ||
| :icon: three-bars | ||
|
|
||
| .. list-table:: | ||
| :header-rows: 1 | ||
| :widths: auto | ||
|
|
||
| * - Command | ||
| - Description | ||
| * - python -m tox | ||
| - Run all test groups sequentially | ||
| * - python -m tox -e pretest,test-api,test-launcher,posttest,kill-servers | ||
| - run specific selection of tests sequentially | ||
|
|
||
| To save testing time, the ``--parallel`` flag can be passed when running multiple environments at once. | ||
| Some test groups are incompatible for parallel runs by nature of their configuration. Some labels have | ||
| been added to the tox configuration for compatible tests to make running them easier. | ||
| The following commands are thus recommended when you wish to take advantage of parallel runs. | ||
|
|
||
| .. dropdown:: Testing more than one group in parallel | ||
| :animate: fade-in | ||
| :icon: three-bars | ||
|
|
||
| .. list-table:: | ||
| :header-rows: 1 | ||
| :widths: auto | ||
|
|
||
| * - Command | ||
| - Description | ||
| * - python -m tox -m localparalleltests --parallel | ||
| - Run all compatible test groups in parallel | ||
| * - python -m tox -e othertests | ||
| - Run incompatible test groups sequentially | ||
| * - python -m pretest,test-api,test-launcher,posttest,kill-servers --parallel | ||
| - Run specific selection of tests in parallel | ||
|
|
||
| Standalone DPF Server installation | ||
| ---------------------------------- | ||
| Standalone DPF Server is usually `installed in editable mode <https://dpf.docs.pyansys.com/version/dev/getting_started/dpf_server.html#install-dpf-server>`_. | ||
| Accordingly, tox commands need to be adjusted for installation of standalone DPF Server in the isolated python environments | ||
| tox creates to run these tests in. This is achieved by adding ``-x testenv.deps+="-e <path/to/dpf/standalone>"`` | ||
| to any of the previous tox commands. | ||
|
|
||
| For example, to run compatible parallel tests while using a Standalone DPF Server whose path is ``ansys_dpf_server_lin_v2025.1.pre0``, simply run: | ||
|
|
||
| .. code-block:: text | ||
moe-ad marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| python -m tox -m localparalleltests --parallel -x testenv.deps+="-e ansys_dpf_server_lin_v2025.1.pre0" | ||
| .. warning:: | ||
| When the ANSYS_DPF_PATH environment variable is set, the server pointed to | ||
| `takes precedence <https://dpf.docs.pyansys.com/version/dev/getting_started/dpf_server.html#manage-multiple-dpf-server-installations>`_ | ||
| over any other DPF Server installation method. Therefore, a standalone DPF Server installed in editable mode, in the | ||
| presence of ANSYS_DPF_PATH environment variable, will be ignored. | ||
|
|
||
| With tox, a simple workaround is not setting this environment variable at the operating system level but passing it explicitly only when | ||
| required. This is achived by adding ``-x testenv.setenv+="ANSYS_DPF_PATH=<path/to/valid/DPF/Server/installation>"`` to any tox command. | ||
|
|
||
| Alternatively, when set at the operating system level, commenting out the line where this environment variable is passed in the tox | ||
| configuration file will ensure that it is ignored within the tox environments. | ||
|
|
||
| .. image:: tox.png | ||
|
|
||
| Testing on Linux via WSL | ||
| ------------------------ | ||
| Some system dependencies required for VTK to run properly might be missing when running tests on linux via WSL (or even linux in general). | ||
| The identified workaround for this is to install the OSMesa wheel variant that leverages offscreen rendering with OSMesa. | ||
| This wheel is being built for both Linux and Windows at this time and bundles all of the necessary libraries into the wheel. This is | ||
| achieved by adding ``-x testenv.commands_pre="uv pip install --extra-index-url https://wheels.vtk.org vtk-osmesa==<version>"`` | ||
|
|
||
| For example, to run all tests sequentially on linux, while using a Standalone DPF Server whose path is ``ansys_dpf_server_lin_v2025.1.pre0``, simply run: | ||
|
|
||
| .. code-block:: text | ||
| python -m tox --parallel -x testenv.deps+="-e ansys_dpf_server_lin_v2025.1.pre0" -x testenv.commands_pre="uv pip install --extra-index-url https://wheels.vtk.org vtk-osmesa==9.2.20230527.dev0" | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.