Skip to content

Conversation

@rafacanton
Copy link
Contributor

@rafacanton rafacanton commented Jun 13, 2025

In this PR we eliminate the hardcoded _result_properties dictionary as per the attached issue. This is aligned with this PR in pydpf-post: ansys/pydpf-post#918

@rafacanton rafacanton changed the title Rcanton/remove result props Experimental - remove _result_properties Jun 13, 2025
@rafacanton rafacanton marked this pull request as draft June 13, 2025 07:44
@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

❌ Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.42%. Comparing base (45dcabc) to head (7e11f0f).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2365      +/-   ##
==========================================
+ Coverage   84.37%   84.42%   +0.04%     
==========================================
  Files          92       92              
  Lines       10922    10912      -10     
==========================================
- Hits         9215     9212       -3     
+ Misses       1707     1700       -7     

@rafacanton rafacanton closed this Jun 13, 2025
@rafacanton rafacanton deleted the rcanton/remove_result_props branch June 13, 2025 08:20
@rafacanton rafacanton linked an issue Jun 13, 2025 that may be closed by this pull request
@PProfizi PProfizi restored the rcanton/remove_result_props branch August 5, 2025 15:08
@PProfizi PProfizi self-assigned this Aug 5, 2025
@PProfizi PProfizi reopened this Aug 5, 2025
@rafacanton rafacanton closed this Nov 4, 2025
@rafacanton rafacanton reopened this Nov 4, 2025
@rafacanton rafacanton changed the base branch from master to main November 4, 2025 10:54
@rafacanton rafacanton marked this pull request as ready for review November 4, 2025 11:04
@rafacanton rafacanton marked this pull request as draft November 4, 2025 11:40
@rafacanton rafacanton self-assigned this Nov 4, 2025
@rafacanton rafacanton marked this pull request as ready for review November 4, 2025 16:45
@rafacanton rafacanton changed the title Experimental - remove _result_properties Remove _result_properties Nov 5, 2025
@rafacanton rafacanton added the enhancement New feature or request label Nov 5, 2025
Copy link
Contributor

@PProfizi PProfizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this @rafacanton !

@PProfizi PProfizi merged commit 22395e0 into main Nov 5, 2025
42 of 43 checks passed
@PProfizi PProfizi deleted the rcanton/remove_result_props branch November 5, 2025 08:49
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Some tests with 'continue-on-error: true' have failed:

  • PyDPF-Post API tests on ubuntu-latest

Created by continue-on-error-comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove _result_properties dict and instead just rely on ResultInfo

3 participants