Skip to content

Update for numpy 2 #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2024
Merged

Update for numpy 2 #745

merged 2 commits into from
Nov 8, 2024

Conversation

@PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Nov 8, 2024 •
edited
Loading

Switch MeshInfo.cell_zones and MeshInfo.face_zones keys to int instead of np.int32.

Starting with numpy==2, the np.int32 is reported explicitly as such, making their representation pop up where used directly. To circumvent that, when building maps based on scoping.ids, take the underlying Python int.

See here for the failing checks when upgrading to numpy==2.

@PProfizi PProfizi added the bug Something isn't working label Nov 8, 2024
@PProfizi PProfizi added this to the v0.9.1 milestone Nov 8, 2024
@PProfizi PProfizi self-assigned this Nov 8, 2024
@PProfizi PProfizi requested a review from BClappe November 8, 2024 10:52
BClappe
BClappe approved these changes Nov 8, 2024
View reviewed changes
Copy link

@BClappe BClappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ! Got a "gotcha"!

@cbellot000 cbellot000 merged commit 3f3577f into master Nov 8, 2024
30 checks passed
@cbellot000 cbellot000 deleted the fix/update_for_numpy_2 branch November 8, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BClappe BClappe BClappe approved these changes

Assignees

@PProfizi PProfizi

Labels

bug Something isn't working

Projects

None yet

Milestone

v0.9.1

Development

Successfully merging this pull request may close these issues.

4 participants

@PProfizi @BClappe @cbellot000