fix: warn out of bounds characters when reading lines (#647)

Co-authored-by: Mohamed Koubaa <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>

Author: 3 people

doc/changelog/647.miscellaneous.md

@@ -0,0 +1 @@
+fix: warn out of bounds characters when reading lines

src/ansys/dyna/core/lib/kwd_line_formatter.py

@@ -21,6 +21,7 @@
 # SOFTWARE.
 
 import typing
+import warnings
 
 from ansys.dyna.core.lib.parameter_set import ParameterSet
 
@@ -146,6 +147,7 @@ def get_parameter(text_block: str, item_type: type) -> typing.Any:
         data.append(value)
 
     if end_position < len(line_data):
-        raise Exception("Data line is too long!")
+        warning_message = f'Detected out of bound card characters:\n"{line_data[end_position:]}"\n"Ignoring.'
+        warnings.warn(warning_message)
 
     return tuple(data)

tests/test_card.py

@@ -40,7 +40,7 @@ def test_load_card_errors(string_utils):
         # cards can only load a readable buffer
         card.read("")
 
-    with pytest.raises(Exception):
+    with pytest.warns(UserWarning, match="Detected out of bound card characters"):
         # error if the line that is too long
         buf = "                                           "
         card.read(string_utils.as_buffer(buf))

tests/test_keywords.py

@@ -162,6 +162,11 @@ def test_read_keyword_no_data():
     # ensure that it does not throw when the data line is empty
     belt.loads(seatbelt_text)
 
+    seatbelt_text = seatbelt_text + "..."
+    # ensure that it does not throw when extra characters are added
+    with pytest.warns(UserWarning, match="Detected out of bound card characters"):
+        belt.loads(seatbelt_text)
+
 
 @pytest.mark.keywords
 def test_read_nodes(ref_string):

tests/test_load_dataline.py

@@ -65,7 +65,7 @@ def test_load_dataline_005():
 @pytest.mark.keywords
 def test_load_dataline_006():
     """test loading a data line that is too long."""
-    with pytest.raises(Exception):
+    with pytest.warns(UserWarning, match="Detected out of bound card characters"):
         load_dataline([(0, 8, int), (8, 8, float), (16, 8, float)], "                                          ")