feat: Assign fields for duplicate cards in constructor (#716)

Co-authored-by: Mohamed Koubaa <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: 4 people

codegen/templates/keyword/card.j2

@@ -44,7 +44,9 @@
 {% if card.duplicate.active_func %}
                 lambda: {{card.duplicate.active_func}},
 {% endif %}
-                data = kwargs.get("{{card.duplicate.name}}")),
+                name="{{card.duplicate.name}}",
+                **kwargs,
+            ),
 {% elif card.duplicate_group %}
             DuplicateCardGroup(
                 [
@@ -76,7 +78,9 @@
 {% else %}
                 None,
 {% endif %}
-                data = kwargs.get("{{card.overall_name}}")),
+                "{{card.overall_name}}",
+                **kwargs,
+            ),
 {% elif card.external %}
             {{card.external.name}}(**kwargs)
 {% else %}

doc/changelog/716.documentation.md

@@ -0,0 +1 @@
+feat: Assign fields for duplicate cards in constructor

examples/Buckling_Beer_Can/plot_beercan_data.py

@@ -95,33 +95,33 @@ def write_deck(filepath):
         ]
     )
 
-    # Append part keywords
-    can_part = kwd.Part()
-    can_part.parts = pd.DataFrame({"heading": ["Beer Can"], "pid": [1], "secid": [1], "mid": [1], "eosid": [0]})
-
-    floorPart = kwd.Part()
-    floorPart.parts = pd.DataFrame({"heading": ["Floor"], "pid": [2], "secid": [2], "mid": [1]})
+    # Part keywords
+    can_part = kwd.Part(heading="Beer Can", pid=1, secid=1, mid=1, eosid=0)
+    floor_part = kwd.Part(heading="Floor", pid=2, secid=2, mid=1)
 
+    # Material keywords
     mat_elastic = kwd.MatElastic(mid=1, ro=2.59e-4, e=1.0e7, pr=0.33, title="Aluminum")
     mat_elastic.options["TITLE"].active = True
 
+    # Section keywords
     can_shell = kwd.SectionShell(secid=1, elform=-16, shrf=0.8333, nip=3, t1=0.002, propt=0.0, title="Beer Can")
     can_shell.options["TITLE"].active = True
 
     floor_shell = kwd.SectionShell(secid=2, elform=-16, shrf=0.833, t1=0.01, propt=0.0)
     floor_shell.options["TITLE"].active = True
     floor_shell.title = "Floor - Just for Contact (Rigid Wall Would Have Worked Also)"
-    # Append material keywords
+
     deck.extend(
         [
             can_part,
             can_shell,
-            floorPart,
+            floor_part,
             floor_shell,
             mat_elastic,
         ]
     )
 
+    # Load curve
     load_curve = kwd.DefineCurve(lcid=1, curves=pd.DataFrame({"a1": [0.00, 1.00], "o1": [0.0, 1.000]}))
     load_curve.options["TITLE"].active = True
     load_curve.title = "Load vs. Time"

examples/John_Reid_Pendulum/plot_john_reid_pendulum.py

@@ -131,10 +131,7 @@ def write_deck(filepath):
 
     spherePart = kwd.Part()
     spherePart.parts = pd.DataFrame({"heading": ["sphere1", "sphere2"], "pid": [1, 2], "secid": [1, 2], "mid": [1, 1]})
-    beamPart = kwd.Part()
-    beamPart.parts = pd.DataFrame(
-        {"heading": ["Pendulum Wires - Elastic Beams"], "pid": [45], "secid": [45], "mid": [45]}
-    )
+    beamPart = kwd.Part(heading="Pendulum Wires - Elastic Beams", pid=45, secid=45, mid=45)
 
     deck.extend(
         [

examples/John_Reid_Pipe/plot_john_pipe.py

@@ -136,8 +136,7 @@ def write_deck(filepath):
     )
 
     # Define bracket parts and materials
-    bracket_parts = kwd.Part()
-    bracket_parts.parts = pd.DataFrame({"heading": ["Bracket"], "pid": [4], "secid": [4], "mid": [4]})
+    bracket_parts = kwd.Part(heading="Bracket", pid=4, secid=4, mid=4)
 
     deck.extend(
         [

examples/Taylor_Bar/plot_taylor_bar.py

@@ -46,7 +46,6 @@
 
 import ansys.dpf.core as dpf
 import matplotlib.pyplot as plt
-import pandas as pd
 
 from ansys.dyna.core import Deck
 from ansys.dyna.core import keywords as kwd
@@ -84,8 +83,7 @@ def create_input_deck(initial_velocity):
     sec_1.elform = 1
 
     # Define part
-    part_1 = kwd.Part()
-    part_1.parts = pd.DataFrame({"pid": [1], "mid": [mat_1.mid], "secid": [sec_1.secid]})
+    part_1 = kwd.Part(pid=1, mid=mat_1.mid, secid=sec_1.secid)
 
     # Define coordinate system
     cs_1 = kwd.DefineCoordinateSystem(cid=1)

src/ansys/dyna/core/keywords/keyword_classes/auto/boundary_spc_node.py

@@ -52,7 +52,9 @@ def __init__(self, **kwargs):
                     Field("dofrz", int, 70, 10),
                 ],
                 None,
-                data = kwargs.get("nodes")),
+                name="nodes",
+                **kwargs,
+            ),
             OptionCardSet(
                 option_spec = BoundarySpcNode.option_specs[0],
                 cards = [

src/ansys/dyna/core/keywords/keyword_classes/auto/constrained_adaptivity.py

@@ -42,7 +42,9 @@ def __init__(self, **kwargs):
                     Field("nid2", int, 20, 10),
                 ],
                 None,
-                data = kwargs.get("constrains")),
+                name="constrains",
+                **kwargs,
+            ),
         ]
 
     @property

src/ansys/dyna/core/keywords/keyword_classes/auto/constrained_nodal_rigid_body.py

@@ -91,7 +91,9 @@ def __init__(self, **kwargs):
                 ],
                 None,
                 None,
-                data = kwargs.get("constrained_nodal_rigid_bodies")),
+                "constrained_nodal_rigid_bodies",
+                **kwargs,
+            ),
             OptionCardSet(
                 option_spec = ConstrainedNodalRigidBody.option_specs[0],
                 cards = [

src/ansys/dyna/core/keywords/keyword_classes/auto/control_mpp_decomposition_transformation.py

@@ -109,7 +109,9 @@ def __init__(self, **kwargs):
                 ],
                 None,
                 None,
-                data = kwargs.get("transformation")),
+                "transformation",
+                **kwargs,
+            ),
         ]
 
     @property