fix: Cherry-picked changes to include in version 0.37.1 (#4716)

mkundu1 · pyansys-ci-bot · prmukherj · web-flow · commit 7ee6b4f620c8 · 2025-12-09T13:33:09.000-05:00
Cherry-picked changes from the following PRs to include in version 0.37.1: #4660 (Support `PYFLUENT_CONTAINER_INSECURE_MODE` environment variable) #4689 (Fix `from_install` method) #4712 (Always show the insecure gRPC warning) #4670 (Don't allow pop up terminal windows during launch_fluent) --------- Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Prithwish Mukherjee <109645853+prmukherj@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
diff --git a/.github/workflows/doc-build-dev-nightly.yml b/.github/workflows/doc-build-dev-nightly.yml
@@ -73,30 +73,35 @@ jobs:
           python examples/00-fluent/exhaust_system_settings_api.py
         env:
           FLUENT_IMAGE_TAG: ${{ env.DOC_DEPLOYMENT_IMAGE_TAG }}
+          PYFLUENT_CONTAINER_INSECURE_MODE: 1
 
       - name: Execute external_compressible_flow.py
         run: |
           python examples/00-fluent/external_compressible_flow.py
         env:
           FLUENT_IMAGE_TAG: ${{ env.DOC_DEPLOYMENT_IMAGE_TAG }}
+          PYFLUENT_CONTAINER_INSECURE_MODE: 1
 
       - name: Execute mixing_elbow_settings_api.py
         run: |
           python examples/00-fluent/mixing_elbow_settings_api.py
         env:
           FLUENT_IMAGE_TAG: ${{ env.DOC_DEPLOYMENT_IMAGE_TAG }}
+          PYFLUENT_CONTAINER_INSECURE_MODE: 1
 
       - name: Execute modeling_cavitation.py
         run: |
           python examples/00-fluent/modeling_cavitation.py
         env:
           FLUENT_IMAGE_TAG: ${{ env.DOC_DEPLOYMENT_IMAGE_TAG }}
+          PYFLUENT_CONTAINER_INSECURE_MODE: 1
 
       - name: Execute species_transport.py
         run: |
           python examples/00-fluent/species_transport.py
         env:
           FLUENT_IMAGE_TAG: ${{ env.DOC_DEPLOYMENT_IMAGE_TAG }}
+          PYFLUENT_CONTAINER_INSECURE_MODE: 1
 
       - name: Build All Documentation
         run: |
@@ -129,9 +134,12 @@ jobs:
 
   deploy_dev_docs:
     name: "Deploy Documentation"
-    runs-on: ubuntu-latest
+    runs-on: public-ubuntu-latest-8-cores
     needs: [build_dev_docs]
     if: github.ref == 'refs/heads/main'
+    permissions:
+      contents: write
+      pull-requests: write
     steps:
       - name: "Deploy development documentation"
         uses: ansys/actions/doc-deploy-dev@v10.1
diff --git a/doc/changelog.d/4660.added.md b/doc/changelog.d/4660.added.md
@@ -0,0 +1 @@
+Minor improvements of the gRPC feature
diff --git a/doc/changelog.d/4670.fixed.md b/doc/changelog.d/4670.fixed.md
@@ -0,0 +1 @@
+Pop up window for launch fluent.
diff --git a/doc/changelog.d/4689.fixed.md b/doc/changelog.d/4689.fixed.md
@@ -0,0 +1 @@
+From_install
diff --git a/doc/changelog.d/4712.fixed.md b/doc/changelog.d/4712.fixed.md
@@ -0,0 +1 @@
+Always show the gRPC warning
diff --git a/doc/changelog.d/4716.fixed.md b/doc/changelog.d/4716.fixed.md
@@ -0,0 +1 @@
+Cherry-picked changes to include in version 0.37.1
diff --git a/doc/source/contributing/environment_variables.rst b/doc/source/contributing/environment_variables.rst
@@ -77,4 +77,6 @@ control the behavior of PyFluent within the same Python process. Please see the
     * - REMOTING_SERVER_ADDRESS
       - Specifies the IP address of the Fluent server while launching Fluent in :func:`launch_fluent() <ansys.fluent.core.launcher.launcher.launch_fluent>`.
     * - SERVER_INFO_DIR
-      - Specifies the directory where the server-info file is created while launching Fluent in :func:`launch_fluent() <ansys.fluent.core.launcher.launcher.launch_fluent>`.
+      - Specifies the directory where the server-info file is created while launching Fluent in :func:`launch_fluent() <ansys.fluent.core.launcher.launcher.launch_fluent>`.
+    * - PYFLUENT_CONTAINER_INSECURE_MODE
+      - Uses insecure mode when launching Fluent in a container or connecting to a Fluent container.
diff --git a/src/ansys/fluent/core/__init__.py b/src/ansys/fluent/core/__init__.py
@@ -81,7 +81,7 @@
 from ansys.fluent.core.utils.fluent_version import FluentVersion  # noqa: F401
 from ansys.fluent.core.utils.setup_for_fluent import setup_for_fluent  # noqa: F401
 
-__version__ = "0.37.0"
+__version__ = "0.37.1"
 
 _VERSION_INFO = None
 """
diff --git a/src/ansys/fluent/core/docker/utils.py b/src/ansys/fluent/core/docker/utils.py
@@ -32,6 +32,9 @@ def _is_grpc_patched(image_tag: str):
     """
     Check if the image tag corresponds to a version that patches gRPC.
     """
+    if image_tag.startswith("sha256:"):
+        return True
+
     min_patched_versions = {
         "v25.2": 3,
         "v25.1": 4,
diff --git a/src/ansys/fluent/core/fluent_connection.py b/src/ansys/fluent/core/fluent_connection.py
@@ -45,6 +45,7 @@
 
 import ansys.fluent.core as pyfluent
 from ansys.fluent.core.launcher.launcher_utils import ComposeConfig
+from ansys.fluent.core.pyfluent_warnings import InsecureGrpcWarning
 from ansys.fluent.core.services import service_creator
 from ansys.fluent.core.services.app_utilities import (
     AppUtilitiesOld,
@@ -327,7 +328,7 @@ def _get_channel(
                 "The Fluent session will be connected in insecure gRPC mode. "
                 "This mode is not recommended. For more details on the implications "
                 "and usage of insecure mode, refer to the Fluent documentation.",
-                UserWarning,
+                InsecureGrpcWarning,
             )
             return grpc.insecure_channel(address, options=options)
         else:
@@ -337,7 +338,8 @@ def _get_channel(
                 )
             return _get_tls_channel(address, certificates_folder, options=options)
     else:
-        if not _is_localhost(address):
+        insecure_mode_env = os.getenv("PYFLUENT_CONTAINER_INSECURE_MODE") == "1"
+        if not (_is_localhost(address) or (inside_container and insecure_mode_env)):
             raise ValueError(
                 "Connecting to remote Fluent instances is not allowed. "
                 "Set 'allow_remote_host=True' to connect to remote hosts."
diff --git a/src/ansys/fluent/core/launcher/container_launcher.py b/src/ansys/fluent/core/launcher/container_launcher.py
@@ -192,7 +192,8 @@ def __init__(
         In job scheduler environments (e.g., SLURM, LSF, PBS), resources and compute nodes are allocated,
         and core counts are queried from these environments before being passed to Fluent.
         """
-        if certificates_folder is None and not insecure_mode:
+        insecure_mode_env = os.getenv("PYFLUENT_CONTAINER_INSECURE_MODE") == "1"
+        if certificates_folder is None and not insecure_mode and not insecure_mode_env:
             raise ValueError(
                 "To launch Fluent in secure gRPC mode, set `certificates_folder`."
             )
@@ -225,7 +226,9 @@ def __init__(
         self._compose_config = ComposeConfig(use_docker_compose, use_podman_compose)
         fluent_image_tag = os.getenv("FLUENT_IMAGE_TAG")
         # There is an issue in passing gRPC arguments to Fluent image version 24.1.0 during github runs.
-        if self.argvals["insecure_mode"] and fluent_image_tag != "v24.1.0":
+        if (
+            self.argvals["insecure_mode"] or insecure_mode_env
+        ) and fluent_image_tag != "v24.1.0":
             self._args.append(" -grpc-allow-remote-host")
             self._args.append(" -grpc-insecure-mode")
         elif self.argvals["certificates_folder"]:
diff --git a/src/ansys/fluent/core/launcher/launcher.py b/src/ansys/fluent/core/launcher/launcher.py
@@ -396,6 +396,7 @@ def _mode_to_launcher_type(fluent_launch_mode: LaunchMode):
 def connect_to_fluent(
     ip: str | None = None,
     port: int | None = None,
+    address: str | None = None,
     cleanup_on_exit: bool = False,
     start_transcript: bool = True,
     server_info_file_name: str | None = None,
@@ -420,6 +421,10 @@ def connect_to_fluent(
         environment variable ``PYFLUENT_FLUENT_PORT=<port>`` to set a default
         value. The explicit value of ``port`` takes precedence over
         ``PYFLUENT_FLUENT_PORT=<port>``.
+    address : str, optional
+        Address for connecting to an existing Fluent instance. The address
+        can be a TCP address of the form ``<ip>:<port>`` or a Unix domain
+        socket of the form ``unix:/<path>``. The default is ``None``.
     cleanup_on_exit : bool, optional
         Whether to shut down the connected Fluent session when PyFluent is
         exited, or the ``exit()`` method is called on the session instance,
@@ -483,13 +488,14 @@ def connect_to_fluent(
                 "To set `insecure_mode`, `allow_remote_host` must be True."
             )
 
-    values = _get_server_info(server_info_file_name, ip, port, password)
-    if len(values) == 2:
-        address, password = values
-        ip, port = None, None
-    else:
-        ip, port, password = values
-        address = None
+    if address is None:
+        values = _get_server_info(server_info_file_name, ip, port, password)
+        if len(values) == 2:
+            address, password = values
+            ip, port = None, None
+        else:
+            ip, port, password = values
+
     fluent_connection = FluentConnection(
         ip=ip,
         port=port,
@@ -508,9 +514,7 @@ def connect_to_fluent(
 
     if start_watchdog:
         logger.info("Launching Watchdog for existing Fluent session...")
-        values = _get_server_info(server_info_file_name, ip, port, password)
-        if len(values) == 3:
-            ip, port, password = values
+        if ip is not None and port is not None and password is not None:
             watchdog.launch(os.getpid(), port, password, ip)
 
     return new_session(
diff --git a/src/ansys/fluent/core/launcher/launcher_utils.py b/src/ansys/fluent/core/launcher/launcher_utils.py
@@ -106,7 +106,11 @@ def _get_subprocess_kwargs_for_fluent(env: Dict[str, Any], argvals) -> Dict[str,
             stderr=pyfluent.config.launch_fluent_stderr,
         )
     if is_windows():
-        kwargs.update(shell=True, creationflags=subprocess.CREATE_NEW_PROCESS_GROUP)
+        kwargs.update(
+            shell=True,
+            creationflags=subprocess.CREATE_NEW_PROCESS_GROUP
+            | subprocess.CREATE_NO_WINDOW,
+        )
     else:
         kwargs.update(shell=True, start_new_session=True)
     fluent_env = os.environ.copy()
diff --git a/src/ansys/fluent/core/launcher/standalone_launcher.py b/src/ansys/fluent/core/launcher/standalone_launcher.py
@@ -236,14 +236,7 @@ def __init__(
         )
 
         if is_windows():
-            if (
-                pyfluent.config.launch_fluent_stdout
-                or pyfluent.config.launch_fluent_stderr
-            ):
-                self._launch_cmd = self._launch_string
-            else:
-                # Using 'start.exe' is better; otherwise Fluent is more susceptible to bad termination attempts.
-                self._launch_cmd = 'start "" ' + self._launch_string
+            self._launch_cmd = self._launch_string
         else:
             if self.argvals["ui_mode"] not in [UIMode.GUI, UIMode.HIDDEN_GUI]:
                 # Using nohup to hide Fluent output from the current terminal
@@ -257,7 +250,6 @@ def __call__(self):
             return self._launch_string, self._server_info_file_name
         try:
             logger.debug(f"Launching Fluent with command: {self._launch_cmd}")
-
             process = subprocess.Popen(self._launch_cmd, **self._kwargs)
 
             try:
diff --git a/src/ansys/fluent/core/pyfluent_warnings.py b/src/ansys/fluent/core/pyfluent_warnings.py
@@ -44,6 +44,17 @@ class FluentDevVersionWarning(PyFluentUserWarning):
     pass
 
 
+# Deriving from the base Warning instead of any derived classes
+# to have less chance of being ignored by user configurations.
+class InsecureGrpcWarning(Warning):
+    """Warning raised when gRPC connection is insecure."""
+
+    pass
+
+
+warnings.filterwarnings("always", category=InsecureGrpcWarning)
+
+
 def warning_for_fluent_dev_version(version):
     """Provides warning if Fluent develop branch is used."""
     from ansys.fluent.core import FluentVersion, config
diff --git a/src/ansys/fluent/core/report.py b/src/ansys/fluent/core/report.py
@@ -58,6 +58,7 @@
     "REMOTING_PORTS",
     "REMOTING_SERVER_ADDRESS",
     "SERVER_INFO_DIR",
+    "PYFLUENT_CONTAINER_INSECURE_MODE",
 ]
 
 
diff --git a/src/ansys/fluent/core/session_utilities.py b/src/ansys/fluent/core/session_utilities.py
@@ -85,8 +85,6 @@ def from_install(
         topy: str | list | None = None,
         start_watchdog: bool | None = None,
         file_transfer_service: Any | None = None,
-        certificates_folder: str | None = None,
-        insecure_mode: bool = False,
     ):
         """
         Launch a Fluent session in standalone mode.
@@ -154,12 +152,6 @@ def from_install(
             GUI-less Fluent sessions started by PyFluent are properly closed when the current Python process ends.
         file_transfer_service : Any
             Service for uploading/downloading files to/from the server.
-        certificates_folder : str, optional
-            Path to the folder containing TLS certificates for Fluent's gRPC server.
-        insecure_mode : bool, optional
-            If True, Fluent's gRPC server will be started in insecure mode without TLS.
-            This mode is not recommended. For more details on the implications
-            and usage of insecure mode, refer to the Fluent documentation.
 
         Raises
         ------
diff --git a/tests/test_session.py b/tests/test_session.py
@@ -673,7 +673,7 @@ def test_app_utilities_new_and_old(mixing_elbow_settings_session):
 
 
 @pytest.mark.standalone
-def test_new_launch_fluent_api():
+def test_new_launch_fluent_api_standalone():
     import ansys.fluent.core as pyfluent
 
     solver = pyfluent.Solver.from_install()
@@ -697,6 +697,19 @@ def test_new_launch_fluent_api():
     solver_connected.exit()
 
 
+def test_new_launch_fluent_api_dry_run(helpers):
+    helpers.mock_awp_vars()
+    pyfluent.Solver.from_install(
+        product_version=FluentVersion.current_release(), dry_run=True
+    )
+    pyfluent.SolverAero.from_install(
+        product_version=FluentVersion.current_release(), dry_run=True
+    )
+    pyfluent.Meshing.from_install(
+        product_version=FluentVersion.current_release(), dry_run=True
+    )
+
+
 def test_new_launch_fluent_api_from_container():
     import ansys.fluent.core as pyfluent
     from ansys.fluent.core.utils.networking import get_free_port

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Cherry-picked changes to include in version 0.37.1`