Skip to content

Commit 3284272

Browse files
fix: avoid com logging if not in debug mode (#3665)
* fix: avoid com logging if not in debug mode * chore: adding changelog file 3665.fixed.md [dependabot-skip] * Update src/ansys/mapdl/core/mapdl_core.py * fix: implementing koubaa suggestion --------- Co-authored-by: pyansys-ci-bot <[email protected]>
1 parent cacc150 commit 3284272

File tree

3 files changed

+21
-1
lines changed

3 files changed

+21
-1
lines changed

doc/changelog.d/3665.fixed.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
fix: avoid com logging if not in debug mode

src/ansys/mapdl/core/mapdl_core.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1401,7 +1401,9 @@ def __init__(self, parent):
14011401

14021402
def __enter__(self):
14031403
self._parent()._log.debug("Entering in non-interactive mode")
1404-
self._parent().com("Entering in non_interactive mode")
1404+
if self._parent().logger.logger.level <= logging.DEBUG:
1405+
# only commenting if on debug mode
1406+
self._parent().com("Entering in non_interactive mode")
14051407
self._parent()._store_commands = True
14061408

14071409
def __exit__(self, *args):

tests/test_mapdl.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
"""Test MAPDL interface"""
2424
from datetime import datetime
2525
from importlib import reload
26+
import logging
2627
import os
2728
from pathlib import Path
2829
import re
@@ -2592,3 +2593,19 @@ def test_max_cmd_len_mapdlgrpc(mapdl):
25922593
):
25932594
cmd = "a" * 640
25942595
mapdl._run(cmd)
2596+
2597+
2598+
def test_comment_on_debug_mode(mapdl, cleared):
2599+
loglevel = mapdl.logger.logger.level
2600+
2601+
mapdl.logger.logger.level = logging.ERROR
2602+
with patch("ansys.mapdl.core.Mapdl.com") as mockcom:
2603+
mapdl.parameters["asdf"] = [1, 2, 3]
2604+
mockcom.assert_not_called()
2605+
2606+
mapdl.logger.logger.level = logging.DEBUG
2607+
with patch("ansys.mapdl.core.Mapdl.com") as mockcom:
2608+
mapdl.parameters["asdf"] = [1, 2, 3]
2609+
mockcom.assert_called_once_with("Entering in non_interactive mode")
2610+
2611+
mapdl.logger.logger.level = loglevel

0 commit comments

Comments
 (0)