Introduce flake8 style guidelines (#608)

* Add venv and vs code settings to gitignore

* Remove blank lines and add trailing lines where needed

* Add flake8 config

* Add flake8 to style CI

* Convert indentation to spaces

* Fix underindentation

* Convert indentation to spaces

Author: jleonatti

.flake8

@@ -0,0 +1,8 @@
+[flake8]
+exclude = venv, __init__.py
+# To be added after refactoring code to be compliant: E501, F401, W191, W291, W293
+select = W391, E115, E117, E122, E124, E125, E225, E231, E301, E303, F403
+count = True
+max-complexity = 10
+max-line-length = 100
+statistics = True

.github/workflows/style.yml

@@ -20,3 +20,7 @@ jobs:
         run: |
           pip install -r requirements_style.txt --disable-pip-version-check
           make
+
+      - name: flake8
+        run: |
+          make flake8

.gitignore

@@ -75,4 +75,10 @@ docker/mapdl/v212
 docker/mapdl/_old
 
 # temp testing
-tmp.out
+tmp.out
+
+# virtual environment
+venv/
+
+# Visual studio code local settings
+.vscode/

Makefile

@@ -31,3 +31,7 @@ coverage-xml:
 coverage-html:
 	@echo "Reporting HTML coverage"
 	@pytest -v --cov ansys.mapdl --cov-report html
+
+flake8:
+	@echo "Running flake8"
+	@flake8 .

ansys/mapdl/core/inline_functions/nearest_queries.py

@@ -113,4 +113,3 @@ def enearn(self, n: int) -> int:
         response = self._mapdl.run(f'_=ENEARN({n})')
         integer = self._parse_parameter_integer_response(response)
         return integer
-

ansys/mapdl/core/inline_functions/normals_queries.py

@@ -268,4 +268,3 @@ def normkz(self, k1: int, k2: int, k3: int) -> float:
         response = self._mapdl.run(f'_=NORMKZ({k1}, {k2}, {k3})')
         float_ = self._parse_parameter_float_response(response)
         return float_
-

ansys/mapdl/core/launcher.py

@@ -385,7 +385,6 @@ def launch_grpc(exec_file='', jobname='file', nproc=2, ram=None,
                          stdout=subprocess.DEVNULL,
                          stderr=subprocess.DEVNULL)
 
-
     # watch for the creation of temporary files at the run_directory.
     # This lets us know that the MAPDL process has at least started
     sleep_time = 0.1

ansys/mapdl/core/mapdl_geometry.py

@@ -12,14 +12,15 @@
 - 'U' : Unselect a set from the current set.
 """
 
-FLST_LOOKUP = {'NODE': 1,  # node numbers
-               'ELEM': 2,  # element numbers
-               'KP': 3,  # keypoint numbers
-               'LINE': 4,  # line numbers
-               'AREA': 5,  # area numbers
-               'VOLU': 6,  # volume numbers
-               'TRACE': 7,  # trace points
-               'COORD': 8,  # coordinate locations
+FLST_LOOKUP = {
+    'NODE': 1,  # node numbers
+    'ELEM': 2,  # element numbers
+    'KP': 3,  # keypoint numbers
+    'LINE': 4,  # line numbers
+    'AREA': 5,  # area numbers
+    'VOLU': 6,  # volume numbers
+    'TRACE': 7,  # trace points
+    'COORD': 8,  # coordinate locations
 }
 
 def merge_polydata(items):

ansys/mapdl/core/mapdl_grpc.py

@@ -643,8 +643,8 @@ def _kill(self):
         self._exited = True
 
     def _close_process(self):
-       """Close all MAPDL processes"""
-       if self._local:
+        """Close all MAPDL processes"""
+        if self._local:
             for pid in self._pids:
                 try:
                     os.kill(pid, 9)

ansys/mapdl/core/post.py

@@ -1159,8 +1159,6 @@ def plot_nodal_total_eqv_strain(self, show_node_numbering=False, **kwargs):
         return self._plot_point_scalars(scalars,
                                         show_node_numbering=show_node_numbering,
                                         **kwargs)
-###############################################################################
-
 
     def nodal_elastic_component_strain(self, component) -> np.ndarray:
         """Elastic nodal component strain
@@ -1432,11 +1430,7 @@ def plot_nodal_elastic_eqv_strain(self, show_node_numbering=False, **kwargs):
         return self._plot_point_scalars(scalars,
                                         show_node_numbering=show_node_numbering,
                                         **kwargs)
-
-
-###############################################################################
-
-
+    
     def nodal_plastic_component_strain(self, component) -> np.ndarray:
         """Plastic nodal component strain
 
@@ -1707,11 +1701,7 @@ def plot_nodal_plastic_eqv_strain(self, show_node_numbering=False, **kwargs):
         return self._plot_point_scalars(scalars,
                                         show_node_numbering=show_node_numbering,
                                         **kwargs)
-
-
-###############################################################################
-
-
+    
     def nodal_thermal_component_strain(self, component) -> np.ndarray:
         """Thermal nodal component strain
 
@@ -1982,4 +1972,3 @@ def plot_nodal_thermal_eqv_strain(self, show_node_numbering=False, **kwargs):
         return self._plot_point_scalars(scalars,
                                         show_node_numbering=show_node_numbering,
                                         **kwargs)
-