fix: reducing the amount of gRPC calls in get and add test for get command (#4184)

* fix: reducing the amount of gRPC calls in get and add test for get command

* chore: adding changelog file 4184.miscellaneous.md [dependabot-skip]

* Update src/ansys/mapdl/core/mapdl_extended.py

Co-authored-by: Copilot <[email protected]>

* fix: improve test_get_not_muted by mocking wrinqr and asserting call

* fix: remove mute parameter from command execution in _MapdlCommandExtended

* fix: correct condition in force-output mode entry check

* fix: enhance test_get_not_muted to verify muted and unmuted states

* fix: correct assertion in test_get_not_muted to use 'mute' property

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Copilot <[email protected]>

Author: 3 people

doc/changelog.d/4184.miscellaneous.md

@@ -0,0 +1 @@
+Fix: reducing the amount of gRPC calls in get and add test for get command

src/ansys/mapdl/core/mapdl_core.py

@@ -3096,8 +3096,7 @@ def __init__(self, parent: "MapdlBase"):
 
         def __enter__(self):
             self._parent()._log.debug("Entering force-output mode")
-
-            if self._parent().wrinqr(1) != 1:  # using wrinqr is more reliable than *get
+            if self._parent().wrinqr(1) == 0:  # using wrinqr is more reliable than *get
                 self._in_nopr = True
                 self._parent()._run("/gopr")  # Going to PR mode
             else:

src/ansys/mapdl/core/mapdl_extended.py

@@ -2123,11 +2123,13 @@ def get(
         self._check_parameter_name(par)
 
         command = f"*GET,{par},{entity},{entnum},{item1},{it1num},{item2},{it2num},{item3},{it3num},{item4},{it4num}"
-        kwargs["mute"] = False
 
-        # Checking printout is not suppressed by checking "wrinqr" flag.
-        with self.force_output:
-            response = self.run(command, **kwargs)
+        response = self.run(command, **kwargs)
+
+        if not response:
+            # If no response is received, re-run the command with force_output to ensure output is captured.
+            with self.force_output:
+                response = self.run(command, **kwargs)
 
         if self._store_commands:
             # Return early in non_interactive

tests/test_mapdl.py

@@ -2019,6 +2019,7 @@ def test_force_output(mapdl, cleared):
             assert mapdl.prep7()
         assert not mapdl.prep7()
 
+    with mapdl.muted:
         mapdl._run("nopr")
         with mapdl.force_output:
             assert mapdl.prep7()
@@ -2034,6 +2035,23 @@ def test_force_output(mapdl, cleared):
     assert mapdl.prep7()
 
 
+def test_get_not_muted(mapdl, cleared):
+    mapdl.gopr()
+    assert not mapdl.mute
+
+    with patch.object(mapdl, "wrinqr", wraps=mapdl.wrinqr) as mock_muted:
+        with mapdl.muted:
+            assert mapdl.get("line1", "LINE", 0, "NUM", "MAX") is not None
+
+    mock_muted.assert_called_once()
+
+    assert mapdl.mute is False
+    with patch.object(mapdl, "wrinqr", wraps=mapdl.wrinqr) as mock_not_muted:
+        assert mapdl.get("line1", "LINE", 0, "NUM", "MAX") is not None
+
+    mock_not_muted.assert_not_called()
+
+
 def test_session_id(mapdl, cleared, running_test):
     mapdl._strict_session_id_check = True
     assert mapdl._session_id is not None