refactor: Iterate over the dictionary directly instead of using .keys(). (#3631)

* Iterate over the dictionay directly instead of using .keys().

* chore: adding changelog file 3631.added.md [dependabot-skip]

* chore: adding changelog file 3631.added.md [dependabot-skip]

* chore: update src/ansys/mapdl/core/pool.py

* ci: auto fixes from pre-commit.com hooks.

for more information, see https://pre-commit.ci

* ci: auto fixes from pre-commit.com hooks.

for more information, see https://pre-commit.ci

* chore: empty commit to trigger CICD

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: German <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: 4 people

doc/changelog.d/3631.added.md

@@ -0,0 +1 @@
+refactor: Iterate over the dictionary directly instead of using .keys().

src/ansys/mapdl/core/commands.py

@@ -845,8 +845,8 @@ def bc_colnames(self) -> Optional[List[str]]:
 
         title = self._get_body()[0]
 
-        _bcType = [i for i in bc_type.keys() if i in title]
-        _entity = [i for i in entity.keys() if i in title]
+        _bcType = [i for i in bc_type if i in title]
+        _entity = [i for i in entity if i in title]
 
         if _bcType and _entity:
 

src/ansys/mapdl/core/mapdl_grpc.py

@@ -2941,7 +2941,7 @@ def _mat_data(self, pname, raw=False):
 
     @property
     def locked(self):
-        """Instance is in use within a pool"""
+        """Instance is in use within a pool."""
         return self._locked
 
     @locked.setter
@@ -2987,7 +2987,7 @@ def _generate_iges(self):
 
     @property
     def _distributed_result_file(self):
-        """Path of the distributed result file"""
+        """Path of the distributed result file."""
         if not self._distributed:
             return
 
@@ -3022,7 +3022,7 @@ def _distributed_result_file(self):
 
     @property
     def thermal_result(self):
-        """The thermal result object"""
+        """The thermal result object."""
         self._prioritize_thermal = True
         result = self.result
         self._prioritize_thermal = False
@@ -3045,7 +3045,7 @@ def list_error_file(self):
             return open(os.path.join(self.directory, error_file)).read()
         elif self._exited:
             raise MapdlExitedError(
-                "Cannot list error file when MAPDL Service has " "exited"
+                "Cannot list error file when MAPDL Service has exited"
             )
 
         return self._download_as_raw(error_file).decode("latin-1")
@@ -3060,9 +3060,7 @@ def cmatrix(
         capname="",
         **kwargs,
     ):
-        """Run CMATRIX in non-interactive mode and return the response
-        from file.
-        """
+        """Run CMATRIX in non-interactive mode and return the response from file."""
 
         # The CMATRIX command needs to run in non-interactive mode
         if not self._store_commands:

src/ansys/mapdl/core/pool.py

@@ -614,8 +614,10 @@ def run():
                     try:
                         self._exiting_i += 1
                         instance.exit()
-                    except Exception as e:
-                        LOG.error("Failed to close instance", exc_info=True)
+                    except Exception:
+                        LOG.error(
+                            f"Failed to close instance due to:\n{e}", exc_info=True
+                        )
                         self._exiting_i -= 1
 
             else: