chore: remove xfail markers from most flaky tests (#3899)

* fix: remove xfail markers from flaky tests

* chore: adding changelog file 3899.fixed.md [dependabot-skip]

* chore: adding changelog file 3899.added.md [dependabot-skip]

* fix: remove skip marker from test_plot_incomplete_nodal_selection

* fix: remove skip marker from test_plot_incomplete_element_selection

---------

Co-authored-by: pyansys-ci-bot <[email protected]>

Author: germa89

doc/changelog.d/3899.added.md

@@ -0,0 +1 @@
+chore: remove xfail markers from most flaky tests

tests/test_importing_geometries.py

@@ -159,7 +159,6 @@ def test_readin_x_t(mapdl, cleared):
     clear_wkdir_from_cads(mapdl)
 
 
-@pytest.mark.xfail(True, reason="Command seems broken. See #2377")
 def test_readin_catiav5(mapdl, cleared):
     if ON_CI and mapdl.version <= 22.2 and not ON_UBUNTU:
         context = pytest.raises(

tests/test_mapdl.py

@@ -2465,7 +2465,6 @@ def test_graphics_backend(mapdl, cleared):
 
 
 @requires("local")
-@pytest.mark.xfail(reason="Flaky test. See #2435")
 def test_remove_temp_dir_on_exit(mapdl, cleared, tmpdir):
     path = os.path.join(tempfile.gettempdir(), "ansys_" + random_string())
     os.makedirs(path)
@@ -2486,7 +2485,6 @@ def test_remove_temp_dir_on_exit(mapdl, cleared, tmpdir):
 
 @requires("local")
 @requires("nostudent")
-@pytest.mark.xfail(reason="Flaky test. See #2435")
 def test_remove_temp_dir_on_exit_with_launch_mapdl(mapdl, cleared):
 
     mapdl_2 = launch_mapdl(remove_temp_dir_on_exit=True, port=PORT1)

tests/test_pool.py

@@ -177,7 +177,6 @@ def test_simple_map(self, pool):
 
     @skip_if_ignore_pool
     @requires("local")
-    @pytest.mark.xfail(reason="Flaky test. See #2435")
     def test_map_timeout(self, pool):
         pool_sz = len(pool)
 

tests/test_post.py

@@ -1241,7 +1241,6 @@ def test_plot_nodal_contact_friction_stress(mapdl, resume):
 
     @staticmethod
     @requires("ansys-tools-visualization_interface")
-    @pytest.mark.skipif(True, reason="Crash python until #3782 is fixed.")
     def test_plot_incomplete_element_selection(mapdl, resume):
         mapdl.esel("S", "ELEM", "", 1, mapdl.mesh.n_elem // 2)
         assert mapdl.post_processing.plot_element_displacement() is None
@@ -1262,7 +1261,6 @@ def test_plot_incomplete_element_selection(mapdl, resume):
 
     @staticmethod
     @requires("ansys-tools-visualization_interface")
-    @pytest.mark.skipif(True, reason="Crash python until #3782 is fixed.")
     def test_plot_incomplete_nodal_selection(mapdl, resume, verify_image_cache):
         verify_image_cache.skip = True
 

tests/test_xpl.py

@@ -202,7 +202,6 @@ def test_goto(xpl):
 
     @requires("ansys-math-core")
     @pytest.mark.usefixtures("check_supports_extract")
-    @pytest.mark.xfail(reason="Flaky test. See #2435")
     def test_extract(self, xpl):
         # expecting fixture to already have a non-result file open
         assert xpl._filename[-3:] != "rst"