fix(cli): check access process on windows (#4293)

* fix(cli): check access process on windows

When running on windows, the process `username()` can contain the DOMAIN which makes the comparison fail.

* ci: auto fixes from pre-commit.com hooks.

for more information, see https://pre-commit.ci

* chore: adding changelog file 4293.fixed.md [dependabot-skip]

* fix: add missing import and take into account review

* test: add test with domain in username

* ci: auto fixes from pre-commit.com hooks.

for more information, see https://pre-commit.ci

* test: remove print statement from domain username handling test

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: German <[email protected]>

Author: 4 people

doc/changelog.d/4293.fixed.md

@@ -0,0 +1 @@
+Check access process on windows

src/ansys/mapdl/core/cli/stop.py

@@ -187,13 +187,16 @@ def _can_access_process(proc):
         True if we can safely access and kill the process
     """
     import getpass
+    import platform
 
     import psutil
 
     try:
         # Check if we can access basic process info and if it belongs to current user
         current_user = getpass.getuser()
         process_user = proc.username()
+        if platform.system() == "Windows" and "\\" in process_user:
+            return current_user == process_user.split("\\")[-1]
         return process_user == current_user
     except (psutil.AccessDenied, psutil.NoSuchProcess):
         # Cannot access process or process doesn't exist

tests/test_cli.py

@@ -21,6 +21,7 @@
 # SOFTWARE.
 
 import os
+import platform
 import re
 import subprocess
 from typing import Callable
@@ -289,6 +290,40 @@ def mock_kill_process(proc: psutil.Process):
         print("✅ Permission handling test passed - no crashes occurred")
 
 
+@requires("click")
+@pytest.mark.skipif(
+    platform.system() != "Windows", reason="Domain usernames are Windows-specific"
+)
+def test_pymapdl_stop_with_username_containing_domain(run_cli):
+    """Test that pymapdl stop processes when a process username contains DOMAIN information."""
+    current_user = "someuser"
+
+    mock_process = MagicMock(spec=psutil.Process)
+    mock_process.pid = 12
+    mock_process.name.return_value = "ansys252"
+    mock_process.status.return_value = psutil.STATUS_RUNNING
+    mock_process.cmdline.return_value = ["ansys251", "-grpc", "-port", "50052"]
+    mock_process.username.return_value = f"DOMAIN\\{current_user}"
+
+    killed_processes: list[int] = []
+
+    def mock_kill_process(proc: psutil.Process):
+        """Track which processes would be killed."""
+        killed_processes.append(proc.pid)
+
+    with (
+        patch("getpass.getuser", return_value=current_user),
+        patch("psutil.process_iter", return_value=[mock_process]),
+        patch("psutil.pid_exists", return_value=True),
+        patch("ansys.mapdl.core.cli.stop._kill_process", side_effect=mock_kill_process),
+    ):
+        killed_processes.clear()
+        output = run_cli("stop --all")
+
+        assert "success" in output.lower()
+        assert killed_processes == [12]
+
+
 @requires("click")
 @pytest.mark.parametrize(
     "arg,check",