refactor: removing warnings (#3763)

* fix: removing some warnings

* refactor: using isin

* test: raising warnings

* chore: adding changelog file 3763.added.md [dependabot-skip]

* fix: update regex pattern in logging tests for consistency

* fix: console arg in pytest cli

* fix: more warnings

* fix: marker

* test: removing dpf

* refactor: small refactor of warnings.

* fix: killing started processes during testing

* fix: killing started processes during testing

* feat: removing warning flag

* revert: "test: removing dpf"

This reverts commit ace806a.

* fix: tests

* fix: warnings

* fix: conftest

* refactor: pytest mark. Removing only-gui

---------

Co-authored-by: pyansys-ci-bot <[email protected]>

Author: germa89

doc/changelog.d/3763.added.md

@@ -0,0 +1 @@
+refactor: removing warnings

pyproject.toml

@@ -123,6 +123,7 @@ pymapdl = "ansys.mapdl.core.cli:main"
 addopts = "-rxXsa -vvv --maxfail=10 --random-order-bucket=class --random-order --durations=10  --timeout=180"
 junit_family = "legacy"
 filterwarnings = [
+    "ignore::ResourceWarning",
     "ignore::FutureWarning",
     "ignore::PendingDeprecationWarning",
     "ignore::DeprecationWarning",
@@ -134,7 +135,9 @@ filterwarnings = [
 markers = [
     "skip_grpc: skip tests using grpc",
     "gui: skip tests that launch the GUI interface",
+    "console: Run also console tests",
 ]
+
 testpaths = "tests"
 image_cache_dir = "tests/.image_cache"
 # Output logging records as they are emitted directly into the console

src/ansys/mapdl/core/launcher.py

@@ -306,7 +306,7 @@ def get_process_at_port(port) -> Optional[psutil.Process]:
     for proc in psutil.process_iter():
         try:
             # just to check if we can access the port
-            connections = proc.connections()
+            connections = proc.net_connections()
         except psutil.AccessDenied:
             continue
         except psutil.NoSuchProcess:

src/ansys/mapdl/core/mapdl_core.py

@@ -2942,7 +2942,9 @@ def _raise_output_errors(self, response):
 
                 # Raising errors
                 if error_is_fine:
-                    self._log.warn("PERMITTED ERROR: " + permited_error_message.string)
+                    self._log.warning(
+                        "PERMITTED ERROR: " + permited_error_message.string
+                    )
                     continue
                 else:
                     # We don't need to log exception because they already included in the main logger.

src/ansys/mapdl/core/mapdl_grpc.py

@@ -2546,7 +2546,7 @@ def _download_from_remote(
 
         else:
             raise ValueError(
-                f"The `file` parameter type ({type(files)}) is not supported."
+                f"The `file` parameter type ({type(files)}) is not supported. "
                 "Only strings, tuple of strings or list of strings are allowed."
             )
 
@@ -2651,9 +2651,10 @@ def _download(
         )
 
         if not file_size:
-            warn(
-                f'File "{target_name}" is empty or does not exist in {self.list_files()}.'
-            )
+            if target_name not in self.list_files():
+                warn(f'File "{target_name}" does not exist.')
+            else:
+                warn(f'File "{target_name}" is empty.')
 
     @protect_grpc
     def upload(self, file_name: str, progress_bar: bool = _HAS_TQDM) -> str:

tests/conftest.py

@@ -168,6 +168,9 @@ def requires(requirement: str):
     elif "console" == requirement:
         return pytest.mark.console
 
+    elif "gui" == requirement:
+        return pytest.mark.gui
+
     else:
         return requires_dependency(requirement)
 
@@ -338,25 +341,28 @@ def pytest_addoption(parser):
         "--console",
         action="store_true",
         default=False,
+        dest="console",
         help="run console tests",
     )
-    parser.addoption("--gui", action="store_true", default=False, help="run GUI tests")
     parser.addoption(
-        "--only-gui",
-        action="store_true",
-        default=False,
-        help="run only GUI tests",
+        "--gui", action="store_true", default=False, dest="gui", help="run GUI tests"
     )
 
 
-def pytest_collection_modifyitems(config, items):
+def pytest_collection_modifyitems(session, config, items):
     if not config.getoption("--console"):
         # --console given in cli: run console interface tests
         skip_console = pytest.mark.skip(reason="need --console option to run")
         for item in items:
             if "console" in item.keywords:
                 item.add_marker(skip_console)
 
+    if not config.getoption("--gui"):
+        skip_gui = pytest.mark.skip(reason="need --gui option to run")
+        for item in items:
+            if "gui" in item.keywords:
+                item.add_marker(skip_gui)
+
     if not HAS_GRPC:
         skip_grpc = pytest.mark.skip(
             reason="Requires gRPC connection (at least v211 to run)"
@@ -365,21 +371,6 @@ def pytest_collection_modifyitems(config, items):
             if "skip_grpc" in item.keywords:
                 item.add_marker(skip_grpc)
 
-    only_gui_filter = config.getoption("--only-gui")
-    if only_gui_filter:
-        new_items = []
-        for item in items:
-            mark = item.get_closest_marker("requires_gui")
-            if mark and mark.name == "requires_gui":
-                new_items.append(item)
-        items[:] = new_items
-
-    if not config.getoption("--gui") and not only_gui_filter:
-        skip_gui = pytest.mark.skip(reason="Requires to launch MAPDL GUI interface.")
-        for item in items:
-            if "requires_gui" in item.keywords:
-                item.add_marker(skip_gui)
-
 
 ################################################################
 #
@@ -670,6 +661,7 @@ def _patch_method(method):
     (_patch_method("_subscribe_to_channel"), _returns("")),
     (_patch_method("_run_at_connect"), _returns("")),
     (_patch_method("_exit_mapdl"), _returns(None)),
+    (_patch_method("kill_job"), _returns(None)),
     (
         _patch_method("_check_mapdl_os"),
         _returns("linux" if os.name == "posix" else "win"),

tests/test_cli.py

@@ -57,9 +57,7 @@ def make_fake_process(pid, name, port=PORT1, ansys_process=False, n_children=0):
     return mock_process
 
 
-@pytest.fixture
-@requires("click")
-@requires("nostudent")
+@pytest.fixture(scope="function")
 def run_cli():
     def do_run(arguments=""):
         from click.testing import CliRunner
@@ -373,6 +371,9 @@ def test_convert_pipe(output):
     assert "Script generated by ansys-mapdl-core version" in stdout
     assert "mapdl.exit()" in stdout
 
+    process_pymapdl.kill()
+    process_echo.kill()
+
 
 DEFAULT_ARGS = {
     "apdl_strings": "/prep7\nBLOCK,0,1,0,1,0,1",

tests/test_commands.py

@@ -36,7 +36,7 @@
     StringWithLiteralRepr,
 )
 from ansys.mapdl.core.examples.verif_files import vmfiles
-from conftest import TestClass, has_dependency, requires
+from conftest import NullContext, TestClass, has_dependency, requires
 
 if has_dependency("pandas"):
     import pandas as pd
@@ -615,6 +615,9 @@ class Test_MAPDL_commands(TestClass):
         "vwrite",
     ]
 
+    RAISE_WARNINGS = ["eshape"]
+    RAISE_EXCEPTIONS = []
+
     @staticmethod
     def fake_wrap(*args, **kwags):
         return args[0]
@@ -658,11 +661,19 @@ def test_command(self, mapdl, cmd):
 
         args = [f"arg{i}" for i in range(len(parm) - 1)]  # 3 = self, cmd, kwargs
 
-        if list(parm)[0].lower() == "self":
-            args = args[:-1]
-            post = func(mapdl, *args)
+        if cmd in self.RAISE_WARNINGS:
+            context = pytest.warns(UserWarning)
+        elif cmd in self.RAISE_EXCEPTIONS:
+            context = pytest.raises(Exception)
         else:
-            post = func(*args)
+            context = NullContext()
+
+        with context:
+            if list(parm)[0].lower() == "self":
+                args = args[:-1]
+                post = func(mapdl, *args)
+            else:
+                post = func(*args)
 
         for arg in args:
             assert arg in post

tests/test_component.py

@@ -100,7 +100,7 @@ def test_parsing_too_many_components(mapdl, cleared):
     assert "***" not in s
     assert "*****MAPDL" not in s
     for i in range(1, 100):
-        assert re.search(f"NODE_{i:03.0f}\s+: NODE", s)
+        assert re.search(f"NODE_{i:03.0f}" + r"\s+: NODE", s)
 
 
 class Test_components(TestClass):

tests/test_dpf.py

@@ -27,7 +27,7 @@
 
 from conftest import HAS_DPF, ON_CI, has_dependency, requires
 
-if not has_dependency("ansys-dpf-core") or not HAS_DPF:
+if not HAS_DPF or not has_dependency("ansys-dpf-core"):
     pytest.skip(allow_module_level=True)
 
 from ansys.dpf import core as dpf