Skip to content

Commit 9328091

Browse files
fix: fixed unit tests (#671)
Co-authored-by: pyansys-ci-bot <[email protected]>
1 parent d34a9b2 commit 9328091

File tree

5 files changed

+12
-6
lines changed

5 files changed

+12
-6
lines changed

doc/changelog.d/671.test.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix: fixed unit tests

src/ansys/sherlock/core/common.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,10 @@ def list_solder_materials(self) -> list[str]:
145145
if not self._is_connection_up():
146146
raise SherlockNoGrpcConnectionException()
147147

148-
request = SherlockCommonService_pb2.GetSoldersRequest()
149-
response = self.stub.getSolders(request)
148+
request = SherlockCommonService_pb2.SolderInfoRequest()
149+
response = self.stub.getSolderInfo(request)
150150

151-
return response.solderName
151+
return response.solders
152152

153153
@require_version(251)
154154
def get_sherlock_info(self) -> str:

src/ansys/sherlock/core/errors.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,13 +224,17 @@ def str_itr(self):
224224
class SherlockAddRandomVibeEventError(Exception):
225225
"""Contains the errors raised when a random vibe event cannot be added."""
226226

227-
def __init__(self, message: str):
227+
def __init__(self, message: Optional[str] = None, error_array: Optional[list[str]] = None):
228228
"""Initialize error message."""
229229
self.message = message
230+
self.error_array = error_array
230231

231232
def str_itr(self):
232233
"""Create list of error messages."""
233-
if self.message is not None:
234+
if self.error_array is not None:
235+
return [f"Add random vibe event error: {error}" for error in self.error_array]
236+
237+
elif self.message is not None:
234238
return [f"Add random vibe event error: {self.message}"]
235239

236240

tests/test_lifecycle.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2257,6 +2257,7 @@ def helper_test_load_harmonic_profile(lifecycle: Lifecycle):
22572257
"Phase 1",
22582258
"Harmonic Event",
22592259
"Test_Profile.dat",
2260+
"x",
22602261
)
22612262
pytest.fail("No exception raised when using an invalid parameter")
22622263
except Exception as e:

tests/test_parts.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ def helper_test_update_parts_from_AVL(parts: Parts):
159159
avl_description=AVLDescription.ASSIGN_APPROVED_DESCRIPTION,
160160
)
161161

162-
assert response.returnCode.value == 0
162+
assert response == 0
163163
except SherlockUpdatePartsFromAVLError as e:
164164
pytest.fail(e.message)
165165

0 commit comments

Comments
 (0)