|
5 | 5 | **Please mention the issue number or describe the problem this pull request addresses.** |
6 | 6 |
|
7 | 7 | ## Checklist: |
8 | | -- [] Run unit tests and make sure they all pass |
| 8 | +- [ ] Run unit tests and make sure they all pass |
9 | 9 | - Run tests without Sherlock running |
10 | 10 | - Run tests with Sherlock GRPC connection |
11 | | -- [] Check and fix style errors |
| 11 | +- [ ] Check and fix style errors |
12 | 12 | - pre-commit command line check |
13 | 13 | - Problems tab in PyCharm |
14 | | -- [] Bench test new/modified APIs by using and modifying the code in the example for the API method |
15 | | -- [] Add new classes to rst files, located at: <pysherlock>\doc\source\api |
16 | | -- [] Generate documentation |
17 | | -- [] Verify the HTML. It gets generated at: <pysherlock>\doc\build\html. |
| 14 | +- [ ] Bench test new/modified APIs by using and modifying the code in the example for the API method |
| 15 | +- [ ] Add new classes to rst files, located at: <pysherlock>\doc\source\api |
| 16 | +- [ ] Generate documentation |
| 17 | +- [ ] Verify the HTML. It gets generated at: <pysherlock>\doc\build\html. |
18 | 18 | - Open index.html |
19 | 19 | - Click on "API Reference" at the top. |
20 | 20 | - Verify HTML for API changes. |
21 | | -- [] Check that test code coverage is at least 80% when Sherlock is running |
22 | | -- [] Make sure that the title of the pull request follows [Commit naming conventions](https://dev.docs.pyansys.com/how-to/contributing.html#commit-naming-conventions) (e.g. ``feat: adding new PySherlock command``) |
| 21 | +- [ ] Check that test code coverage is at least 80% when Sherlock is running |
| 22 | +- [ ] Check vulnerabilities locally |
| 23 | +- [ ] Make sure that the title of the pull request follows [Commit naming conventions](https://dev.docs.pyansys.com/how-to/contributing.html#commit-naming-conventions) (e.g. ``feat: adding new PySherlock command``) |
0 commit comments