Skip to content

Remove calling APIs for returning units for specific typesΒ #293

@ansnfernand

Description

@ansnfernand

πŸ“ Description of the feature

Don't use the following APIs since ListUnits(UnitType) can be used:

Stackup service

  • ListLaminateThicknessUnits

Lifecycle service

  • ListFreqUnits (not found in PySherlock)
  • ListTempUnits (not found in PySherlock)
  • ListAmplUnits
  • ListShockLoadUnits

πŸ’‘ Steps for implementing the feature

These units are used for validation of parameters in PySherlock.
Remove this validation (and associated unit tests).
Remove the code that is making requests and caching these units.

Bench test to determine if Sherlock is handling invalid units. If not, create Sherlock stories to address that.

πŸ”— Useful links and references

Metadata

Metadata

Assignees

Labels

maintenancePackage and maintenance related

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions