Skip to content

Commit 33a4ab0

Browse files
authored
Merge pull request #539 from ant-media/effect-camera
Add turn off effect camera to turnOffLocalCamera
2 parents 9464905 + d09ea54 commit 33a4ab0

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

src/main/js/webrtc_adaptor.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2201,6 +2201,7 @@ export class WebRTCAdaptor {
22012201
* @returns
22022202
*/
22032203
turnOffLocalCamera(streamId) {
2204+
this.turnOffEffectCamera(streamId);
22042205
return this.mediaManager.turnOffLocalCamera(streamId);
22052206
}
22062207
/**

src/test/js/webrtc_adaptor.test.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1251,39 +1251,47 @@ describe("WebRTCAdaptor", function() {
12511251
describe("turnOffLocalCamera", () => {
12521252
let adaptor;
12531253
let mockMediaManager;
1254+
let turnOffEffectCameraFake;
12541255

12551256
beforeEach(function() {
12561257
mockMediaManager = {
12571258
turnOffLocalCamera: sinon.fake()
12581259
};
12591260

1261+
turnOffEffectCameraFake = sinon.fake();
1262+
12601263
adaptor = new WebRTCAdaptor({
12611264
websocketURL: "ws://example.com",
12621265
isPlayMode: true,
1263-
mediaManager: mockMediaManager,
1264-
initializeComponents: false
1266+
mediaManager: mockMediaManager,
1267+
initializeComponents: false
12651268
});
1269+
adaptor.turnOffEffectCamera = turnOffEffectCameraFake;
12661270
});
12671271

12681272
it("should call turnOffLocalCamera on mediaManager with correct streamId", function() {
12691273
const streamId = "testStreamId";
12701274
let result = adaptor.turnOffLocalCamera(streamId);
12711275
assert.notEqual(result, undefined);
1276+
assert(turnOffEffectCameraFake.calledOnceWithExactly(streamId));
12721277
});
12731278

12741279
it("should handle undefined streamId", function() {
12751280
let result = adaptor.turnOffLocalCamera(undefined);
12761281
assert.notEqual(result, undefined);
1282+
assert(turnOffEffectCameraFake.calledOnceWithExactly(undefined));
12771283
});
12781284

12791285
it("should handle null streamId", function() {
12801286
let result = adaptor.turnOffLocalCamera(null);
12811287
assert.notEqual(result, undefined);
1288+
assert(turnOffEffectCameraFake.calledOnceWithExactly(null));
12821289
});
12831290

12841291
it("should handle empty string streamId", function() {
12851292
let result = adaptor.turnOffLocalCamera("");
12861293
assert.notEqual(result, undefined);
1294+
assert(turnOffEffectCameraFake.calledOnceWithExactly(""));
12871295
});
12881296
});
12891297

0 commit comments

Comments
 (0)