PHP 8.5 | Prevent some "Using null as an array offset" deprecation notices

These are only some "low hanging fruit" fixes. There is a deeper problem in the underlying wiring causing a lot more of these deprecation notices, which I haven't been able to track down yet.

At least the fixes in this PR should allow to focus on the deeper problem by getting rid of a sizable amount of deprecation notices.

Ref: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_using_values_null_as_an_array_offset_and_when_calling_array_key_exists

Author: jrfnl

src/CallRerouting.php

@@ -181,7 +181,7 @@ function inPreprocessedFile($callable)
 function connectFunction($function, callable $target, ?Handle $handle = null)
 {
     $handle = $handle ?: new Handle;
-    $routes = &State::$routes[null][$function];
+    $routes = &State::$routes[''][$function];
     $offset = Utils\append($routes, [$target, $handle]);
     $handle->addReference($routes[$offset]);
     return $handle;
@@ -311,6 +311,10 @@ function dispatch($class, $calledClass, $method, $frame, &$result, ?array $args
 function relay(?array $args = null)
 {
     list($class, $method, $offset) = end(State::$routeStack);
+    $class  = $class ?? '';
+    $method = $method ?? '';
+    $offset = $offset ?? '';
+
     $route = &State::$routes[$class][$method][$offset];
     $backup = $route;
     $route = ['Patchwork\fallBack', new Handle];
@@ -387,6 +391,9 @@ function getHHVMExpirationHandler($function)
 
 function getRoutesFor($class, $method)
 {
+    $class  = $class ?? '';
+    $method = $method ?? '';
+
     if (!isset(State::$routes[$class][$method])) {
         return [];
     }
@@ -431,7 +438,7 @@ function createStubsForInternals()
                 '$__pwRefOffset = 0;',
                 '$__pwRefOffset = 1;',
                 \Patchwork\CodeManipulation\Actions\CallRerouting\CALL_INTERCEPTION_CODE
-            ), 
+            ),
             $refs
         );
         eval(strtr(INTERNAL_STUB_CODE, [

tests/arguments.phpt

@@ -16,9 +16,11 @@ Patchwork\replace("setArrayElement", function(array &$array, $key, $value) {
 
 $array = [0, 1, "foo" => 2, 3];
 
+var_dump(debug_backtrace());
 setArrayElement($array, "foo", "bar");
 
-assert($array == [0, 1, "foo" => "bar", 3]);
+var_dump(debug_backtrace());
+assert($array === [0, 1, "foo" => "bar", 3]);
 
 ?>
 ===DONE===