Skip to content

chore(tsan): Ignore TSan checks in OpenMP's race#1300

Merged
LHT129 merged 1 commit intoantgroup:mainfrom
LHT129:tsan
Oct 29, 2025
Merged

chore(tsan): Ignore TSan checks in OpenMP's race#1300
LHT129 merged 1 commit intoantgroup:mainfrom
LHT129:tsan

Conversation

@LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Oct 29, 2025

Summary by Sourcery

CI:

  • use race suppression and TSAN_OPTIONS for libomp in the ThreadSanitizer CI workflow

@LHT129 LHT129 self-assigned this Oct 29, 2025
@LHT129 LHT129 requested a review from wxyucs as a code owner October 29, 2025 03:30
@LHT129 LHT129 added kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) version/0.18 labels Oct 29, 2025
@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 29, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR modifies the TSAN build-and-test workflow to ignore OpenMP race conditions by updating the suppression file entry and switching the environment variable from LSAN to TSAN.

File-Level Changes

Change Details Files
Switch suppression focus from leak detection to race detection in the TSAN workflow
  • Update suppression entry from 'leak:libomp.so' to 'race:libomp.so'
  • Replace LSAN_OPTIONS with TSAN_OPTIONS for suppression loading
.github/workflows/tsan_build_and_test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@LHT129 LHT129 requested a review from inabao October 29, 2025 03:30
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
- Coverage   91.56%   91.55%   -0.02%     
==========================================
  Files         320      320              
  Lines       17672    17672              
==========================================
- Hits        16182    16180       -2     
- Misses       1490     1492       +2     
Flag Coverage Δ
cpp 91.55% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 91.15% <ø> (ø)
datacell 93.01% <ø> (ø)
index 90.65% <ø> (-0.07%) ⬇️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9ac223...8f89cc9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LHT129 LHT129 merged commit 07f6c29 into antgroup:main Oct 29, 2025
39 checks passed
Roxanne0321 pushed a commit to Roxanne0321/vsag that referenced this pull request Nov 9, 2025
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/XS version/0.18

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments