refactor: Promote "no-empty" eslint rule from "recommended" to "minimal" and fix violations (microsoft#26163)

Part of an ongoing effort to collapse the "recommended" and
"minimal-deprecated" configurations together so we can remove the
latter.

Author: Josmithr

common/build/eslint-config-fluid/CHANGELOG.md

@@ -90,6 +90,7 @@ Packages can now use `eslint.config.mjs` instead of `.eslintrc.cjs`, but the leg
 
 - `@typescript-eslint/explicit-function-return-type`
 - `@typescript-eslint/no-import-type-side-effects`
+- `no-empty`
 
 #### Rule modifications
 

common/build/eslint-config-fluid/minimal-deprecated.js

@@ -196,6 +196,7 @@ module.exports = {
 
 		"eqeqeq": ["error", "smart"],
 		"import-x/no-deprecated": "error",
+		"no-empty": "error",
 		"no-multi-spaces": [
 			"error",
 			{
@@ -274,7 +275,6 @@ module.exports = {
 		"@typescript-eslint/consistent-type-imports": "off",
 
 		"func-call-spacing": "off", // Off because it conflicts with typescript-formatter
-		"no-empty": "off",
 		"no-void": "off",
 		"require-atomic-updates": "off",
 

common/build/eslint-config-fluid/printed-configs/minimal.json

@@ -1419,7 +1419,7 @@
             }
         ],
         "no-empty": [
-            "off",
+            "error",
             {
                 "allowEmptyCatch": false
             }

common/build/eslint-config-fluid/recommended.js

@@ -23,13 +23,9 @@ module.exports = {
 	rules: {
 		// RECOMMENDED RULES
 		"@rushstack/no-new-null": "error",
-		"no-empty": "error",
 		"no-void": "error",
 		"require-atomic-updates": "error",
 
-		// This rule ensures that our Intellisense looks good by verifying the TSDoc syntax.
-		"tsdoc/syntax": "error",
-
 		// #region `unicorn` rule overrides
 
 		// TODO: Enable this rule and fix violations once eslint9 upgrade is done

examples/utils/webpack-fluid-loader/src/odspUrlResolver.ts

@@ -27,7 +27,9 @@ export class OdspUrlResolver implements IUrlResolver {
 		try {
 			const resolvedUrl = await this.driverUrlResolver.resolve(request);
 			return resolvedUrl;
-		} catch (error) {}
+		} catch (error) {
+			// TODO: document why we are ignoring the error here
+		}
 
 		const url = new URL(request.url);
 

examples/utils/webpack-fluid-loader/src/routes.ts

@@ -209,7 +209,9 @@ const makeAfterMiddlewares = (
 				let toLog = error;
 				try {
 					toLog = JSON.stringify(error);
-				} catch {}
+				} catch {
+					// TODO: document why we are ignoring the error here
+				}
 				console.log(toLog);
 			}
 			if (!canContinue) {

packages/drivers/driver-base/src/documentDeltaConnection.ts

@@ -557,7 +557,9 @@ export class DocumentDeltaConnection
 						// That's a WebSocket. Clear it as we can't log it.
 						description.target = undefined;
 					}
-				} catch (_e) {}
+				} catch (_e) {
+					// TODO: document why we are ignoring the error here
+				}
 
 				// Handle socket transport downgrading when not offline.
 				if (

packages/loader/driver-utils/src/test/runWithRetry.spec.ts

@@ -108,7 +108,9 @@ describe("runWithRetry Tests", () => {
 		};
 		try {
 			success = await runWithFastSetTimeout(async () => runWithRetry(api, "test", logger, {}));
-		} catch (error) {}
+		} catch (error) {
+			// Ignore the error
+		}
 		assert.strictEqual(retryTimes, 0, "Should retry");
 		assert.strictEqual(success, true, "Should succeed as retry should be successful");
 	});
@@ -128,7 +130,9 @@ describe("runWithRetry Tests", () => {
 		try {
 			success = await runWithFastSetTimeout(async () => runWithRetry(api, "test", logger, {}));
 			assert.fail("Should not succeed");
-		} catch (error) {}
+		} catch (error) {
+			// Ignore the error
+		}
 		assert.strictEqual(retryTimes, 0, "Should not retry");
 		assert.strictEqual(success, false, "Should not succeed as canRetry was not set");
 	});
@@ -147,7 +151,9 @@ describe("runWithRetry Tests", () => {
 		try {
 			success = await runWithFastSetTimeout(async () => runWithRetry(api, "test", logger, {}));
 			assert.fail("Should not succeed");
-		} catch (error) {}
+		} catch (error) {
+			// Ignore the error
+		}
 		assert.strictEqual(retryTimes, 0, "Should not retry");
 		assert.strictEqual(success, false, "Should not succeed as canRetry was not set");
 	});
@@ -173,7 +179,9 @@ describe("runWithRetry Tests", () => {
 				}),
 			);
 			assert.fail("Should not succeed");
-		} catch (error) {}
+		} catch (error) {
+			// Ignore the error
+		}
 		assert.strictEqual(retryTimes, 0, "Should not retry");
 		assert.strictEqual(success, false, "Should not succeed as retrying was disabled");
 	});

packages/test/snapshots/src/replayMultipleFiles.ts

@@ -390,7 +390,9 @@ async function processNode(
 	try {
 		threads = await import("worker_threads");
 		threads.Worker.EventEmitter.defaultMaxListeners = 20;
-	} catch (err) {}
+	} catch (err) {
+		// TODO: document why we are ignoring the error here
+	}
 
 	if (!concurrently || !threads) {
 		await processOneNode(workerData);

packages/test/test-end-to-end-tests/src/test/detachedContainerTests.spec.ts

@@ -1066,7 +1066,9 @@ describeCompat("Detached Container", "NoCompat", (getTestObjectProvider, apis) =
 			try {
 				await container.attach(request);
 				assert.fail("expected attach to fail!");
-			} catch (e) {}
+			} catch (e) {
+				// Ignore the error
+			}
 			assert.strictEqual(container.closed, true, "Container should be closed");
 		},
 	);
@@ -1117,7 +1119,9 @@ describeCompat("Detached Container", "NoCompat", (getTestObjectProvider, apis) =
 			try {
 				await container.attach(request);
 				assert.fail("expected attach to fail!");
-			} catch (e) {}
+			} catch (e) {
+				// Ignore the error
+			}
 			assert.strictEqual(container.closed, true, "Container should be closed");
 		},
 	);