Skip to content

Commit 8396123

Browse files
tylerbutleranthony-murphy-agent
authored andcommitted
build(client): Move eslint-config-fluid to client release group (microsoft#25806)
## Description This change moves the `eslint-config-fluid` package into the client release group and makes it private. ### Changes: - Moved `@fluidframework/eslint-config-fluid` to the client release group - Updated the package version and mark it private - Updated all references across the repository to use the workspace dependency
1 parent b8dc38f commit 8396123

File tree

168 files changed

+781
-1771
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

168 files changed

+781
-1771
lines changed

PACKAGES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ The dependencies between layers are enforced by the layer-check command._
111111

112112
| Packages | Layer Dependencies |
113113
| --- | --- |
114-
| - [@fluidframework/build-common](/common/build/build-common)</br>- [@fluidframework/eslint-config-fluid](/common/build/eslint-config-fluid)</br>- [@fluid-internal/eslint-plugin-fluid](/common/build/eslint-plugin-fluid)</br>- [@fluid-tools/benchmark](/tools/benchmark) | &nbsp;</br>&nbsp;</br>&nbsp;</br>&nbsp; |
114+
| - [@fluidframework/build-common](/common/build/build-common)</br>- [@fluidframework/eslint-config-fluid](/common/build/eslint-config-fluid) (private)</br>- [@fluid-internal/eslint-plugin-fluid](/common/build/eslint-plugin-fluid)</br>- [@fluid-tools/benchmark](/tools/benchmark) | &nbsp;</br>&nbsp;</br>&nbsp;</br>&nbsp; |
115115

116116
### AzureClient
117117

azure/packages/azure-local-service/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"@biomejs/biome": "~1.9.3",
3535
"@fluidframework/build-common": "^2.0.3",
3636
"@fluidframework/build-tools": "^0.58.3",
37-
"@fluidframework/eslint-config-fluid": "^8.1.0",
37+
"@fluidframework/eslint-config-fluid": "workspace:^",
3838
"eslint": "~8.57.1",
3939
"eslint-config-prettier": "~10.1.8",
4040
"pm2": "^5.4.2",

azure/packages/azure-service-utils/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
"@fluidframework/azure-service-utils-previous": "npm:@fluidframework/azure-service-utils@2.71.0",
9999
"@fluidframework/build-common": "^2.0.3",
100100
"@fluidframework/build-tools": "^0.58.3",
101-
"@fluidframework/eslint-config-fluid": "^8.1.0",
101+
"@fluidframework/eslint-config-fluid": "workspace:^",
102102
"@microsoft/api-extractor": "7.52.11",
103103
"@types/jsrsasign": "^10.5.12",
104104
"concurrently": "^8.2.1",

common/build/eslint-config-fluid/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ a diff to review as part of a PR -- just like we do with API reports for code ch
5959
| Script | Description |
6060
|--------|-------------|
6161
| `build` | `npm run print-config` |
62-
| `build:readme` | `markdown-magic --files "**/*.md"` |
62+
| `build:readme:disabled` | `markdown-magic --files "**/*.md"` |
63+
| `clean` | `rimraf --glob dist` |
6364
| `cleanup-printed-configs` | Clean up the printed configs. Removes the `parser` property and sorts the JSON. |
6465
| `format` | `npm run prettier:fix` |
6566
| `prettier` | `prettier --check .` |
@@ -73,6 +74,7 @@ a diff to review as part of a PR -- just like we do with API reports for code ch
7374
| `print-config:strict-biome` | `eslint --config ./strict-biome.js --print-config ./src/file.ts > ./printed-configs/strict-biome.json` |
7475
| `print-config:test` | Print the eslint config for test files (`eslint --config index.js --print-config src/test/file.ts`). |
7576
| `test` | `echo TODO: add tests in @fluidframework/eslint-config-fluid` |
77+
| `tsc` | `npm run build` |
7678

7779
<!-- prettier-ignore-end -->
7880

common/build/eslint-config-fluid/package.json

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"name": "@fluidframework/eslint-config-fluid",
3-
"version": "8.1.0",
3+
"version": "2.72.0",
4+
"private": true,
45
"description": "Shareable ESLint config for the Fluid Framework",
56
"homepage": "https://fluidframework.com",
67
"repository": {
@@ -12,8 +13,9 @@
1213
"author": "Microsoft and contributors",
1314
"main": "index.js",
1415
"scripts": {
15-
"build": "npm run print-config && npm run build:readme && npm run prettier",
16-
"build:readme": "markdown-magic --files \"**/*.md\"",
16+
"build": "npm run print-config && npm run prettier",
17+
"build:readme:disabled": "markdown-magic --files \"**/*.md\"",
18+
"clean": "rimraf --glob dist",
1719
"cleanup-printed-configs": "node ./scripts/cleanup-printed-configs.js ./printed-configs",
1820
"format": "npm run prettier:fix",
1921
"prettier": "prettier --check . --cache --ignore-path ../../../.prettierignore",
@@ -26,7 +28,8 @@
2628
"print-config:strict": "eslint --config ./strict.js --print-config ./src/file.ts > ./printed-configs/strict.json",
2729
"print-config:strict-biome": "eslint --config ./strict-biome.js --print-config ./src/file.ts > ./printed-configs/strict-biome.json",
2830
"print-config:test": "eslint --config ./index.js --print-config ./src/test/file.ts > ./printed-configs/test.json",
29-
"test": "echo TODO: add tests"
31+
"test": "echo TODO: add tests",
32+
"tsc": "npm run build"
3033
},
3134
"dependencies": {
3235
"@fluid-internal/eslint-plugin-fluid": "^0.4.0",
@@ -42,19 +45,19 @@
4245
"eslint-plugin-import-x": "~4.16.1",
4346
"eslint-plugin-jsdoc": "~55.0.2",
4447
"eslint-plugin-promise": "~7.2.1",
45-
"eslint-plugin-react": "~7.37.5",
46-
"eslint-plugin-react-hooks": "~5.2.0",
48+
"eslint-plugin-react": "~7.33.2",
49+
"eslint-plugin-react-hooks": "~4.6.0",
4750
"eslint-plugin-tsdoc": "~0.4.0",
4851
"eslint-plugin-unicorn": "~48.0.1",
4952
"eslint-plugin-unused-imports": "~4.2.0"
5053
},
5154
"devDependencies": {
52-
"@fluid-tools/markdown-magic": "file:../../../tools/markdown-magic",
5355
"@fluidframework/build-common": "^2.0.3",
54-
"concurrently": "^9.2.1",
55-
"eslint": "~8.57.0",
56+
"concurrently": "^8.2.1",
57+
"eslint": "~8.57.1",
5658
"mocha-multi-reporters": "^1.5.1",
5759
"prettier": "~3.6.2",
60+
"rimraf": "^4.4.0",
5861
"sort-json": "^2.0.1",
5962
"typescript": "~5.4.5"
6063
},

0 commit comments

Comments
 (0)