getSnapshotTree is required on IChannelStorageService (microsoft#25707)

## Description
The property `getSnapshotTree` is now required on
`IChannelStorageService`.

## Breaking Changes
This is a breaking change. This API was added and the upcoming break was
announced in release 2.51.0
[here](https://github.com/microsoft/FluidFramework/releases/tag/client_v2.51.0#user-content-new-getsnapshottree-api-on-ichannelstorageservice-24970).

Author: agarwal-navin

.changeset/heavy-mails-pay.md

@@ -0,0 +1,9 @@
+---
+"@fluidframework/datastore-definitions": minor
+"@fluidframework/test-runtime-utils": minor
+"__section": breaking
+---
+getSnapshotTree is now required in IChannelStorageService
+
+The `getSnapshotTree` property was added as optional to `IChannelStorageService` in version 2.51.0. It is now a required property.
+See this [github issue](https://github.com/microsoft/FluidFramework/issues/25178) for more details.

packages/dds/tree/src/shared-tree-core/sharedTreeCore.ts

@@ -719,7 +719,7 @@ function scopeStorageService(
 			return service.list(`${scope}${path}`);
 		},
 		getSnapshotTree(): ISnapshotTree | undefined {
-			const snapshotTree = service.getSnapshotTree?.();
+			const snapshotTree = service.getSnapshotTree();
 			if (snapshotTree === undefined) {
 				return undefined;
 			}

packages/runtime/datastore-definitions/api-report/datastore-definitions.legacy.beta.api.md

@@ -42,7 +42,7 @@ export interface IChannelServices {
 // @beta @legacy
 export interface IChannelStorageService {
     contains(path: string): Promise<boolean>;
-    getSnapshotTree?(): ISnapshotTree | undefined;
+    getSnapshotTree(): ISnapshotTree | undefined;
     list(path: string): Promise<string[]>;
     readBlob(path: string): Promise<ArrayBufferLike>;
 }

packages/runtime/datastore-definitions/package.json

@@ -101,7 +101,14 @@
 		"typescript": "~5.4.5"
 	},
 	"typeValidation": {
-		"broken": {},
+		"broken": {
+			"Interface_IChannelServices": {
+				"forwardCompat": false
+			},
+			"Interface_IChannelStorageService": {
+				"forwardCompat": false
+			}
+		},
 		"entrypoint": "legacy"
 	}
 }

packages/runtime/datastore-definitions/src/channel.ts

@@ -250,7 +250,7 @@ export interface IChannelStorageService {
 	 * Returns the snapshot tree for the channel. This will help channels examine their snapshot when it consists
 	 * of dynamic trees and blobs, i.e., the number of tree and blobs and / or their keys are not known in advance.
 	 */
-	getSnapshotTree?(): ISnapshotTree | undefined;
+	getSnapshotTree(): ISnapshotTree | undefined;
 }
 
 /**

packages/runtime/datastore-definitions/src/test/types/validateDatastoreDefinitionsPrevious.generated.ts

@@ -76,6 +76,7 @@ declare type current_as_old_for_Interface_IChannelFactory = requireAssignableTo<
  * typeValidation.broken:
  * "Interface_IChannelServices": {"forwardCompat": false}
  */
+// @ts-expect-error compatibility expected to be broken
 declare type old_as_current_for_Interface_IChannelServices = requireAssignableTo<TypeOnly<old.IChannelServices>, TypeOnly<current.IChannelServices>>
 
 /*
@@ -94,6 +95,7 @@ declare type current_as_old_for_Interface_IChannelServices = requireAssignableTo
  * typeValidation.broken:
  * "Interface_IChannelStorageService": {"forwardCompat": false}
  */
+// @ts-expect-error compatibility expected to be broken
 declare type old_as_current_for_Interface_IChannelStorageService = requireAssignableTo<TypeOnly<old.IChannelStorageService>, TypeOnly<current.IChannelStorageService>>
 
 /*

packages/runtime/runtime-utils/src/objectstoragepartition.ts

@@ -33,6 +33,6 @@ export class ObjectStoragePartition implements IChannelStorageService {
 	}
 
 	public getSnapshotTree(): ISnapshotTree | undefined {
-		return this.storage.getSnapshotTree?.();
+		return this.storage.getSnapshotTree();
 	}
 }