[CIR][NFC] Remove duplicate code (llvm#145790)

andykaylor · Anthony Tran · commit 7b832b683393 · 2025-06-26T12:46:11.000-07:00
This change removes a bit of code that was left as an artifact of a
previous "not yet implemented" state. The implementation is in place,
but the code to report an NYI diagnostic was left behind.
diff --git a/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp b/clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp
@@ -614,14 +614,6 @@ CIRGenTypes::computeRecordLayout(const RecordDecl *rd, cir::RecordType *ty) {
     }
   }
 
-  if (llvm::isa<CXXRecordDecl>(rd) && !rd->isUnion() &&
-      !rd->hasAttr<FinalAttr>()) {
-    if (lowering.astRecordLayout.getNonVirtualSize() !=
-        lowering.astRecordLayout.getSize()) {
-      cgm.errorNYI(rd->getSourceRange(), "computeRecordLayout: CXXRecordDecl");
-    }
-  }
-
   // Fill in the record *after* computing the base type.  Filling in the body
   // signifies that the type is no longer opaque and record layout is complete,
   // but we may need to recursively layout rd while laying D out as a base type.

Original file line number	Diff line number	Diff line change
`@@ -614,14 +614,6 @@ CIRGenTypes::computeRecordLayout(const RecordDecl rd, cir::RecordType ty) {`
`614`	`614`	`}`
`615`	`615`	`}`
`616`	`616`
`617`		`- if (llvm::isa<CXXRecordDecl>(rd) && !rd->isUnion() &&`
`618`		`- !rd->hasAttr<FinalAttr>()) {`
`619`		`- if (lowering.astRecordLayout.getNonVirtualSize() !=`
`620`		`- lowering.astRecordLayout.getSize()) {`
`621`		`- cgm.errorNYI(rd->getSourceRange(), "computeRecordLayout: CXXRecordDecl");`
`622`		`- }`
`623`		`- }`
`624`		`-`
`625`	`617`	`// Fill in the record after computing the base type. Filling in the body`
`626`	`618`	`// signifies that the type is no longer opaque and record layout is complete,`
`627`	`619`	`// but we may need to recursively layout rd while laying D out as a base type.`