Merge pull request #71 from jtsai-osa/main

anthonyreilly · web-flow · commit 2e8a197420a2 · 2025-02-18T09:28:08.000-05:00
Add ConfigureAwait(false) to await calls
diff --git a/src/NetCoreForce.Client/ForceClient.cs b/src/NetCoreForce.Client/ForceClient.cs
@@ -88,7 +88,7 @@ public ForceClient(string instanceUrl, string apiVersion, string accessToken, Ht
         private async Task Login(string clientId, string clientSecret, string username, string password, string tokenRequestEndpoint, string apiVersion = null, HttpClient httpClient = null)
         {
             AuthenticationClient authClient = new AuthenticationClient(apiVersion, httpClient);
-            await authClient.UsernamePasswordAsync(clientId, clientSecret, username, password, tokenRequestEndpoint);
+            await authClient.UsernamePasswordAsync(clientId, clientSecret, username, password, tokenRequestEndpoint).ConfigureAwait(false);
 
             Initialize(authClient.AccessInfo.InstanceUrl, authClient.ApiVersion, authClient.AccessInfo.AccessToken, httpClient, authClient.AccessInfo);
         }
@@ -163,7 +163,7 @@ public async Task<List<T>> Query<T>(string queryString, bool queryAll = false)
                         queryUri = new Uri(new Uri(InstanceUrl), nextRecordsUrl);
                     }
 
-                    QueryResult<T> qr = await client.HttpGetAsync<QueryResult<T>>(queryUri, headers);
+                    QueryResult<T> qr = await client.HttpGetAsync<QueryResult<T>>(queryUri, headers).ConfigureAwait(false);
 
 #if DEBUG
                     Debug.WriteLine(string.Format("Got query resuts, {0} totalSize, {1} in this batch, final batch: {2}",
@@ -209,7 +209,7 @@ public async Task<List<T>> Query<T>(string queryString, bool queryAll = false)
         /// <returns>result object</returns>
         public async Task<T> QuerySingle<T>(string queryString, bool queryAll = false)
         {
-            List<T> results = await Query<T>(queryString, queryAll);
+            List<T> results = await Query<T>(queryString, queryAll).ConfigureAwait(false);
 
             if (results != null && results.Count > 1)
             {
@@ -255,7 +255,7 @@ public async IAsyncEnumerable<T> QueryAsync<T>(string queryString, bool queryAll
 
             while (hasMoreRecords)
             {
-                var qr = await jsonClient.HttpGetAsync<QueryResult<T>>(nextRecordsUri, headers);
+                var qr = await jsonClient.HttpGetAsync<QueryResult<T>>(nextRecordsUri, headers).ConfigureAwait(false);
 
 #if DEBUG
                 Debug.WriteLine($"Got query resuts, {qr.TotalSize} totalSize, {qr.Records.Count} in this batch, final batch: {qr.Done}");
@@ -301,7 +301,7 @@ public async Task<int> CountQuery(string queryString, bool queryAll = false)
 
             var jsonClient = new JsonClient(AccessToken, SharedHttpClient);
             var uri = UriFormatter.Query(InstanceUrl, ApiVersion, queryString);
-            var qr = await jsonClient.HttpGetAsync<QueryResult<object>>(uri, headers);
+            var qr = await jsonClient.HttpGetAsync<QueryResult<object>>(uri, headers).ConfigureAwait(false);
 
             return qr.TotalSize;
         }
@@ -321,7 +321,7 @@ public async Task<SearchResult<T>> Search<T>(string searchString)
 
                 JsonClient client = new JsonClient(AccessToken, SharedHttpClient);
 
-                SearchResult<T> searchResult = await client.HttpGetAsync<SearchResult<T>>(uri, headers);
+                SearchResult<T> searchResult = await client.HttpGetAsync<SearchResult<T>>(uri, headers).ConfigureAwait(false);
 
                 return searchResult;
             }
@@ -346,7 +346,7 @@ public async Task<SearchResult<SObjectGeneric>> Search(string searchString)
 
                 JsonClient client = new JsonClient(AccessToken, SharedHttpClient);
 
-                SearchResult<SObjectGeneric> searchResult = await client.HttpGetAsync<SearchResult<SObjectGeneric>>(uri, headers);
+                SearchResult<SObjectGeneric> searchResult = await client.HttpGetAsync<SearchResult<SObjectGeneric>>(uri, headers).ConfigureAwait(false);
 
                 return searchResult;
             }
@@ -370,7 +370,7 @@ public async Task<T> GetObjectById<T>(string sObjectTypeName, string objectId, L
 
             JsonClient client = new JsonClient(AccessToken, SharedHttpClient);
 
-            return await client.HttpGetAsync<T>(uri, headers);
+            return await client.HttpGetAsync<T>(uri, headers).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -406,7 +406,7 @@ public async Task<CreateResponse> CreateRecord<T>(
 
             JsonClient client = new JsonClient(AccessToken, SharedHttpClient);
 
-            return await client.HttpPostAsync<CreateResponse>(sObject, uri, headers, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls);
+            return await client.HttpPostAsync<CreateResponse>(sObject, uri, headers, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -478,7 +478,7 @@ public async Task<SObjectTreeResponse> CreateMultiple(
 
             SObjectTreeRequest treeRequest = new SObjectTreeRequest(sObjects);
 
-            return await client.HttpPostAsync<SObjectTreeResponse>(treeRequest, uri, headers, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls);
+            return await client.HttpPostAsync<SObjectTreeResponse>(treeRequest, uri, headers, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -517,7 +517,7 @@ public async Task UpdateRecord<T>(
 
             JsonClient client = new JsonClient(AccessToken, SharedHttpClient);
 
-            await client.HttpPatchAsync<object>(sObject, uri, headers, ignoreNulls: ignoreNulls, fieldsToNull: fieldsToNull);
+            await client.HttpPatchAsync<object>(sObject, uri, headers, ignoreNulls: ignoreNulls, fieldsToNull: fieldsToNull).ConfigureAwait(false);
 
             return;
         }
@@ -575,7 +575,7 @@ public async Task<List<UpsertResponse>> UpdateRecords(
 
             UpsertRequest upsertRequest = new UpsertRequest(sObjects, allOrNone);
 
-            return await client.HttpPatchAsync<List<UpsertResponse>>(upsertRequest, uri, headers, includeSObjectId: true, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls);
+            return await client.HttpPatchAsync<List<UpsertResponse>>(upsertRequest, uri, headers, includeSObjectId: true, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls).ConfigureAwait(false);
 
         }
 
@@ -616,7 +616,7 @@ public async Task<UpsertResponse> InsertOrUpdateRecord<T>(
 
             JsonClient client = new JsonClient(AccessToken, SharedHttpClient);
 
-            return await client.HttpPatchAsync<UpsertResponse>(sObject, uri, headers, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls);
+            return await client.HttpPatchAsync<UpsertResponse>(sObject, uri, headers, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -633,7 +633,7 @@ public async Task DeleteRecord(string sObjectTypeName, string objectId)
 
             JsonClient client = new JsonClient(AccessToken, SharedHttpClient);
 
-            await client.HttpDeleteAsync<object>(uri, headers);
+            await client.HttpDeleteAsync<object>(uri, headers).ConfigureAwait(false);
 
             return;
         }
@@ -762,13 +762,13 @@ public async Task<Stream> BlobRetrieveStream(string blobUrl)
             string objectId = match.Groups[2].Value;
             string blobField = match.Groups[3].Value;
 
-            return await BlobRetrieveStream(sObjectTypeName, objectId, blobField);
+            return await BlobRetrieveStream(sObjectTypeName, objectId, blobField).ConfigureAwait(false);
         }
 
         public async Task<Stream> BlobRetrieveStream(string sObjectTypeName, string objectId, string blobField)
         {
-            HttpResponseMessage response = await BlobRetrieveResponse(sObjectTypeName, objectId, blobField);
-            return await response.Content.ReadAsStreamAsync();
+            HttpResponseMessage response = await BlobRetrieveResponse(sObjectTypeName, objectId, blobField).ConfigureAwait(false);
+            return await response.Content.ReadAsStreamAsync().ConfigureAwait(false);
         }
 
         // public async Task<byte[]> BlobRetrieveBytes(string blobUrl)
@@ -840,7 +840,7 @@ public async Task<OrganizationLimits> GetOrganizationLimits()
 
             JsonClient client = new JsonClient(AccessToken, SharedHttpClient);
 
-            return await client.HttpGetAsync<OrganizationLimits>(uri);
+            return await client.HttpGetAsync<OrganizationLimits>(uri).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -851,7 +851,7 @@ public async Task<OrganizationLimits> GetOrganizationLimits()
         /// <returns>List of SalesforceVersion objects</returns>
         public async Task<List<SalesforceVersion>> GetAvailableRestApiVersions(string currentInstanceUrl = null)
         {
-            return await GetAvailableRestApiVersions(currentInstanceUrl, true);
+            return await GetAvailableRestApiVersions(currentInstanceUrl, true).ConfigureAwait(false);
         }
 
         private async Task<List<SalesforceVersion>> GetAvailableRestApiVersions(string currentInstanceUrl = null, bool deserializeResponse = true)
@@ -875,7 +875,7 @@ private async Task<List<SalesforceVersion>> GetAvailableRestApiVersions(string c
 
             JsonClient client = new JsonClient(AccessToken, SharedHttpClient);
 
-            return await client.HttpGetAsync<List<SalesforceVersion>>(uri: uri, deserializeResponse: deserializeResponse);
+            return await client.HttpGetAsync<List<SalesforceVersion>>(uri: uri, deserializeResponse: deserializeResponse).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -888,7 +888,7 @@ public async Task<UserInfo> GetUserInfo(string identityUrl)
         {
             JsonClient client = new JsonClient(AccessToken, SharedHttpClient);
 
-            return await client.HttpGetAsync<UserInfo>(new Uri(identityUrl));
+            return await client.HttpGetAsync<UserInfo>(new Uri(identityUrl)).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -904,7 +904,7 @@ public async Task<SObjectBasicInfo> GetObjectBasicInfo(string objectTypeName)
 
             JsonClient client = new JsonClient(AccessToken, SharedHttpClient);
 
-            return await client.HttpGetAsync<SObjectBasicInfo>(uri, headers);
+            return await client.HttpGetAsync<SObjectBasicInfo>(uri, headers).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -919,7 +919,7 @@ public async Task<SObjectDescribeFull> GetObjectDescribe(string objectTypeName)
 
             JsonClient client = new JsonClient(AccessToken, SharedHttpClient);
 
-            return await client.HttpGetAsync<SObjectDescribeFull>(uri);
+            return await client.HttpGetAsync<SObjectDescribeFull>(uri).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -933,7 +933,7 @@ public async Task<DescribeGlobal> DescribeGlobal()
 
             JsonClient client = new JsonClient(AccessToken, SharedHttpClient);
 
-            return await client.HttpGetAsync<DescribeGlobal>(uri);
+            return await client.HttpGetAsync<DescribeGlobal>(uri).ConfigureAwait(false);
         }
 
         #endregion
diff --git a/src/NetCoreForce.Client/JsonClient.cs b/src/NetCoreForce.Client/JsonClient.cs
@@ -74,7 +74,7 @@ public JsonClient(string accessToken, HttpClient httpClient = null)
         public async Task<T> HttpGetAsync<T>(Uri uri, Dictionary<string, string> customHeaders = null, bool deserializeResponse = true)
         {
             //TODO: can this handle T = string?
-            return await HttpAsync<T>(uri, HttpMethod.Get, null, customHeaders, deserializeResponse);
+            return await HttpAsync<T>(uri, HttpMethod.Get, null, customHeaders, deserializeResponse).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -106,7 +106,7 @@ public async Task<T> HttpPostAsync<T>(
             request.Method = HttpMethod.Post;
             request.Content = content;
 
-            return await GetResponse<T>(request, customHeaders, deserializeResponse);
+            return await GetResponse<T>(request, customHeaders, deserializeResponse).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -148,7 +148,7 @@ public async Task<T> HttpPatchAsync<T>(
 
             var content = new StringContent(json, Encoding.UTF8, JsonMimeType);
 
-            return await HttpAsync<T>(uri, new HttpMethod("PATCH"), content, customHeaders, deserializeResponse);
+            return await HttpAsync<T>(uri, new HttpMethod("PATCH"), content, customHeaders, deserializeResponse).ConfigureAwait(false);
         }
 
         /// <summary>
@@ -166,7 +166,7 @@ public async Task<T> HttpDeleteAsync<T>(Uri uri, Dictionary<string, string> cust
             request.RequestUri = uri;
             request.Method = HttpMethod.Delete;
 
-            return await GetResponse<T>(request, customHeaders, deserializeResponse);
+            return await GetResponse<T>(request, customHeaders, deserializeResponse).ConfigureAwait(false);
         }
 
         private async Task<T> HttpAsync<T>(Uri uri, HttpMethod httpMethod, HttpContent content = null, Dictionary<string, string> customHeaders = null, bool deserializeResponse = true)
@@ -180,7 +180,7 @@ private async Task<T> HttpAsync<T>(Uri uri, HttpMethod httpMethod, HttpContent c
                 request.Content = content;
             }
 
-            return await GetResponse<T>(request, customHeaders, deserializeResponse);
+            return await GetResponse<T>(request, customHeaders, deserializeResponse).ConfigureAwait(false);
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ public ForceClient(string instanceUrl, string apiVersion, string accessToken, Ht`
`88`	`88`	`private async Task Login(string clientId, string clientSecret, string username, string password, string tokenRequestEndpoint, string apiVersion = null, HttpClient httpClient = null)`
`89`	`89`	`{`
`90`	`90`	`AuthenticationClient authClient = new AuthenticationClient(apiVersion, httpClient);`
`91`		`- await authClient.UsernamePasswordAsync(clientId, clientSecret, username, password, tokenRequestEndpoint);`
	`91`	`+ await authClient.UsernamePasswordAsync(clientId, clientSecret, username, password, tokenRequestEndpoint).ConfigureAwait(false);`
`92`	`92`
`93`	`93`	`Initialize(authClient.AccessInfo.InstanceUrl, authClient.ApiVersion, authClient.AccessInfo.AccessToken, httpClient, authClient.AccessInfo);`
`94`	`94`	`}`
`@@ -163,7 +163,7 @@ public async Task<List<T>> Query<T>(string queryString, bool queryAll = false)`
`163`	`163`	`queryUri = new Uri(new Uri(InstanceUrl), nextRecordsUrl);`
`164`	`164`	`}`
`165`	`165`
`166`		`- QueryResult<T> qr = await client.HttpGetAsync<QueryResult<T>>(queryUri, headers);`
	`166`	`+ QueryResult<T> qr = await client.HttpGetAsync<QueryResult<T>>(queryUri, headers).ConfigureAwait(false);`
`167`	`167`
`168`	`168`	`#if DEBUG`
`169`	`169`	`Debug.WriteLine(string.Format("Got query resuts, {0} totalSize, {1} in this batch, final batch: {2}",`
`@@ -209,7 +209,7 @@ public async Task<List<T>> Query<T>(string queryString, bool queryAll = false)`
`209`	`209`	`/// <returns>result object</returns>`
`210`	`210`	`public async Task<T> QuerySingle<T>(string queryString, bool queryAll = false)`
`211`	`211`	`{`
`212`		`- List<T> results = await Query<T>(queryString, queryAll);`
	`212`	`+ List<T> results = await Query<T>(queryString, queryAll).ConfigureAwait(false);`
`213`	`213`
`214`	`214`	`if (results != null && results.Count > 1)`
`215`	`215`	`{`
`@@ -255,7 +255,7 @@ public async IAsyncEnumerable<T> QueryAsync<T>(string queryString, bool queryAll`
`255`	`255`
`256`	`256`	`while (hasMoreRecords)`
`257`	`257`	`{`
`258`		`- var qr = await jsonClient.HttpGetAsync<QueryResult<T>>(nextRecordsUri, headers);`
	`258`	`+ var qr = await jsonClient.HttpGetAsync<QueryResult<T>>(nextRecordsUri, headers).ConfigureAwait(false);`
`259`	`259`
`260`	`260`	`#if DEBUG`
`261`	`261`	`Debug.WriteLine($"Got query resuts, {qr.TotalSize} totalSize, {qr.Records.Count} in this batch, final batch: {qr.Done}");`
`@@ -301,7 +301,7 @@ public async Task<int> CountQuery(string queryString, bool queryAll = false)`
`301`	`301`
`302`	`302`	`var jsonClient = new JsonClient(AccessToken, SharedHttpClient);`
`303`	`303`	`var uri = UriFormatter.Query(InstanceUrl, ApiVersion, queryString);`
`304`		`- var qr = await jsonClient.HttpGetAsync<QueryResult<object>>(uri, headers);`
	`304`	`+ var qr = await jsonClient.HttpGetAsync<QueryResult<object>>(uri, headers).ConfigureAwait(false);`
`305`	`305`
`306`	`306`	`return qr.TotalSize;`
`307`	`307`	`}`
`@@ -321,7 +321,7 @@ public async Task<SearchResult<T>> Search<T>(string searchString)`
`321`	`321`
`322`	`322`	`JsonClient client = new JsonClient(AccessToken, SharedHttpClient);`
`323`	`323`
`324`		`- SearchResult<T> searchResult = await client.HttpGetAsync<SearchResult<T>>(uri, headers);`
	`324`	`+ SearchResult<T> searchResult = await client.HttpGetAsync<SearchResult<T>>(uri, headers).ConfigureAwait(false);`
`325`	`325`
`326`	`326`	`return searchResult;`
`327`	`327`	`}`
`@@ -346,7 +346,7 @@ public async Task<SearchResult<SObjectGeneric>> Search(string searchString)`
`346`	`346`
`347`	`347`	`JsonClient client = new JsonClient(AccessToken, SharedHttpClient);`
`348`	`348`
`349`		`- SearchResult<SObjectGeneric> searchResult = await client.HttpGetAsync<SearchResult<SObjectGeneric>>(uri, headers);`
	`349`	`+ SearchResult<SObjectGeneric> searchResult = await client.HttpGetAsync<SearchResult<SObjectGeneric>>(uri, headers).ConfigureAwait(false);`
`350`	`350`
`351`	`351`	`return searchResult;`
`352`	`352`	`}`
`@@ -370,7 +370,7 @@ public async Task<T> GetObjectById<T>(string sObjectTypeName, string objectId, L`
`370`	`370`
`371`	`371`	`JsonClient client = new JsonClient(AccessToken, SharedHttpClient);`
`372`	`372`
`373`		`- return await client.HttpGetAsync<T>(uri, headers);`
	`373`	`+ return await client.HttpGetAsync<T>(uri, headers).ConfigureAwait(false);`
`374`	`374`	`}`
`375`	`375`
`376`	`376`	`/// <summary>`
`@@ -406,7 +406,7 @@ public async Task<CreateResponse> CreateRecord<T>(`
`406`	`406`
`407`	`407`	`JsonClient client = new JsonClient(AccessToken, SharedHttpClient);`
`408`	`408`
`409`		`- return await client.HttpPostAsync<CreateResponse>(sObject, uri, headers, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls);`
	`409`	`+ return await client.HttpPostAsync<CreateResponse>(sObject, uri, headers, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls).ConfigureAwait(false);`
`410`	`410`	`}`
`411`	`411`
`412`	`412`	`/// <summary>`
`@@ -478,7 +478,7 @@ public async Task<SObjectTreeResponse> CreateMultiple(`
`478`	`478`
`479`	`479`	`SObjectTreeRequest treeRequest = new SObjectTreeRequest(sObjects);`
`480`	`480`
`481`		`- return await client.HttpPostAsync<SObjectTreeResponse>(treeRequest, uri, headers, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls);`
	`481`	`+ return await client.HttpPostAsync<SObjectTreeResponse>(treeRequest, uri, headers, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls).ConfigureAwait(false);`
`482`	`482`	`}`
`483`	`483`
`484`	`484`	`/// <summary>`
`@@ -517,7 +517,7 @@ public async Task UpdateRecord<T>(`
`517`	`517`
`518`	`518`	`JsonClient client = new JsonClient(AccessToken, SharedHttpClient);`
`519`	`519`
`520`		`- await client.HttpPatchAsync<object>(sObject, uri, headers, ignoreNulls: ignoreNulls, fieldsToNull: fieldsToNull);`
	`520`	`+ await client.HttpPatchAsync<object>(sObject, uri, headers, ignoreNulls: ignoreNulls, fieldsToNull: fieldsToNull).ConfigureAwait(false);`
`521`	`521`
`522`	`522`	`return;`
`523`	`523`	`}`
`@@ -575,7 +575,7 @@ public async Task<List<UpsertResponse>> UpdateRecords(`
`575`	`575`
`576`	`576`	`UpsertRequest upsertRequest = new UpsertRequest(sObjects, allOrNone);`
`577`	`577`
`578`		`- return await client.HttpPatchAsync<List<UpsertResponse>>(upsertRequest, uri, headers, includeSObjectId: true, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls);`
	`578`	`+ return await client.HttpPatchAsync<List<UpsertResponse>>(upsertRequest, uri, headers, includeSObjectId: true, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls).ConfigureAwait(false);`
`579`	`579`
`580`	`580`	`}`
`581`	`581`
`@@ -616,7 +616,7 @@ public async Task<UpsertResponse> InsertOrUpdateRecord<T>(`
`616`	`616`
`617`	`617`	`JsonClient client = new JsonClient(AccessToken, SharedHttpClient);`
`618`	`618`
`619`		`- return await client.HttpPatchAsync<UpsertResponse>(sObject, uri, headers, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls);`
	`619`	`+ return await client.HttpPatchAsync<UpsertResponse>(sObject, uri, headers, fieldsToNull: fieldsToNull, ignoreNulls: ignoreNulls).ConfigureAwait(false);`
`620`	`620`	`}`
`621`	`621`
`622`	`622`	`/// <summary>`
`@@ -633,7 +633,7 @@ public async Task DeleteRecord(string sObjectTypeName, string objectId)`
`633`	`633`
`634`	`634`	`JsonClient client = new JsonClient(AccessToken, SharedHttpClient);`
`635`	`635`
`636`		`- await client.HttpDeleteAsync<object>(uri, headers);`
	`636`	`+ await client.HttpDeleteAsync<object>(uri, headers).ConfigureAwait(false);`
`637`	`637`
`638`	`638`	`return;`
`639`	`639`	`}`
`@@ -762,13 +762,13 @@ public async Task<Stream> BlobRetrieveStream(string blobUrl)`
`762`	`762`	`string objectId = match.Groups[2].Value;`
`763`	`763`	`string blobField = match.Groups[3].Value;`
`764`	`764`
`765`		`- return await BlobRetrieveStream(sObjectTypeName, objectId, blobField);`
	`765`	`+ return await BlobRetrieveStream(sObjectTypeName, objectId, blobField).ConfigureAwait(false);`
`766`	`766`	`}`
`767`	`767`
`768`	`768`	`public async Task<Stream> BlobRetrieveStream(string sObjectTypeName, string objectId, string blobField)`
`769`	`769`	`{`
`770`		`- HttpResponseMessage response = await BlobRetrieveResponse(sObjectTypeName, objectId, blobField);`
`771`		`- return await response.Content.ReadAsStreamAsync();`
	`770`	`+ HttpResponseMessage response = await BlobRetrieveResponse(sObjectTypeName, objectId, blobField).ConfigureAwait(false);`
	`771`	`+ return await response.Content.ReadAsStreamAsync().ConfigureAwait(false);`
`772`	`772`	`}`
`773`	`773`
`774`	`774`	`// public async Task<byte[]> BlobRetrieveBytes(string blobUrl)`
`@@ -840,7 +840,7 @@ public async Task<OrganizationLimits> GetOrganizationLimits()`
`840`	`840`
`841`	`841`	`JsonClient client = new JsonClient(AccessToken, SharedHttpClient);`
`842`	`842`
`843`		`- return await client.HttpGetAsync<OrganizationLimits>(uri);`
	`843`	`+ return await client.HttpGetAsync<OrganizationLimits>(uri).ConfigureAwait(false);`
`844`	`844`	`}`
`845`	`845`
`846`	`846`	`/// <summary>`
`@@ -851,7 +851,7 @@ public async Task<OrganizationLimits> GetOrganizationLimits()`
`851`	`851`	`/// <returns>List of SalesforceVersion objects</returns>`
`852`	`852`	`public async Task<List<SalesforceVersion>> GetAvailableRestApiVersions(string currentInstanceUrl = null)`
`853`	`853`	`{`
`854`		`- return await GetAvailableRestApiVersions(currentInstanceUrl, true);`
	`854`	`+ return await GetAvailableRestApiVersions(currentInstanceUrl, true).ConfigureAwait(false);`
`855`	`855`	`}`
`856`	`856`
`857`	`857`	`private async Task<List<SalesforceVersion>> GetAvailableRestApiVersions(string currentInstanceUrl = null, bool deserializeResponse = true)`
`@@ -875,7 +875,7 @@ private async Task<List<SalesforceVersion>> GetAvailableRestApiVersions(string c`
`875`	`875`
`876`	`876`	`JsonClient client = new JsonClient(AccessToken, SharedHttpClient);`
`877`	`877`
`878`		`- return await client.HttpGetAsync<List<SalesforceVersion>>(uri: uri, deserializeResponse: deserializeResponse);`
	`878`	`+ return await client.HttpGetAsync<List<SalesforceVersion>>(uri: uri, deserializeResponse: deserializeResponse).ConfigureAwait(false);`
`879`	`879`	`}`
`880`	`880`
`881`	`881`	`/// <summary>`
`@@ -888,7 +888,7 @@ public async Task<UserInfo> GetUserInfo(string identityUrl)`
`888`	`888`	`{`
`889`	`889`	`JsonClient client = new JsonClient(AccessToken, SharedHttpClient);`
`890`	`890`
`891`		`- return await client.HttpGetAsync<UserInfo>(new Uri(identityUrl));`
	`891`	`+ return await client.HttpGetAsync<UserInfo>(new Uri(identityUrl)).ConfigureAwait(false);`
`892`	`892`	`}`
`893`	`893`
`894`	`894`	`/// <summary>`
`@@ -904,7 +904,7 @@ public async Task<SObjectBasicInfo> GetObjectBasicInfo(string objectTypeName)`
`904`	`904`
`905`	`905`	`JsonClient client = new JsonClient(AccessToken, SharedHttpClient);`
`906`	`906`
`907`		`- return await client.HttpGetAsync<SObjectBasicInfo>(uri, headers);`
	`907`	`+ return await client.HttpGetAsync<SObjectBasicInfo>(uri, headers).ConfigureAwait(false);`
`908`	`908`	`}`
`909`	`909`
`910`	`910`	`/// <summary>`
`@@ -919,7 +919,7 @@ public async Task<SObjectDescribeFull> GetObjectDescribe(string objectTypeName)`
`919`	`919`
`920`	`920`	`JsonClient client = new JsonClient(AccessToken, SharedHttpClient);`
`921`	`921`
`922`		`- return await client.HttpGetAsync<SObjectDescribeFull>(uri);`
	`922`	`+ return await client.HttpGetAsync<SObjectDescribeFull>(uri).ConfigureAwait(false);`
`923`	`923`	`}`
`924`	`924`
`925`	`925`	`/// <summary>`
`@@ -933,7 +933,7 @@ public async Task<DescribeGlobal> DescribeGlobal()`
`933`	`933`
`934`	`934`	`JsonClient client = new JsonClient(AccessToken, SharedHttpClient);`
`935`	`935`
`936`		`- return await client.HttpGetAsync<DescribeGlobal>(uri);`
	`936`	`+ return await client.HttpGetAsync<DescribeGlobal>(uri).ConfigureAwait(false);`
`937`	`937`	`}`
`938`	`938`
`939`	`939`	`#endregion`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ public JsonClient(string accessToken, HttpClient httpClient = null)`
`74`	`74`	`public async Task<T> HttpGetAsync<T>(Uri uri, Dictionary<string, string> customHeaders = null, bool deserializeResponse = true)`
`75`	`75`	`{`
`76`	`76`	`//TODO: can this handle T = string?`
`77`		`- return await HttpAsync<T>(uri, HttpMethod.Get, null, customHeaders, deserializeResponse);`
	`77`	`+ return await HttpAsync<T>(uri, HttpMethod.Get, null, customHeaders, deserializeResponse).ConfigureAwait(false);`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`/// <summary>`
`@@ -106,7 +106,7 @@ public async Task<T> HttpPostAsync<T>(`
`106`	`106`	`request.Method = HttpMethod.Post;`
`107`	`107`	`request.Content = content;`
`108`	`108`
`109`		`- return await GetResponse<T>(request, customHeaders, deserializeResponse);`
	`109`	`+ return await GetResponse<T>(request, customHeaders, deserializeResponse).ConfigureAwait(false);`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`/// <summary>`
`@@ -148,7 +148,7 @@ public async Task<T> HttpPatchAsync<T>(`
`148`	`148`
`149`	`149`	`var content = new StringContent(json, Encoding.UTF8, JsonMimeType);`
`150`	`150`
`151`		`- return await HttpAsync<T>(uri, new HttpMethod("PATCH"), content, customHeaders, deserializeResponse);`
	`151`	`+ return await HttpAsync<T>(uri, new HttpMethod("PATCH"), content, customHeaders, deserializeResponse).ConfigureAwait(false);`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`/// <summary>`
`@@ -166,7 +166,7 @@ public async Task<T> HttpDeleteAsync<T>(Uri uri, Dictionary<string, string> cust`
`166`	`166`	`request.RequestUri = uri;`
`167`	`167`	`request.Method = HttpMethod.Delete;`
`168`	`168`
`169`		`- return await GetResponse<T>(request, customHeaders, deserializeResponse);`
	`169`	`+ return await GetResponse<T>(request, customHeaders, deserializeResponse).ConfigureAwait(false);`
`170`	`170`	`}`
`171`	`171`
`172`	`172`	`private async Task<T> HttpAsync<T>(Uri uri, HttpMethod httpMethod, HttpContent content = null, Dictionary<string, string> customHeaders = null, bool deserializeResponse = true)`
`@@ -180,7 +180,7 @@ private async Task<T> HttpAsync<T>(Uri uri, HttpMethod httpMethod, HttpContent c`
`180`	`180`	`request.Content = content;`
`181`	`181`	`}`
`182`	`182`
`183`		`- return await GetResponse<T>(request, customHeaders, deserializeResponse);`
	`183`	`+ return await GetResponse<T>(request, customHeaders, deserializeResponse).ConfigureAwait(false);`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`/// <summary>`