Fix/remove unneeded tool in review mode#439
Closed
uc4w6c wants to merge 2 commits intoanthropics:mainfrom
Closed
Conversation
Updated to include only if is set.
Add test cases for github_inline_comment server installation in experimental-review mode: - Include server when mode is experimental-review and isPR is true - Exclude server when mode is not experimental-review - Exclude server when isPR is false but mode is experimental-review 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
uc4w6c
commented
Aug 11, 2025
| process.env.DEFAULT_WORKFLOW_TOKEN = oldTokenEnv; | ||
| }); | ||
|
|
||
| test("should include github_inline_comment server when mode is experimental-review and isPR is true", async () => { |
Contributor
Author
There was a problem hiding this comment.
Added tests for the github_inline_comment server, which were previously missing.
|
Would it properly attach comments to the parent review with this? |
Contributor
Author
|
@amal |
Contributor
Author
|
Version 1.0.0 has been released and the review mode has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In review mode, the expected way to post comments is via
Bash(gh issue comment:*)ormcp__github_inline_comment__create_inline_comment.However,
mcp__github_comment__update_claude_commentis included in the available tools even when no Claude comment existed.https://github.com/anthropics/claude-code-action/blob/main/src/mcp/install-mcp-server.ts#L75
Updated
prepareMcpConfigto include this tool only ifclaudeCommentIdis set.When
claudeCommentIdis not set, it causes an error on the MCP side, so this change has no impact.https://github.com/anthropics/claude-code-action/blob/main/src/mcp/github-comment-server.ts#L41