Skip to content

Commit 6aad334

Browse files
committed
update tests for memview/bytearry support.
1 parent 95963e9 commit 6aad334

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

test/test_type.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -285,14 +285,14 @@ def test_bytearray_loads(self):
285285
arr.extend(b"[]")
286286
assert orjson.loads(arr) == []
287287

288-
@pytest.mark.skipif(SUPPORTS_MEMORYVIEW is True, reason="memoryview")
288+
@pytest.mark.skipif(SUPPORTS_MEMORYVIEW is False, reason="memoryview")
289289
def test_memoryview_loads_supported(self):
290290
"""
291291
memoryview loads supported
292292
"""
293293
assert orjson.loads(memoryview(b"[]")) == []
294294

295-
@pytest.mark.skipif(SUPPORTS_MEMORYVIEW is False, reason="memoryview")
295+
@pytest.mark.skipif(SUPPORTS_MEMORYVIEW is True, reason="memoryview")
296296
def test_memoryview_loads_unsupported(self):
297297
"""
298298
memoryview loads unsupported
@@ -623,9 +623,17 @@ def test_nan_loads_in_object(self):
623623

624624
def test_nan_loads_bytes(self):
625625
"""NaN/Infinity from bytes, bytearray, memoryview"""
626-
for val in [b"[NaN]", bytearray(b"[NaN]"), memoryview(b"[NaN]")]:
626+
nan_inputs: list = [b"[NaN]"]
627+
inf_inputs: list = [b"[Infinity]"]
628+
if SUPPORTS_BYTEARRAY:
629+
nan_inputs.append(bytearray(b"[NaN]"))
630+
inf_inputs.append(bytearray(b"[Infinity]"))
631+
if SUPPORTS_MEMORYVIEW:
632+
nan_inputs.append(memoryview(b"[NaN]"))
633+
inf_inputs.append(memoryview(b"[Infinity]"))
634+
for val in nan_inputs:
627635
assert math.isnan(orjson.loads(val)[0])
628-
for val in [b"[Infinity]", bytearray(b"[Infinity]"), memoryview(b"[Infinity]")]:
636+
for val in inf_inputs:
629637
assert orjson.loads(val)[0] == float("inf")
630638

631639
def test_object(self):

test/util.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010

1111
IS_FREETHREADING = sysconfig.get_config_var("Py_GIL_DISABLED")
1212

13-
SUPPORTS_MEMORYVIEW = sys.implementation == "cpython" and not IS_FREETHREADING
13+
SUPPORTS_MEMORYVIEW = sys.implementation.name == "cpython" and not IS_FREETHREADING
1414

1515
SUPPORTS_BYTEARRAY = not IS_FREETHREADING
1616

17-
SUPPORTS_GETREFCOUNT = sys.implementation == "cpython"
17+
SUPPORTS_GETREFCOUNT = sys.implementation.name == "cpython"
1818

1919
numpy = None # type: ignore
2020
if not IS_FREETHREADING:

0 commit comments

Comments
 (0)