Skip to content

Commit 95aac09

Browse files
committed
Works around #19
Do not reinsert topic objects into the forge db until we fully debug the generic handler mismatch for said objects. This doesn't impact general use I don't think.
1 parent eb14b84 commit 95aac09

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

gh-notify.el

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -964,7 +964,9 @@ The alist contains (repo-id . notifications) pairs."
964964
(when-let (topic-obj (gh-notify-notification-topic-obj notification))
965965
(when (oref topic-obj status)
966966
(oset topic-obj status value)
967-
(gh-notify--insert-forge-obj topic-obj)
967+
;; XXX: only oset the object now instead of replacing it in db
968+
;; XXX: https://github.com/anticomputer/gh-notify/issues/19
969+
;;(gh-notify--insert-forge-obj topic-obj)
968970
(when gh-notify-redraw-on-visit
969971
(gh-notify-retrieve-notifications)))))
970972
;;;
@@ -1365,7 +1367,7 @@ Browse issue or PR on prefix P."
13651367
;; it can result in a lagging point, so take care of all the state rendering
13661368
;; first, and THEN trigger the buffer switch
13671369

1368-
(let ((default-directory gh-notify-smokescreen-path))
1370+
(cl-letf ((default-directory gh-notify-smokescreen-path))
13691371

13701372
;; XXX: this is a really ugly hack until I figure out how to cleanly make
13711373
;; XXX: magit ignore errors when we don't have a local copy of the repo

0 commit comments

Comments
 (0)