throw exception with invalid configuration

Author: kpicaza

src/Container/EventDispatcherFactory.php

@@ -8,25 +8,34 @@
 use Antidot\Event\ListenerProvider;
 use Psr\Container\ContainerInterface;
 use Psr\EventDispatcher\EventDispatcherInterface;
+use RuntimeException;
+use Throwable;
 
 class EventDispatcherFactory
 {
     public function __invoke(ContainerInterface $container): EventDispatcherInterface
     {
-        $config = $container->get('config')['app-events'];
-        $listenerProvider = new ListenerProvider();
-
-        foreach ($config['event-listeners'] ?? [] as $eventClass => $listeners) {
-            foreach ($listeners ?? [] as $listenerId) {
-                $listenerProvider->addListener(
-                    $eventClass,
-                    static function () use ($container, $listenerId): callable {
-                        return $container->get($listenerId);
-                    }
-                );
+        try {
+            $config = $container->get('config')['app-events'];
+            $listenerProvider = new ListenerProvider();
+            foreach ($config['event-listeners'] ?? [] as $eventClass => $listeners) {
+                foreach ($listeners ?? [] as $listenerId) {
+                    $listenerProvider->addListener(
+                        $eventClass,
+                        static function () use ($container, $listenerId): callable {
+                            return $container->get($listenerId);
+                        }
+                    );
+                }
             }
-        }
 
-        return new EventDispatcher($listenerProvider);
+            return new EventDispatcher($listenerProvider);
+        } catch (Throwable $exception) {
+            throw new RuntimeException(sprintf(
+                'Something went wrong constructing an instance of %s, review config related to \'app-events\''
+                . ' and see the previous exception for more info.',
+                EventDispatcher::class
+            ), 0, $exception);
+        }
     }
 }

test/Container/EventDispatcherFactoryTest.php

@@ -53,6 +53,14 @@ public function testItShouldCreateNewInstancesOfEventDispatcherAlsoWithMoreIncom
         $this->thenItReturnsInstanceOfEventDispatcher();
     }
 
+    public function testItShouldThrowAnExceptionWhenAnInvalidConfigGiven(): void
+    {
+        $this->expectAnException();
+        $this->givenInvalidConfiguration();
+        $this->havingAContainerWithConfig();
+        $this->whenEventDispatcherFactoryIsInvoked();
+    }
+
     private function givenAConfigProvider(): void
     {
         $config = new ConfigProvider();
@@ -68,6 +76,20 @@ private function givenAConfigProvider(): void
         ]);
     }
 
+    private function givenInvalidConfiguration(): void
+    {
+        $this->config = [
+            'other-configs' => [
+                'event-listeners' => [
+                    TestEvent::class => [
+                        'Listener1',
+                        'Listener2',
+                    ]
+                ]
+            ]
+        ];
+    }
+
     private function givenAnIncompleteConfigProvider(): void
     {
         $config = new ConfigProvider();
@@ -131,4 +153,9 @@ private function andThenDispatcherShouldDispatchAnEvent(): void
 
         $this->dispatcher->dispatch($event);
     }
+
+    private function expectAnException(): void
+    {
+        $this->expectException(\RuntimeException::class);
+    }
 }