Tweaks to monthly dividend report CSV (#473)

Changes to #431

Sample CSV:
![Screenshot 2025-07-09 at 1 25
10 PM](https://github.com/user-attachments/assets/cbf52088-4111-4846-a2aa-97e868ae151f)

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: sharang-d

backend/app/services/dividend_report_csv.rb

@@ -1,11 +1,8 @@
 # frozen_string_literal: true
 
-require "csv"
-
 class DividendReportCsv
-  HEADERS = ["Date initiated", "Date paid", "Dividend round ID", "Client name", "Total dividends",
-             "Flexile fees", "Transfer fees", "Total ACH pull", "Number of investors",
-             "Dividend round status", "Payment processor", "Transfer reference"]
+  HEADERS = ["Date initiated", "Date paid", "Client name", "Total dividends ($)", "Flexile fees ($)",
+             "Transfer fees ($)", "Total ACH pull ($)", "Number of investors", "Dividend round status"]
 
   def initialize(dividend_rounds)
     @dividend_rounds = dividend_rounds
@@ -23,48 +20,31 @@ def generate
 
   private
     def dividend_round_data
-      @dividend_rounds.each_with_object([]) do |round, rows|
-        successful_dividends = round.dividends.joins(:dividend_payments)
-                                   .merge(DividendPayment.successful)
-                                   .includes(:dividend_payments, company_investor: :user)
-
-        next if successful_dividends.empty?
-
-        total_dividends = successful_dividends.sum(:total_amount_in_cents) / 100.0
-        total_transfer_fees = successful_dividends.joins(:dividend_payments)
-                                                 .sum("dividend_payments.transfer_fee_in_cents") / 100.0
-
-        flexile_fees = successful_dividends.map do |dividend|
+      @dividend_rounds.each_with_object([]) do |dividend_round, rows|
+        dividends = dividend_round.dividends
+        total_dividends = dividends.sum(:total_amount_in_cents) / 100.0
+        total_transfer_fees = dividends.joins(:dividend_payments)
+                                       .where(dividend_payments: { status: Payments::Status::SUCCEEDED })
+                                       .sum("dividend_payments.transfer_fee_in_cents") / 100.0
+
+        flexile_fees = dividends.map do |dividend|
           calculated_fee = ((dividend.total_amount_in_cents.to_d * 2.9.to_d / 100.to_d) + 30.to_d).round.to_i
           [30_00, calculated_fee].min
         end.sum / 100.0
 
-        total_ach_pull = total_dividends + flexile_fees + total_transfer_fees
+        total_ach_pull = total_dividends + flexile_fees
 
-        payment = successful_dividends.first.dividend_payments.successful.first
         rows << [
-          round.issued_at.to_fs(:us_date),
-          successful_dividends.first.paid_at&.to_fs(:us_date),
-          round.id,
-          round.company.name,
+          dividend_round.issued_at.to_fs(:us_date),
+          dividends.paid.first&.paid_at&.to_fs(:us_date),
+          dividend_round.company.name,
           total_dividends,
           flexile_fees,
           total_transfer_fees,
           total_ach_pull,
-          successful_dividends.count,
-          round.status,
-          payment&.processor_name,
-          payment&.transfer_id
+          dividends.count,
+          dividend_round.status,
         ]
       end
     end
 end
-
-### Usage:
-=begin
-dividend_rounds = DividendRound.includes(:dividends, :company, dividends: [:dividend_payments, company_investor: :user])
-                               .where("issued_at >= ? AND issued_at <= ?", Time.current.last_month.beginning_of_month, Time.current.last_month.end_of_month)
-                               .order(issued_at: :asc)
-attached = { "DividendReport.csv" => DividendReportCsv.new(dividend_rounds).generate }
-AdminMailer.custom(to: ["solson@earlygrowth.com"], subject: "Flexile Dividend Report CSV", body: "Attached", attached:).deliver_now
-=end

backend/app/sidekiq/dividend_report_csv_email_job.rb

@@ -9,7 +9,6 @@ def perform(recipients)
 
     dividend_rounds = DividendRound.includes(:dividends, :company, dividends: [:dividend_payments, company_investor: :user])
                                    .joins(:dividends)
-                                   .merge(Dividend.paid)
                                    .where("dividend_rounds.issued_at >= ? AND dividend_rounds.issued_at <= ?",
                                           Time.current.last_month.beginning_of_month,
                                           Time.current.last_month.end_of_month)