Fix for #3837 -- spawn Github Action jobs only for the targets that need to be tested (#3839)

* Test.

* Try again.

* Try again.

* Forgot close parenthesis.

* Add script to determine target test set.

* Inline (for now).

* Checkout, then run.

* Add the damn parameters!

* Install Dotnet and Trash.

* Make call to local dotnet tool.

* Set runs-on for jobs explicitly.

* Fix script to output just the targets to test, and leave the rest for the main.yml file.

* Fix Ubuntu build.

* Remove empty .errors file so "mvn test" still works.

* Try clif with empty targets.

* Fix target testing set

For some grammars, there are no targets that work. Add a default so Github Actions doesn't fail.

Author: kaby76

.github/workflows/main.yml

@@ -6,13 +6,44 @@ on:
   pull_request:
     branches: [ master ]
 jobs:
+  setup:
+    runs-on: ubuntu-latest
+    outputs:
+      mymatrix: ${{ steps.step1.outputs.myoutput }}
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v4
+      with:
+        fetch-depth: 0
+    - name: Install Dotnet
+      uses: actions/[email protected]
+      with:
+        dotnet-version: '7.0.x'
+    - name: Install Trash
+      shell: bash
+      run: |
+        dotnet tool restore
+    - name: Gather targets.
+      id: step1
+      shell: bash
+      run: |
+        if [ "${{github.event_name}}" == "pull_request" ]; then
+          Before="${{github.event.pull_request.base.sha}}"
+          After="${{github.event.pull_request.head.sha}}"
+        else
+          Before="${{github.event.before}}"
+          After="${{github.event.after}}"
+        fi
+        bash _scripts/what-to-test.sh $Before $After >> $GITHUB_OUTPUT
+
   build-pwsh:
+    needs: setup
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
         os: [macos-latest, windows-latest, ubuntu-latest]
-        language: [ CSharp, Dart, Java, JavaScript, Go, Python3, TypeScript ]
+        language: ${{ fromJson(needs.setup.outputs.mymatrix) }}
     steps:
     - name: Info
       shell: bash
@@ -113,12 +144,13 @@ jobs:
         _scripts/test.ps1 -target ${{ matrix.language }} -pc "$Before" -cc "$After"
 
   build-bash:
+    needs: setup
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
         os: [macos-latest, ubuntu-latest]
-        language: [ Cpp, CSharp, Dart, Java, JavaScript, Go, PHP, Python3, TypeScript ]
+        language: ${{ fromJson(needs.setup.outputs.mymatrix) }}
     steps:
     - name: Info
       shell: bash

_scripts/templates/Cpp/st.build.ps1

@@ -22,7 +22,7 @@ if($compile_exit_code -ne 0){
     exit $compile_exit_code
 }
 
-$(& <if(os_win)>cmake --build . --config Release<else>$(MAKE)<endif> ; $compile_exit_code = $LASTEXITCODE ) | Write-Host
+$(& <if(os_win)>cmake --build . --config Release<else>make<endif> ; $compile_exit_code = $LASTEXITCODE ) | Write-Host
 if($compile_exit_code -ne 0){
     Write-Host "Failed second cmake call $compile_exit_code."
     exit $compile_exit_code

_scripts/what-to-test.sh

@@ -0,0 +1,65 @@
+#
+#set -x
+declare -A targets
+for t in "Cpp" "CSharp" "Dart" "Go" "Java" "JavaScript" "PHP" "Python3" "TypeScript"
+do
+    targets[$t]=0
+done
+directories=( `git diff --name-only $1 $2 . 2> /dev/null | sed 's#\(.*\)[/][^/]*$#\1#' | sort -u | grep -v _scripts | fgrep -v .github | tr -d '\r'` )
+prefix=`pwd`
+for g in ${directories[@]}
+do
+    if [ ! -d "$g" ]
+    then
+        continue
+    fi
+    pushd $g > /dev/null 2> /dev/null
+    while true
+    do
+        if [ -f `pwd`/desc.xml ]
+        then
+            break
+        elif [ `pwd` == "$prefix" ]
+        then
+            break
+        fi
+        cd ..
+    done
+    g=`pwd`
+    g=${g##*$prefix}
+    g=${g##/}
+    if [ "$g" == "" ]
+    then
+        g="."
+    fi
+    if [ -f desc.xml ]
+    then
+        gtargets=`dotnet trxml2 -- desc.xml | fgrep -e '/desc/targets' | awk -F = '{print $2}' | sed 's/;/ /g'`
+        for t in $gtargets
+        do
+            targets[$t]=`expr ${targets[$t]} + 1`
+        done
+    fi
+    popd > /dev/null
+done
+
+ttargets=""
+for t in "Cpp" "CSharp" "Dart" "Go" "Java" "JavaScript" "PHP" "Python3" "TypeScript"
+do
+    if [ ${targets[$t]} -ne 0 ]
+    then
+        if [ "$ttargets" == "" ]
+        then
+            ttargets="\"$t\""
+        else
+            ttargets="$ttargets, \"$t\""
+        fi
+    fi
+done
+if [ "$ttargets" == "" ]
+then
+    # Github Actions doesn't like a job matrix to contain an empty set.
+    # Add Java as a default.
+    ttargets="\"Java\""
+fi
+echo 'myoutput=[' $ttargets ']'

clif/desc.xml

@@ -2,3 +2,4 @@
 <desc xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../_scripts/desc.xsd">
    <targets></targets>
 </desc>
+