Skip to content

Commit 10b4e88

Browse files
robertszczepanskikgugala
authored andcommitted
i3c_config: 'NumPrivIds' can be set with filtering enabled
Raise an error under other circumstances. Signed-off-by: Wiktoria Kuna <[email protected]>
1 parent 9c6ea8c commit 10b4e88

File tree

3 files changed

+27
-20
lines changed

3 files changed

+27
-20
lines changed

i3c_core_configs.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ axi:
4747
FrontendBusUserWidth: 32
4848
FrontendBusIdWidth: 8
4949
FrontendBusIdFiltering: False
50-
NumPrivIds: 4
5150
DisableInputFF: True
5251

5352
axi_ff:
@@ -65,5 +64,4 @@ axi_ff:
6564
FrontendBusUserWidth: 32
6665
FrontendBusIdWidth: 8
6766
FrontendBusIdFiltering: False
68-
NumPrivIds: 4
6967
DisableInputFF: False

src/i3c_defines.svh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
`define AXI_DATA_WIDTH 32
1818
`define AXI_USER_WIDTH 32
1919
`define AXI_ID_WIDTH 8
20-
`define NUM_PRIV_IDS 4
2120
`define DISABLE_INPUT_FF 1
2221

2322
`endif // I3C_CONFIG

tools/i3c_config/i3c_core_config.schema.json

Lines changed: 27 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -113,25 +113,35 @@
113113
}
114114
},
115115
"then": {
116-
"properties": {
117-
"FrontendBusUserWidth": {
118-
"type": "integer"
119-
},
120-
"FrontendBusIdWidth": {
121-
"type": "integer"
122-
},
123-
"NumPrivIds": {
124-
"type": "integer"
116+
"allOf": [
117+
{
118+
"required": [
119+
"FrontendBusUserWidth",
120+
"FrontendBusIdWidth",
121+
"FrontendBusIdFiltering"
122+
]
125123
},
126-
"FrontendBusIdFiltering": {
127-
"type": "boolean"
124+
{
125+
"if": {
126+
"properties": {
127+
"FrontendBusIdFiltering": {
128+
"const": true
129+
}
130+
}
131+
},
132+
"then": {
133+
"required": [
134+
"NumPrivIds"
135+
]
136+
},
137+
"else": {
138+
"not": {
139+
"required": [
140+
"NumPrivIds"
141+
]
142+
}
143+
}
128144
}
129-
},
130-
"required": [
131-
"FrontendBusUserWidth",
132-
"FrontendBusIdWidth",
133-
"NumPrivIds",
134-
"FrontendBusIdFiltering"
135145
]
136146
},
137147
"else": {

0 commit comments

Comments
 (0)