Skip to content

Commit 77e96f9

Browse files
robertszczepanskikgugala
robertszczepanski
authored and
kgugala
committed
Improve descriptions of Secure Firmware Recovery CSRs
1 parent 5ca60ff commit 77e96f9

14 files changed

+3175
-1132
lines changed

‎src/csr/I3CCSR.sv‎

Lines changed: 998 additions & 360 deletions
Large diffs are not rendered by default.

‎src/csr/I3CCSR_covergroups.svh‎

Lines changed: 89 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -934,10 +934,10 @@
934934

935935
endgroup
936936
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__PROT_CAP_0_fld_cg with function sample(
937-
input bit [32-1:0] PLACEHOLDER
937+
input bit [32-1:0] REC_MAGIC_STRING_0
938938
);
939939
option.per_instance = 1;
940-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
940+
REC_MAGIC_STRING_0_cp : coverpoint REC_MAGIC_STRING_0;
941941

942942
endgroup
943943

@@ -954,10 +954,10 @@
954954

955955
endgroup
956956
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__PROT_CAP_1_fld_cg with function sample(
957-
input bit [32-1:0] PLACEHOLDER
957+
input bit [32-1:0] REC_MAGIC_STRING_1
958958
);
959959
option.per_instance = 1;
960-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
960+
REC_MAGIC_STRING_1_cp : coverpoint REC_MAGIC_STRING_1;
961961

962962
endgroup
963963

@@ -974,10 +974,12 @@
974974

975975
endgroup
976976
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__PROT_CAP_2_fld_cg with function sample(
977-
input bit [32-1:0] PLACEHOLDER
977+
input bit [16-1:0] REC_PROT_VERSION,
978+
input bit [16-1:0] AGENT_CAPS
978979
);
979980
option.per_instance = 1;
980-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
981+
REC_PROT_VERSION_cp : coverpoint REC_PROT_VERSION;
982+
AGENT_CAPS_cp : coverpoint AGENT_CAPS;
981983

982984
endgroup
983985

@@ -994,10 +996,14 @@
994996

995997
endgroup
996998
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__PROT_CAP_3_fld_cg with function sample(
997-
input bit [32-1:0] PLACEHOLDER
999+
input bit [8-1:0] NUM_OF_CMS_REGIONS,
1000+
input bit [8-1:0] MAX_RESP_TIME,
1001+
input bit [8-1:0] HEARTBEAT_PERIOD
9981002
);
9991003
option.per_instance = 1;
1000-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1004+
NUM_OF_CMS_REGIONS_cp : coverpoint NUM_OF_CMS_REGIONS;
1005+
MAX_RESP_TIME_cp : coverpoint MAX_RESP_TIME;
1006+
HEARTBEAT_PERIOD_cp : coverpoint HEARTBEAT_PERIOD;
10011007

10021008
endgroup
10031009

@@ -1014,10 +1020,12 @@
10141020

10151021
endgroup
10161022
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__DEVICE_ID_0_fld_cg with function sample(
1017-
input bit [32-1:0] PLACEHOLDER
1023+
input bit [8-1:0] DESC_TYPE,
1024+
input bit [8-1:0] VENDOR_SPECIFIC_STR_LENGTH
10181025
);
10191026
option.per_instance = 1;
1020-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1027+
DESC_TYPE_cp : coverpoint DESC_TYPE;
1028+
VENDOR_SPECIFIC_STR_LENGTH_cp : coverpoint VENDOR_SPECIFIC_STR_LENGTH;
10211029

10221030
endgroup
10231031

@@ -1034,10 +1042,10 @@
10341042

10351043
endgroup
10361044
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__DEVICE_ID_1_fld_cg with function sample(
1037-
input bit [32-1:0] PLACEHOLDER
1045+
input bit [32-1:0] DATA
10381046
);
10391047
option.per_instance = 1;
1040-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1048+
DATA_cp : coverpoint DATA;
10411049

10421050
endgroup
10431051

@@ -1054,10 +1062,10 @@
10541062

10551063
endgroup
10561064
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__DEVICE_ID_2_fld_cg with function sample(
1057-
input bit [32-1:0] PLACEHOLDER
1065+
input bit [32-1:0] DATA
10581066
);
10591067
option.per_instance = 1;
1060-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1068+
DATA_cp : coverpoint DATA;
10611069

10621070
endgroup
10631071

@@ -1074,10 +1082,10 @@
10741082

10751083
endgroup
10761084
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__DEVICE_ID_3_fld_cg with function sample(
1077-
input bit [32-1:0] PLACEHOLDER
1085+
input bit [32-1:0] DATA
10781086
);
10791087
option.per_instance = 1;
1080-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1088+
DATA_cp : coverpoint DATA;
10811089

10821090
endgroup
10831091

@@ -1094,10 +1102,10 @@
10941102

10951103
endgroup
10961104
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__DEVICE_ID_4_fld_cg with function sample(
1097-
input bit [32-1:0] PLACEHOLDER
1105+
input bit [32-1:0] DATA
10981106
);
10991107
option.per_instance = 1;
1100-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1108+
DATA_cp : coverpoint DATA;
11011109

11021110
endgroup
11031111

@@ -1114,10 +1122,10 @@
11141122

11151123
endgroup
11161124
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__DEVICE_ID_5_fld_cg with function sample(
1117-
input bit [32-1:0] PLACEHOLDER
1125+
input bit [32-1:0] DATA
11181126
);
11191127
option.per_instance = 1;
1120-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1128+
DATA_cp : coverpoint DATA;
11211129

11221130
endgroup
11231131

@@ -1134,10 +1142,10 @@
11341142

11351143
endgroup
11361144
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__DEVICE_ID_6_fld_cg with function sample(
1137-
input bit [32-1:0] PLACEHOLDER
1145+
input bit [32-1:0] DATA
11381146
);
11391147
option.per_instance = 1;
1140-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1148+
DATA_cp : coverpoint DATA;
11411149

11421150
endgroup
11431151

@@ -1154,10 +1162,14 @@
11541162

11551163
endgroup
11561164
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__DEVICE_STATUS_0_fld_cg with function sample(
1157-
input bit [32-1:0] PLACEHOLDER
1165+
input bit [8-1:0] DEV_STATUS,
1166+
input bit [8-1:0] PROT_ERROR,
1167+
input bit [16-1:0] REC_REASON_CODE
11581168
);
11591169
option.per_instance = 1;
1160-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1170+
DEV_STATUS_cp : coverpoint DEV_STATUS;
1171+
PROT_ERROR_cp : coverpoint PROT_ERROR;
1172+
REC_REASON_CODE_cp : coverpoint REC_REASON_CODE;
11611173

11621174
endgroup
11631175

@@ -1174,10 +1186,14 @@
11741186

11751187
endgroup
11761188
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__DEVICE_STATUS_1_fld_cg with function sample(
1177-
input bit [32-1:0] PLACEHOLDER
1189+
input bit [16-1:0] HEARTBEAT,
1190+
input bit [9-1:0] VENDOR_STATUS_LENGTH,
1191+
input bit [7-1:0] VENDOR_STATUS
11781192
);
11791193
option.per_instance = 1;
1180-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1194+
HEARTBEAT_cp : coverpoint HEARTBEAT;
1195+
VENDOR_STATUS_LENGTH_cp : coverpoint VENDOR_STATUS_LENGTH;
1196+
VENDOR_STATUS_cp : coverpoint VENDOR_STATUS;
11811197

11821198
endgroup
11831199

@@ -1194,10 +1210,14 @@
11941210

11951211
endgroup
11961212
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__DEVICE_RESET_fld_cg with function sample(
1197-
input bit [32-1:0] PLACEHOLDER
1213+
input bit [8-1:0] RESET_CTRL,
1214+
input bit [8-1:0] FORCED_RECOVERY,
1215+
input bit [8-1:0] IF_CTRL
11981216
);
11991217
option.per_instance = 1;
1200-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1218+
RESET_CTRL_cp : coverpoint RESET_CTRL;
1219+
FORCED_RECOVERY_cp : coverpoint FORCED_RECOVERY;
1220+
IF_CTRL_cp : coverpoint IF_CTRL;
12011221

12021222
endgroup
12031223

@@ -1214,10 +1234,14 @@
12141234

12151235
endgroup
12161236
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__RECOVERY_CTRL_fld_cg with function sample(
1217-
input bit [32-1:0] PLACEHOLDER
1237+
input bit [8-1:0] CMS,
1238+
input bit [8-1:0] REC_IMG_SEL,
1239+
input bit [8-1:0] ACTIVATE_REC_IMG
12181240
);
12191241
option.per_instance = 1;
1220-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1242+
CMS_cp : coverpoint CMS;
1243+
REC_IMG_SEL_cp : coverpoint REC_IMG_SEL;
1244+
ACTIVATE_REC_IMG_cp : coverpoint ACTIVATE_REC_IMG;
12211245

12221246
endgroup
12231247

@@ -1234,10 +1258,14 @@
12341258

12351259
endgroup
12361260
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__RECOVERY_STATUS_fld_cg with function sample(
1237-
input bit [32-1:0] PLACEHOLDER
1261+
input bit [4-1:0] DEV_REC_STATUS,
1262+
input bit [4-1:0] REC_IMG_INDEX,
1263+
input bit [8-1:0] VENDOR_SPECIFIC_STATUS
12381264
);
12391265
option.per_instance = 1;
1240-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1266+
DEV_REC_STATUS_cp : coverpoint DEV_REC_STATUS;
1267+
REC_IMG_INDEX_cp : coverpoint REC_IMG_INDEX;
1268+
VENDOR_SPECIFIC_STATUS_cp : coverpoint VENDOR_SPECIFIC_STATUS;
12411269

12421270
endgroup
12431271

@@ -1254,10 +1282,22 @@
12541282

12551283
endgroup
12561284
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__HW_STATUS_fld_cg with function sample(
1257-
input bit [32-1:0] PLACEHOLDER
1285+
input bit [1-1:0] TEMP_CRITICAL,
1286+
input bit [1-1:0] SOFT_ERR,
1287+
input bit [1-1:0] FATAL_ERR,
1288+
input bit [5-1:0] RESERVED_7_3,
1289+
input bit [8-1:0] VENDOR_HW_STATUS,
1290+
input bit [8-1:0] CTEMP,
1291+
input bit [8-1:0] VENDOR_HW_STATUS_LEN
12581292
);
12591293
option.per_instance = 1;
1260-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1294+
TEMP_CRITICAL_cp : coverpoint TEMP_CRITICAL;
1295+
SOFT_ERR_cp : coverpoint SOFT_ERR;
1296+
FATAL_ERR_cp : coverpoint FATAL_ERR;
1297+
RESERVED_7_3_cp : coverpoint RESERVED_7_3;
1298+
VENDOR_HW_STATUS_cp : coverpoint VENDOR_HW_STATUS;
1299+
CTEMP_cp : coverpoint CTEMP;
1300+
VENDOR_HW_STATUS_LEN_cp : coverpoint VENDOR_HW_STATUS_LEN;
12611301

12621302
endgroup
12631303

@@ -1274,10 +1314,14 @@
12741314

12751315
endgroup
12761316
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__INDIRECT_FIFO_CTRL_0_fld_cg with function sample(
1277-
input bit [32-1:0] PLACEHOLDER
1317+
input bit [8-1:0] CMS,
1318+
input bit [8-1:0] RESET,
1319+
input bit [16-1:0] IMAGE_SIZE_MSB
12781320
);
12791321
option.per_instance = 1;
1280-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1322+
CMS_cp : coverpoint CMS;
1323+
RESET_cp : coverpoint RESET;
1324+
IMAGE_SIZE_MSB_cp : coverpoint IMAGE_SIZE_MSB;
12811325

12821326
endgroup
12831327

@@ -1294,10 +1338,10 @@
12941338

12951339
endgroup
12961340
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__INDIRECT_FIFO_CTRL_1_fld_cg with function sample(
1297-
input bit [32-1:0] PLACEHOLDER
1341+
input bit [16-1:0] IMAGE_SIZE_LSB
12981342
);
12991343
option.per_instance = 1;
1300-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1344+
IMAGE_SIZE_LSB_cp : coverpoint IMAGE_SIZE_LSB;
13011345

13021346
endgroup
13031347

@@ -1316,12 +1360,12 @@
13161360
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__INDIRECT_FIFO_STATUS_0_fld_cg with function sample(
13171361
input bit [1-1:0] EMPTY,
13181362
input bit [1-1:0] FULL,
1319-
input bit [3-1:0] REGION
1363+
input bit [3-1:0] REGION_TYPE
13201364
);
13211365
option.per_instance = 1;
13221366
EMPTY_cp : coverpoint EMPTY;
13231367
FULL_cp : coverpoint FULL;
1324-
REGION_cp : coverpoint REGION;
1368+
REGION_TYPE_cp : coverpoint REGION_TYPE;
13251369

13261370
endgroup
13271371

@@ -1405,8 +1449,8 @@
14051449

14061450
endgroup
14071451

1408-
/*----------------------- I3CCSR__I3C_EC__SECFWRECOVERYIF__INDIRECT_FIFO_STATUS_5 COVERGROUPS -----------------------*/
1409-
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__INDIRECT_FIFO_STATUS_5_bit_cg with function sample(input bit reg_bit);
1452+
/*----------------------- I3CCSR__I3C_EC__SECFWRECOVERYIF__INDIRECT_FIFO_RESERVED COVERGROUPS -----------------------*/
1453+
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__INDIRECT_FIFO_RESERVED_bit_cg with function sample(input bit reg_bit);
14101454
option.per_instance = 1;
14111455
reg_bit_cp : coverpoint reg_bit {
14121456
bins value[2] = {0,1};
@@ -1417,11 +1461,11 @@
14171461
}
14181462

14191463
endgroup
1420-
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__INDIRECT_FIFO_STATUS_5_fld_cg with function sample(
1421-
input bit [32-1:0] PLACEHOLDER
1464+
covergroup I3CCSR__I3C_EC__SecFwRecoveryIf__INDIRECT_FIFO_RESERVED_fld_cg with function sample(
1465+
input bit [32-1:0] DATA
14221466
);
14231467
option.per_instance = 1;
1424-
PLACEHOLDER_cp : coverpoint PLACEHOLDER;
1468+
DATA_cp : coverpoint DATA;
14251469

14261470
endgroup
14271471

0 commit comments

Comments
 (0)