[#91570] ibert_eyescan: Allow disabling loopback

Author: p-woj

protoplaster/tests/bert/vivado_ibert/ibert_eyescan.py

@@ -10,12 +10,13 @@
 class EyeScan:
 
     def __init__(self, vivado_cmd: str, hw_server: str, serial_number: str,
-                 channel_path: str, prbs_bits: int) -> None:
+                 channel_path: str, prbs_bits: int, loopback: bool) -> None:
         self.eyescan_file = tempfile.NamedTemporaryFile()
         self.hw_server = hw_server
         self.serial_number = serial_number
         self.channel_path = channel_path
         self.prbs_bits = prbs_bits
+        self.loopback = loopback
 
         # Check if Vivado is available
         if shutil.which(vivado_cmd) is None:
@@ -38,6 +39,7 @@ def __init__(self, vivado_cmd: str, hw_server: str, serial_number: str,
             self.serial_number,
             self.channel_path,
             str(self.prbs_bits),
+            int(self.loopback),
         ]
         res = subprocess.run(vivado_argv,
                              cwd=os.path.dirname(__file__),

protoplaster/tests/bert/vivado_ibert/ibert_eyescan.tcl

@@ -1,4 +1,4 @@
-proc perform_eye_scan { outputPath hwServer serialNumber channelPath prbsBits } {
+proc perform_eye_scan { outputPath hwServer serialNumber channelPath prbsBits loopback } {
 	# Connect to the emulator
 	open_hw_manager
 	connect_hw_server -url "$hwServer"
@@ -12,9 +12,11 @@ proc perform_eye_scan { outputPath hwServer serialNumber channelPath prbsBits }
 	lappend xil_newLinks $xil_newLink
 	set xil_newLinkGroup [create_hw_sio_linkgroup -description {Link Group 0} [get_hw_sio_links $xil_newLinks]]
 	unset xil_newLinks
-	# Set link to use PCS Loopback, and write to hardware
-	set_property LOOPBACK {Far-End PCS} [get_hw_sio_links -of_objects [get_hw_sio_linkgroups {Link_Group_0}]]
-	commit_hw_sio -non_blocking [get_hw_sio_links -of_objects [get_hw_sio_linkgroups {Link_Group_0}]]
+	if { $loopback } {
+		# Set link to use PCS Loopback, and write to hardware
+		set_property LOOPBACK {Far-End PCS} [get_hw_sio_links -of_objects [get_hw_sio_linkgroups {Link_Group_0}]]
+		commit_hw_sio -non_blocking [get_hw_sio_links -of_objects [get_hw_sio_linkgroups {Link_Group_0}]]
+	}
 	set_property RX_PATTERN "PRBS $prbsBits-bit" [get_hw_sio_links -of_objects [get_hw_sio_linkgroups {Link_Group_0}]]
 	commit_hw_sio -non_blocking [get_hw_sio_links -of_objects [get_hw_sio_linkgroups {Link_Group_0}]]
 	set_property TX_PATTERN "PRBS $prbsBits-bit" [get_hw_sio_links -of_objects [get_hw_sio_linkgroups {Link_Group_0}]]
@@ -26,7 +28,7 @@ proc perform_eye_scan { outputPath hwServer serialNumber channelPath prbsBits }
 	write_hw_sio_scan $outputPath $xil_newScan
 }
 
-set requiredArgs 5
+set requiredArgs 6
 if { $argc != $requiredArgs } {
 	puts "Incorrect argument count, got $argc, expected $requiredArgs"
 	exit 1
@@ -37,5 +39,6 @@ set hwServer [lindex $argv 1]
 set serialNumber [lindex $argv 2]
 set channelPath [lindex $argv 3]
 set prbsBits [lindex $argv 4]
+set loopback [lindex $argv 5]
 
-perform_eye_scan $outputPath $serialNumber $channelPath $prbsBits
+perform_eye_scan $outputPath $hwServer $serialNumber $channelPath $prbsBits $loopback

protoplaster/tests/bert/vivado_ibert/test.py

@@ -33,12 +33,14 @@ def setup_class(self):
 
         vivado_cmd = getattr(self, "vivado_cmd", "vivado")
         hw_server = getattr(self, "hw_server", "localhost:3121")
+        loopback = getattr(self, "loopback", True)
         if not hasattr(self, "test_name"):
             self.test_name = (
                 f"vivado_ibert eyescan: {self.prbs_bits}-bit PRBS "
-                f"on {hw_server}/{self.serial_number}/{self.channel_path}")
+                f"on {hw_server}/{self.serial_number}/{self.channel_path}, "
+                f"{'' if loopback else 'no '} loopback")
         self.eyescan = EyeScan(vivado_cmd, hw_server, self.serial_number,
-                               self.channel_path, self.prbs_bits)
+                               self.channel_path, self.prbs_bits, loopback)
 
     def test_create_diagram(self, record_artifact, artifacts_dir):
         """

pyproject.toml

@@ -19,4 +19,4 @@ protoplaster-mgmt = 'manager.protoplaster_mgmt:main'
 dependencies = {file = ["requirements.txt"]}
 
 [tool.setuptools.package-data]
-"*" = ["*.md", "*.css", "*.html", "*.yml", "*.svg", "*.png"]
+"*" = ["*.md", "*.css", "*.html", "*.yml", "*.svg", "*.png", "*.tcl"]