[#91875] vivado_ibert: Add DWELL configuration support

Author: dolszewski-antmicro

protoplaster/tests/bert/vivado_ibert/ibert_eyescan.py

@@ -3,21 +3,26 @@
 import shutil
 import tempfile
 import subprocess
+from typing import Literal, Optional
 
 from jinja2 import DictLoader, Environment
 
 
 class EyeScan:
 
     def __init__(self, vivado_cmd: str, hw_server: str, serial_number: str,
-                 channel_path: str, prbs_bits: int, loopback: bool) -> None:
+                 channel_path: str, prbs_bits: int, loopback: bool,
+                 dwell_mode: Optional[Literal["BER", "TIME"]],
+                 dwell_value: Optional[float]):
         self.eyescan_file = tempfile.NamedTemporaryFile(suffix=".csv")
         self.hw_server = hw_server
         self.serial_number = serial_number
         self.channel_path = channel_path
         self.prbs_bits = prbs_bits
         self.loopback = loopback
         self.report_file = tempfile.NamedTemporaryFile(suffix=".report")
+        self.dwell_mode = dwell_mode
+        self.dwell_value = dwell_value
 
         # Check if Vivado is available
         if shutil.which(vivado_cmd) is None:
@@ -42,6 +47,8 @@ def __init__(self, vivado_cmd: str, hw_server: str, serial_number: str,
             str(self.prbs_bits),
             str(self.loopback),
             self.report_file.name,
+            self.dwell_mode or "",
+            str(self.dwell_value) if self.dwell_value is not None else "",
         ]
         res = subprocess.run(vivado_argv,
                              cwd=os.path.dirname(__file__),

protoplaster/tests/bert/vivado_ibert/ibert_eyescan.tcl

@@ -1,4 +1,4 @@
-proc perform_eye_scan { outputPath hwServer serialNumber channelPath prbsBits loopback reportFile } {
+proc perform_eye_scan { outputPath hwServer serialNumber channelPath prbsBits loopback reportFile dwellMode dwellValue } {
 	# Connect to the emulator
 	open_hw_manager
 	connect_hw_server -url "$hwServer"
@@ -31,6 +31,18 @@ proc perform_eye_scan { outputPath hwServer serialNumber channelPath prbsBits lo
 
 	# Create, run, and save scan
 	set xil_newScan [create_hw_sio_scan -description {Scan 0} 2d_full_eye  [lindex [get_hw_sio_links $fullPath/TX->$fullPath/RX] 0 ]]
+
+	if { $dwellMode eq "BER" } {
+		if { $dwellValue ne "" } {
+			set_property DWELL_BER $dwellValue [get_hw_sio_scans $xil_newScan]
+		}
+	} elseif { $dwellMode eq "TIME" } {
+		set_property DWELL TIME [get_hw_sio_scans $xil_newScan]
+		if { $dwellValue ne "" } {
+			set_property DWELL_TIME $dwellValue [get_hw_sio_scans $xil_newScan]
+		}
+	}
+
 	run_hw_sio_scan [get_hw_sio_scans $xil_newScan]
 	wait_on_hw_sio_scan [get_hw_sio_scans $xil_newScan]
 	write_hw_sio_scan -force $outputPath [get_hw_sio_scans $xil_newScan]
@@ -49,5 +61,7 @@ set channelPath [lindex $argv 3]
 set prbsBits [lindex $argv 4]
 set loopback [lindex $argv 5]
 set reportFile [lindex $argv 6]
+set dwellMode [lindex $argv 7]
+set dwellValue [lindex $argv 8]
 
-perform_eye_scan $outputPath $hwServer $serialNumber $channelPath $prbsBits $loopback $reportFile
+perform_eye_scan $outputPath $hwServer $serialNumber $channelPath $prbsBits $loopback $reportFile $dwellMode $dwellValue

protoplaster/tests/bert/vivado_ibert/test.py

@@ -35,13 +35,30 @@ def configure(self):
         vivado_cmd = getattr(self, "vivado_cmd", "vivado")
         hw_server = getattr(self, "hw_server", "localhost:3121")
         loopback = getattr(self, "loopback", True)
+        dwell_mode = getattr(self, "dwell_mode", None)
+        assert dwell_mode in ['BER', 'TIME', None], \
+            "`dwell_mode` test attribute must be either 'BER' or 'TIME' when provided"
+        try:
+            value = getattr(self, "dwell_value", None)
+            if value is not None:
+                dwell_value = float(value)
+        except (ValueError, TypeError):
+            raise AssertionError(
+                "`dwell_value` test attribute must be convertible to `float` when provided"
+            )
+
         if not hasattr(self, "test_name"):
+            if dwell_mode == None:
+                dwell_string = "DEFAULT DWELL"
+            else:
+                dwell_string = f"DWELL {dwell_mode}: {dwell_value}"
             self.test_name = (
                 f"vivado_ibert eyescan: {self.prbs_bits}-bit PRBS "
                 f"on {hw_server}/{self.serial_number}/{self.channel_path}, "
-                f"{'' if loopback else 'no '} loopback")
+                f"{'' if loopback else 'no '} loopback, {dwell_string}")
         self.eyescan = EyeScan(vivado_cmd, hw_server, self.serial_number,
-                               self.channel_path, self.prbs_bits, loopback)
+                               self.channel_path, self.prbs_bits, loopback,
+                               dwell_mode, dwell_value)
 
     def test_transceiver_status(self):
         """