[#76585] cli: Don't ignore errors in write_{file,rootfs}

p-woj · p-woj · commit 24f42fa183b2 · 2025-04-28T14:05:20.000+02:00
Signed-off-by: Piotr Wojnarowski &lt;pwojnarowski@antmicro.com&gt;
diff --git a/tools/rdfm-artifact/cli/write_file.go b/tools/rdfm-artifact/cli/write_file.go
@@ -158,7 +158,5 @@ func writeSingleFile(c *cli.Context) error {
 	writer.WithPayloadClearsProvides(payloadClearsProvides)
 
 	log.Info("Writing single file artifact...")
-	writer.Write()
-
-	return nil
+	return writer.Write()
 }
diff --git a/tools/rdfm-artifact/cli/write_rootfs.go b/tools/rdfm-artifact/cli/write_rootfs.go
@@ -55,7 +55,10 @@ func writeFullRootfs(c *cli.Context) error {
 	writer.WithPayloadProvides(payloadProvides)
 	writer.WithPayloadDepends(payloadDepends)
 	writer.WithPayloadClearsProvides(payloadClearsProvides)
-	writer.WithFullRootfsPayload(inputRootfsImage)
+	err = writer.WithFullRootfsPayload(inputRootfsImage)
+	if err != nil {
+		return err
+	}
 
 	log.Println("Writing full rootfs artifact...")
 	return writer.Write()

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,5 @@ func writeSingleFile(c *cli.Context) error {`
`158`	`158`	`writer.WithPayloadClearsProvides(payloadClearsProvides)`
`159`	`159`
`160`	`160`	`log.Info("Writing single file artifact...")`
`161`		`- writer.Write()`
`162`		`-`
`163`		`- return nil`
	`161`	`+ return writer.Write()`
`164`	`162`	`}`