Discard changes to tests/pytest/terraform_docs_replace_test.py

Author: MaxymVlasov

tests/pytest/terraform_docs_replace_test.py

@@ -1,7 +1,7 @@
 """Tests for the `replace-docs` subcommand."""
 
 from argparse import ArgumentParser, Namespace
-from subprocess import CalledProcessError  # noqa: S404. We invoke cli tools
+from subprocess import CalledProcessError
 
 import pytest
 import pytest_mock
@@ -10,8 +10,6 @@
 from pre_commit_terraform.terraform_docs_replace import (
     invoke_cli_app,
     populate_argument_parser,
-)
-from pre_commit_terraform.terraform_docs_replace import (
     subprocess as replace_docs_subprocess_mod,
 )
 
@@ -26,7 +24,8 @@ def test_arg_parser_populated() -> None:
 def test_check_is_deprecated() -> None:
     """Verify that `replace-docs` shows a deprecation warning."""
     deprecation_msg_regex = (
-        r'^`terraform_docs_replace` hook is DEPRECATED\.' + 'For migration.*$'
+        r'^`terraform_docs_replace` hook is DEPRECATED\.'
+        'For migration.*$'
     )
     with pytest.warns(UserWarning, match=deprecation_msg_regex):
         # not `pytest.deprecated_call()` due to this being a user warning
@@ -71,10 +70,10 @@ def test_check_is_deprecated() -> None:
     'pre_commit_terraform.terraform_docs_replace',
 )
 def test_control_flow_positive(
-    expected_cmds: list[str],
-    mocker: pytest_mock.MockerFixture,
-    monkeypatch: pytest.MonkeyPatch,
-    parsed_cli_args: Namespace,
+        expected_cmds: list[str],
+        mocker: pytest_mock.MockerFixture,
+        monkeypatch: pytest.MonkeyPatch,
+        parsed_cli_args: Namespace,
 ) -> None:
     """Check that the subcommand's happy path works."""
     check_call_mock = mocker.Mock()
@@ -84,10 +83,10 @@ def test_control_flow_positive(
         check_call_mock,
     )
 
-    assert invoke_cli_app(parsed_cli_args) == ReturnCode.OK
+    assert ReturnCode.OK == invoke_cli_app(parsed_cli_args)
 
     executed_commands = [
-        cmd for ((cmd,), _shell) in check_call_mock.call_args_list
+        cmd for ((cmd, ), _shell) in check_call_mock.call_args_list
     ]
 
     assert len(expected_cmds) == check_call_mock.call_count
@@ -99,8 +98,8 @@ def test_control_flow_positive(
     'pre_commit_terraform.terraform_docs_replace',
 )
 def test_control_flow_negative(
-    mocker: pytest_mock.MockerFixture,
-    monkeypatch: pytest.MonkeyPatch,
+        mocker: pytest_mock.MockerFixture,
+        monkeypatch: pytest.MonkeyPatch,
 ) -> None:
     """Check that the subcommand's error processing works."""
     parsed_cli_args = Namespace(
@@ -119,6 +118,6 @@ def test_control_flow_negative(
         check_call_mock,
     )
 
-    assert invoke_cli_app(parsed_cli_args) == ReturnCode.ERROR
-    # We call cli tools, of course we use shell=True
-    check_call_mock.assert_called_once_with(expected_cmd, shell=True)  # noqa: S604
+    assert ReturnCode.ERROR == invoke_cli_app(parsed_cli_args)
+
+    check_call_mock.assert_called_once_with(expected_cmd, shell=True)