Skip to content

Commit b45bb4e

Browse files
committed
Move hadolint ignores to meaningful locations
Sadly, but hadolint ignore doesn't work if there any symbol on the same line - ignore stop working. That's why set justification on different line to hadolint ignore comment
1 parent 96af868 commit b45bb4e

File tree

3 files changed

+9
-15
lines changed

3 files changed

+9
-15
lines changed

.hadolint.yaml

Lines changed: 0 additions & 9 deletions
This file was deleted.

Dockerfile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ RUN if [ "$INSTALL_ALL" != "false" ]; then \
6565
echo "TRIVY_VERSION=latest" >> /.env \
6666
; fi
6767

68+
# Docker `RUN`s shouldn't be consolidated here
69+
# hadolint global ignore=DL3059
6870
RUN /install/opentofu.sh
6971
RUN /install/terraform.sh
7072

@@ -81,6 +83,9 @@ RUN /install/trivy.sh
8183

8284

8385
# Checking binaries versions and write it to debug file
86+
87+
# We do not use `echo` flags here, so it's false-positive
88+
# hadolint ignore=SC3037
8489
RUN . /.env && \
8590
F=tools_versions_info && \
8691
pre-commit --version >> $F && \

tests/Dockerfile

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1+
# We use `latest` tag for tests proposes
2+
# hadolint ignore=DL3007
13
FROM pre-commit-terraform:latest
24

3-
RUN apt update && \
4-
apt install -y \
5-
datamash \
6-
time && \
7-
# Cleanup
8-
rm -rf /var/lib/apt/lists/*
5+
RUN apk add --no-cache \
6+
datamash=~1.8
97

108
WORKDIR /pct
119
ENTRYPOINT [ "/pct/tests/hooks_performance_test.sh" ]

0 commit comments

Comments
 (0)