Skip to content

Commit 948b47d

Browse files
authored
Add NoOpTraceProvider test for opentelemetry-instrumentation-logging (open-telemetry#2649)
1 parent cc52bd2 commit 948b47d

File tree

1 file changed

+16
-1
lines changed

1 file changed

+16
-1
lines changed

instrumentation/opentelemetry-instrumentation-logging/tests/test_logging.py

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
LoggingInstrumentor,
2424
)
2525
from opentelemetry.test.test_base import TestBase
26-
from opentelemetry.trace import ProxyTracer, get_tracer
26+
from opentelemetry.trace import NoOpTracerProvider, ProxyTracer, get_tracer
2727

2828

2929
class FakeTracerProvider:
@@ -207,3 +207,18 @@ def test_uninstrumented(self):
207207
self.assertFalse(hasattr(record, "otelTraceID"))
208208
self.assertFalse(hasattr(record, "otelServiceName"))
209209
self.assertFalse(hasattr(record, "otelTraceSampled"))
210+
211+
def test_no_op_tracer_provider(self):
212+
LoggingInstrumentor().uninstrument()
213+
LoggingInstrumentor().instrument(tracer_provider=NoOpTracerProvider())
214+
215+
with self.caplog.at_level(level=logging.INFO):
216+
logger = logging.getLogger("test logger")
217+
logger.info("hello")
218+
219+
self.assertEqual(len(self.caplog.records), 1)
220+
record = self.caplog.records[0]
221+
self.assertEqual(record.otelSpanID, "0")
222+
self.assertEqual(record.otelTraceID, "0")
223+
self.assertEqual(record.otelServiceName, "")
224+
self.assertEqual(record.otelTraceSampled, False)

0 commit comments

Comments
 (0)