Skip to content

Commit e799a74

Browse files
emdnetoocelotl
andauthored
fix schema url in instrumentation tests (open-telemetry#2730)
* fix schema url in instrumentation tests * change core repo sha for test * Update CORE_REPO_SHA * Try removing cache * Clear cache here as well --------- Co-authored-by: Diego Hurtado <[email protected]>
1 parent 92da527 commit e799a74

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

.github/workflows/instrumentations_0.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
- 'release/*'
77
pull_request:
88
env:
9-
CORE_REPO_SHA: 141a6a2e473ef7f0ec4915dfb71e3c0fa595283e
9+
CORE_REPO_SHA: main
1010

1111
jobs:
1212
instrumentations-0:
@@ -114,6 +114,6 @@ jobs:
114114
path: |
115115
.tox
116116
~/.cache/pip
117-
key: v7-build-tox-cache-${{ env.RUN_MATRIX_COMBINATION }}-${{ hashFiles('tox.ini', 'gen-requirements.txt', 'dev-requirements.txt') }}
117+
key: v7-build-tox-cache-${{ env.RUN_MATRIX_COMBINATION }}-${{ hashFiles('gen-requirements.txt', 'dev-requirements.txt') }}
118118
- name: run tox
119119
run: tox -f ${{ matrix.python-version }}-${{ matrix.package }} -- -ra

.github/workflows/instrumentations_1.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
- 'release/*'
77
pull_request:
88
env:
9-
CORE_REPO_SHA: 141a6a2e473ef7f0ec4915dfb71e3c0fa595283e
9+
CORE_REPO_SHA: main
1010

1111
jobs:
1212
instrumentations-1:
@@ -59,6 +59,6 @@ jobs:
5959
path: |
6060
.tox
6161
~/.cache/pip
62-
key: v7-build-tox-cache-${{ env.RUN_MATRIX_COMBINATION }}-${{ hashFiles('tox.ini', 'gen-requirements.txt', 'dev-requirements.txt') }}
62+
key: v7-build-tox-cache-${{ env.RUN_MATRIX_COMBINATION }}-${{ hashFiles('gen-requirements.txt', 'dev-requirements.txt') }}
6363
- name: run tox
6464
run: tox -f ${{ matrix.python-version }}-${{ matrix.package }} -- -ra

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
- 'release/*'
77
pull_request:
88
env:
9-
CORE_REPO_SHA: 141a6a2e473ef7f0ec4915dfb71e3c0fa595283e
9+
CORE_REPO_SHA: main
1010

1111
jobs:
1212
lint-3_12:

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
- 'release/*'
77
pull_request:
88
env:
9-
CORE_REPO_SHA: 141a6a2e473ef7f0ec4915dfb71e3c0fa595283e
9+
CORE_REPO_SHA: main
1010

1111
jobs:
1212
misc:

instrumentation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ def test_schema_url_new_semconv(self):
223223
span = self.memory_exporter.get_finished_spans()[0]
224224
self.assertEqual(
225225
span.instrumentation_info.schema_url,
226-
"https://opentelemetry.io/schemas/v1.21.0",
226+
"https://opentelemetry.io/schemas/1.21.0",
227227
)
228228
self.memory_exporter.clear()
229229

@@ -240,7 +240,7 @@ def test_schema_url_both_semconv(self):
240240
span = self.memory_exporter.get_finished_spans()[0]
241241
self.assertEqual(
242242
span.instrumentation_info.schema_url,
243-
"https://opentelemetry.io/schemas/v1.21.0",
243+
"https://opentelemetry.io/schemas/1.21.0",
244244
)
245245
self.memory_exporter.clear()
246246

instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_integration.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ def test_schema_url_new_semconv(self):
239239
span = self.assert_span()
240240
self.assertEqual(
241241
span.instrumentation_scope.schema_url,
242-
"https://opentelemetry.io/schemas/v1.21.0",
242+
"https://opentelemetry.io/schemas/1.21.0",
243243
)
244244

245245
def test_schema_url_both_semconv(self):
@@ -250,7 +250,7 @@ def test_schema_url_both_semconv(self):
250250
span = self.assert_span()
251251
self.assertEqual(
252252
span.instrumentation_scope.schema_url,
253-
"https://opentelemetry.io/schemas/v1.21.0",
253+
"https://opentelemetry.io/schemas/1.21.0",
254254
)
255255

256256
def test_basic_not_found(self):

0 commit comments

Comments
 (0)