fix test

Author: antonshevelev

tests/RedisConnectionTest.php

@@ -23,7 +23,7 @@ protected function tearDown(): void
     /**
      * test connection to redis and selection of db
      */
-    public function testConnect()
+    public function testConnect(): void
     {
         $db = $this->getConnection(false);
         $database = $db->database;
@@ -48,7 +48,7 @@ public function testConnect()
     /**
      * tests whether close cleans up correctly so that a new connect works
      */
-    public function testReConnect()
+    public function testReConnect(): void
     {
         $db = $this->getConnection(false);
         $db->open();
@@ -64,7 +64,7 @@ public function testReConnect()
     /**
      * @return array
      */
-    public function keyValueData()
+    public function keyValueData(): array
     {
         return [
             [123],
@@ -80,15 +80,15 @@ public function keyValueData()
      * @dataProvider keyValueData
      * @param mixed $data
      */
-    public function testStoreGet($data)
+    public function testStoreGet(mixed $data):void
     {
         $db = $this->getConnection(true);
 
         $db->set('hi', $data);
         $this->assertEquals($data, $db->get('hi'));
     }
 
-    public function testSerialize()
+    public function testSerialize(): void
     {
         $db = $this->getConnection(false);
         $db->open();
@@ -100,7 +100,7 @@ public function testSerialize()
         $this->assertTrue($db2->ping());
     }
 
-    public function testConnectionTimeout()
+    public function testConnectionTimeout(): void
     {
         $db = $this->getConnection(false);
         $db->configSet('timeout', 1);
@@ -124,7 +124,7 @@ public function testConnectionTimeout()
         $this->assertTrue($exception, 'SocketException should have been thrown.');
     }
 
-    public function testConnectionTimeoutRetry()
+    public function testConnectionTimeoutRetry(): void
     {
         $logger = new Logger();
         Yii::setLogger($logger);
@@ -146,16 +146,16 @@ public function testConnectionTimeoutRetry()
 
         $this->assertTrue($db->ping());
         $this->assertCount(11, $logger->messages, 'log +1 ping command, and reconnection.'
-            . print_r(array_map(function($s) { return (string) $s; }, ArrayHelper::getColumn($logger->messages, 0)), true));
+            . print_r(array_map(static function($s) { return (string) $s; }, ArrayHelper::getColumn($logger->messages, 0)), true));
     }
 
-    public function testConnectionTimeoutRetryWithFirstFail()
+    public function testConnectionTimeoutRetryWithFirstFail(): void
     {
         $logger = new Logger();
         Yii::setLogger($logger);
 
         $databases = TestCase::getParam('databases');
-        $redis = isset($databases['redis']) ? $databases['redis'] : [];
+        $redis = $databases['redis'] ?? [];
         $db = new ConnectionWithErrorEmulator($redis);
         $db->retries = 3;
 
@@ -172,13 +172,13 @@ public function testConnectionTimeoutRetryWithFirstFail()
 
         $this->assertTrue($db->ping());
         $this->assertCount(10, $logger->messages, 'log +1 ping command, and two reconnections.'
-            . print_r(array_map(function($s) { return (string) $s; }, ArrayHelper::getColumn($logger->messages, 0)), true));
+            . print_r(array_map(static function($s) { return (string) $s; }, ArrayHelper::getColumn($logger->messages, 0)), true));
     }
 
     /**
      * Retry connecting 2 times
      */
-    public function testConnectionTimeoutRetryCount()
+    public function testConnectionTimeoutRetryCount(): void
     {
         $logger = new Logger();
         Yii::setLogger($logger);
@@ -209,7 +209,7 @@ public function testConnectionTimeoutRetryCount()
     /**
      * https://github.com/yiisoft/yii2/issues/4745
      */
-    public function testReturnType()
+    public function testReturnType(): void
     {
         $redis = $this->getConnection();
         $redis->executeCommand('SET', ['key1', 'val1']);
@@ -232,18 +232,18 @@ public function testReturnType()
         }
     }
 
-    public function testTwoWordCommands()
+    public function testTwoWordCommands(): void
     {
         $redis = $this->getConnection();
-        $this->assertTrue(is_array($redis->executeCommand('CONFIG GET', ['port'])));
-        $this->assertTrue(is_string($redis->clientList()));
-        $this->assertTrue(is_string($redis->executeCommand('CLIENT LIST')));
+        $this->assertIsArray($redis->executeCommand('CONFIG GET', ['port']));
+        $this->assertIsString($redis->clientList());
+        $this->assertIsString($redis->executeCommand('CLIENT LIST'));
     }
 
     /**
      * @return array
      */
-    public function zRangeByScoreData()
+    public function zRangeByScoreData(): array
     {
         return [
             [
@@ -285,17 +285,17 @@ public function zRangeByScoreData()
      * @param array $members
      * @param array $cases
      */
-    public function testZRangeByScore($members, $cases)
+    public function testZRangeByScore(array $members, array $cases): void
     {
         $redis = $this->getConnection();
         $set = 'zrangebyscore';
         foreach ($members as $member) {
-            list($name, $score) = $member;
+            [$name, $score] = $member;
             $this->assertEquals(1, $redis->zadd($set, $score, $name));
         }
 
         foreach ($cases as $case) {
-            list($min, $max, $withScores, $limit, $offset, $count, $expectedRows) = $case;
+            [$min, $max, $withScores, $limit, $offset, $count, $expectedRows] = $case;
             if ($withScores !== null && $limit !== null) {
                 $rows = $redis->zrangebyscore($set, $min, $max, $withScores, $limit, $offset, $count);
             } elseif ($withScores !== null) {
@@ -316,7 +316,7 @@ public function testZRangeByScore($members, $cases)
     /**
      * @return array
      */
-    public function hmSetData()
+    public function hmSetData(): array
     {
         return [
             [
@@ -343,7 +343,7 @@ public function hmSetData()
      * @param array $params
      * @param array $pairs
      */
-    public function testHMSet($params, $pairs)
+    public function testHMSet(array $params, array $pairs): void
     {
         $redis = $this->getConnection();
         $set = $params[0];