fix: bug fix as per sonar cloud

Author: DheerajGBhatt

bin/index.ts

@@ -9,43 +9,34 @@ import { deployCLI } from "../src/roverCLI/roverDeployCLI"
 
 import * as cliConfig from "../src/configs/cliConfig"
 import * as util from "../src/utilities/cliUtil"
-const test = {
-  app_name: "dgbcom",
-  language: "node",
-  file_name: "dgbcom/template.yaml\n",
-  components: ["S3 Lambda", "CRUD API", "S3 Bucket", "Lambda", "DynamoDB"],
-}
+
 import { version } from "../package.json"
 
 async function run(argv: Array<string>): Promise<void> {
   try {
     if (rover_helpers.npmrootTest()) {
-      const commandErrors = cliConfig.commandError(argv)
-      if (argv.length === 1) {
-        if (argv.length === 1 && argv[0] === "init") {
-          const editedSam = await util.confirmation()
-          if (editedSam === "create new SAM project") {
-            await createSAMCLI()
-          } else if (editedSam === "add components to existing SAM") {
-            await addComponentCLI()
-          } else if (editedSam === "add modules to existing SAM") {
-            await addModuleCLI()
-          }
-        } else if (argv[0] === "deploy") {
-          await deployCLI()
-        } else if (argv[0] === "-v" || argv[0] === "--version") {
-          // show current package version in the console
-          console.log(version)
-        } else {
-          console.log(commandErrors)
-        }
-      } else {
-        console.log(commandErrors)
+      throw new Error(cliConfig.globalError)
+    }
+    const commandErrors = cliConfig.commandError(argv)
+    if (argv.length !== 1) {
+      throw new Error(commandErrors)
+    }
+    if (argv[0] === "init") {
+      const editedSam = await util.confirmation()
+      if (editedSam === "create new SAM project") {
+        await createSAMCLI()
+      } else if (editedSam === "add components to existing SAM") {
+        await addComponentCLI()
+      } else if (editedSam === "add modules to existing SAM") {
+        await addModuleCLI()
       }
+    } else if (argv[0] === "deploy") {
+      await deployCLI()
+    } else if (argv[0] === "-v" || argv[0] === "--version") {
+      // show current package version in the console
+      console.log(version)
     } else {
-      console.log(
-        "Note: install @rover-tools/cli globally (install @rover-tools/cli -g)"
-      )
+      console.log(commandErrors)
     }
   } catch (error) {
     console.log("Error: ", (error as Error).message)

src/scripts/exec.sh scripts/exec.shsrc/scripts/exec.sh renamed to scripts/exec.sh

@@ -2,6 +2,8 @@ import { Iroverdescription } from "../rover.types"
 import * as rover from "@rover-tools/engine/dist/bin/index"
 const rovercomponents = rover.components
 const Stack = rover.modules
+export const globalError =
+  "Note: install @rover-tools/cli globally (install @rover-tools/cli -g)"
 export const commandError = (argv: Array<string>) => {
   return `rover ${argv.join(
     " "

src/configs/cliConfig.ts

@@ -70,7 +70,7 @@ export async function deployCLI() {
     const region = deploymentregion["Deployment region"]
 
     exec(
-      `sh ${rover_helpers.npmroot}/@rover-tools/cli/src/scripts/exec.sh ${file_name} ${stack_name} ${region} ${bucketName} ${profile} `
+      `sh ${rover_helpers.npmroot}/@rover-tools/cli/scripts/exec.sh ${file_name} ${stack_name} ${region} ${bucketName} ${profile} `
     )
 
     const configdata: IroverDeploymentConfig = <IroverDeploymentConfig>{}

src/roverCLI/roverDeployCLI.ts

@@ -27,7 +27,7 @@ export async function createSAMCLI(): Promise<void> {
   await rover_helpers.checkFile(app_name["app_name"], "no")
   const language = await util.languageChoice()
 
-  const template: IroverInput = await createModules(app_name, language, "")
+  const template: IroverInput = await createModules(app_name, language)
   await rover_generateSAM.generateSAM({ template }["template"])
 }
 export async function addComponentCLI() {
@@ -121,7 +121,7 @@ export async function addModuleCLI() {
         )
         console.log(samResources)
         const moduletemplate = <IroveraddModule>(
-          await createModules(app_name, language, "")
+          await createModules(app_name, language)
         )
         if (Object.keys(template).length == 0) {
           template = moduletemplate
@@ -155,7 +155,7 @@ export async function addModuleCLI() {
       i = i + 1
     } while (moreStack !== "No")
   } else {
-    template = <IroveraddModule>await createModules(app_name, language, "")
+    template = <IroveraddModule>await createModules(app_name, language)
   }
   template["file_name"] = file_name
   console.log(JSON.stringify(template))

src/roverCLI/roverGenerateCLI.ts

@@ -291,7 +291,7 @@ export const samBuild = async function (lang: string) {
     )
     const framework = { framework: "sam" }
 
-     let result: IroverDeploymentObject = {
+    const result: IroverDeploymentObject = {
       ...sam,
       ...langs,
       no_of_env,

src/scripts/localtest.ts

@@ -63,8 +63,7 @@ async function CustomObject(i: number) {
 }
 export async function createModules(
   app_name: Record<string, string>,
-  language: string,
-  stackName: string
+  language: string
 ) {
   const stack_names: Record<string, string> = {}
   let customStacks: Record<string, Array<string>> = {}