fix: changing variable names to camelCase

Author: DheerajGBhatt

bin/index.ts

@@ -1,5 +1,5 @@
 import * as rover from "@rover-tools/engine/dist/bin/index"
-const rover_helpers = rover.helpers
+const roverHelpers = rover.helpers
 import {
   createSAMCLI,
   addComponentCLI,
@@ -14,7 +14,7 @@ import { version } from "../package.json"
 
 async function run(argv: Array<string>): Promise<void> {
   try {
-    if (!rover_helpers.npmrootTest()) {
+    if (!roverHelpers.npmrootTest()) {
       throw new Error(cliConfig.globalError)
     }
     const commandErrors = cliConfig.commandError(argv)

src/configs/cliConfig.ts

@@ -1,6 +1,6 @@
 import { Iroverdescription } from "../rover.types"
 import * as rover from "@rover-tools/engine/dist/bin/index"
-const rovercomponents = rover.components
+const roverComponents = rover.components
 const Stack = rover.modules
 export const globalError =
   "Note: install @rover-tools/cli globally (install @rover-tools/cli -g)"
@@ -47,7 +47,7 @@ export const app: Record<
   },
 }
 export const customizable = {
-  components: Object.keys(rovercomponents.Components),
+  components: Object.keys(roverComponents.Components),
   modules: {
     keys: keys,
     values: values,

src/roverCLI/roverDeployCLI.ts

@@ -1,5 +1,5 @@
 import * as rover from "@rover-tools/engine/dist/bin/index"
-const rover_helpers = rover.helpers
+const roverHelpers = rover.helpers
 import * as util from "../utilities/cliUtil"
 const deployment = rover.deployment
 import * as fs from "fs"
@@ -14,23 +14,23 @@ export async function deployCLI() {
   if (r === "repository and pipeline") {
     console.log("Work in progress...")
   } else if (r === "generate pipeline") {
-    await rover_helpers.samValidate("")
-    const lang: string = await rover_helpers.langValue()
+    await roverHelpers.samValidate("")
+    const lang: string = await roverHelpers.langValue()
     const pipeline = await util.samBuild(lang)
     const template = { repoConfig: pipeline }
     const repoconfig = await Promise.resolve(
       util.jsonCreation(<Record<string, IroverDeploymentObject>>template)
     )
     if (repoconfig !== undefined) {
       await deployment.setupRepo(JSON.parse(repoconfig)["repoConfig"])
-      rover_helpers.generateRoverConfig(
+      roverHelpers.generateRoverConfig(
         "",
         JSON.parse(repoconfig)["repoConfig"],
         "rover_generate_pipeline"
       )
     }
   } else {
-    await rover_helpers.samValidate("")
+    await roverHelpers.samValidate("")
     if (fs.existsSync("samconfig.toml")) {
       exec("rm -rf samconfig.toml")
     }
@@ -70,14 +70,14 @@ export async function deployCLI() {
     const region = deploymentregion["Deployment region"]
 
     exec(
-      `sh ${rover_helpers.npmroot}/@rover-tools/cli/scripts/exec.sh ${file_name} ${stack_name} ${region} ${bucketName} ${profile} `
+      `sh ${roverHelpers.npmroot}/@rover-tools/cli/scripts/exec.sh ${file_name} ${stack_name} ${region} ${bucketName} ${profile} `
     )
 
     const configdata: IroverDeploymentConfig = <IroverDeploymentConfig>{}
     configdata["bucket"] = bucketName
     configdata["stack_name"] = stack_name
     configdata["region"] = region
     configdata["profile"] = profile
-    rover_helpers.generateRoverConfig("", configdata, "rover_deploy_cli")
+    roverHelpers.generateRoverConfig("", configdata, "rover_deploy_cli")
   }
 }

src/roverCLI/roverGenerateCLI.ts

@@ -1,5 +1,5 @@
 import * as rover from "@rover-tools/engine/dist/bin/index"
-const rover_helpers = rover.helpers
+const roverHelpers = rover.helpers
 const rover_addComponent = rover.addComponents
 const rover_addModules = rover.addModules
 const rover_generateSAM = rover.generateSAM
@@ -25,7 +25,7 @@ export async function createSAMCLI(): Promise<void> {
     false,
     "App Name:"
   )
-  await rover_helpers.checkFile(app_name["app_name"], "no")
+  await roverHelpers.checkFile(app_name["app_name"], "no")
   const language = await util.languageChoice()
 
   const template: IroverInput = await createModules(app_name, language)
@@ -34,10 +34,10 @@ export async function createSAMCLI(): Promise<void> {
 export async function addComponentCLI() {
   const app_name = await util.inputString("app_name", "", false, "App Name")
   let template: IroveraddComponentInput
-  await rover_helpers.checkFile(app_name["app_name"], "yes")
+  await roverHelpers.checkFile(app_name["app_name"], "yes")
   const language = await util.languageChoice()
   const file_name = await exec(`ls ${app_name["app_name"]}/*.yaml `).toString()
-  const CompStacks = await rover_helpers.checkNested(file_name)
+  const CompStacks = await roverHelpers.checkNested(file_name)
   const nestedComponents: TnestedComponentsObject = <TnestedComponentsObject>{}
   const choice = Object.keys(CompStacks["compStacks"])
   let i = 0
@@ -102,7 +102,7 @@ export async function addModuleCLI(): Promise<void> {
     "Do you want to Add a module to existing Module :"
   )
   if (addToExisting.addToExisting[0] == "Yes") {
-    const CompStacks = await rover_helpers.checkNested(file_name)
+    const CompStacks = await roverHelpers.checkNested(file_name)
     const choice = Object.keys(CompStacks["compStacks"])
     let i = 0
     do {
@@ -115,7 +115,7 @@ export async function addModuleCLI(): Promise<void> {
         const selectedChoice = choice.filter((ele) =>
           Object.values(chooseStack).includes(ele)
         )
-        // const samResources = rover_helpers.listSAMResources(
+        // const samResources = roverHelpers.listSAMResources(
         //   file_name,
         //   selectedChoice[0]
         // )

src/utilities/cliUtil.ts

@@ -56,65 +56,39 @@ export const jsonCreation = async function (
   }
 }
 
-export const inputStrings = async function (
-  userName: string,
+export async function inputString(
+  name: string,
   defaults: string,
   optional: boolean,
-  messages = ""
+  message = ""
 ) {
   const takeInput = await inquirer.prompt([
     {
       type: "input",
-      name: userName,
-      message: messages,
-      validate: function (value) {
-        let message = ""
-        if (userName == "path") {
-          if (apipathpattern.test(value)) return true
-          else message = "Please enter a valid path"
-        } else if (envpattern.test(userName)) {
-          if (value !== "" && value !== undefined) return true
-          else message = "environment values cannot be empty"
+      name,
+      message,
+      validate: (value) => {
+        if (name === "path") {
+          return apipathpattern.test(value) || "Please enter a valid path"
+        } else if (envpattern.test(name)) {
+          return (
+            (value !== "" && value !== undefined) ||
+            "Environment values cannot be empty"
+          )
         } else {
-          if (!optional) {
-            if (stringpattern.test(value)) return true
-            else message = `${messages} should have only alphanumeric values`
-          }
+          return (
+            optional ||
+            stringpattern.test(value) ||
+            `${message} should have only alphanumeric values`
+          )
         }
-        if (message !== "") return message
-        else return true
       },
     },
   ])
-  return { ...takeInput }
-}
 
-export async function inputString(
-  name: string,
-  defaults: string,
-  optional: boolean,
-  message = ""
-) {
-  const takeInput = await inquirer.prompt([{
-    type: "input",
-    name,
-    message,
-    validate: (value) => {
-      if (name === "path") {
-        return apipathpattern.test(value) || "Please enter a valid path";
-      } else if (envpattern.test(name)) {
-        return (value !== "" && value !== undefined) || "Environment values cannot be empty";
-      } else {
-        return optional || stringpattern.test(value) || `${message} should have only alphanumeric values`;
-      }
-    },
-  }
-  ]);
-
-  return { ...takeInput };
+  return { ...takeInput }
 }
 
-
 export const languageChoice = async function () {
   const lang = await inquirer.prompt([
     {
@@ -424,7 +398,7 @@ export const paramss = async function (module: string) {
   }
 }
 
-export const params=async function(module: string) {
+export const params = async function (module: string) {
   const { choices } = cliConfig.app
   const name: Record<string, string> = {}
   const res: IroverCLIparamModule = <IroverCLIparamModule>{}

src/utilities/helper.ts

@@ -11,16 +11,16 @@ import {
 import * as child from "child_process"
 import * as cliConfig from "../configs/cliConfig"
 const exec = child.execSync
-const rover_helpers = rover.helpers
+const roverHelpers = rover.helpers
 import * as util from "./cliUtil"
 let moreStack
 export async function roverADD() {
   const app_name = await util.inputString("app_name", "", false, "App Name:")
-  await rover_helpers.samValidate(<string>app_name["app_name"])
-  await rover_helpers.checkFile(<string>app_name["app_name"], "yes")
+  await roverHelpers.samValidate(<string>app_name["app_name"])
+  await roverHelpers.checkFile(<string>app_name["app_name"], "yes")
   const language = await util.languageChoice()
   const file_name = await exec(`ls ${app_name["app_name"]}/*.yaml `).toString()
-  const CompStacks = await rover_helpers.checkNested(file_name)
+  const CompStacks = await roverHelpers.checkNested(file_name)
   return {
     appname: app_name,
     language: language,
@@ -58,7 +58,8 @@ async function CustomObject(i: number) {
     `Stack ${i} Name: `
   )
   const CustomStacks = await util.multichoice("app_type", choice, "")
-  customStacks[<string>customstack_name[`customStackName${i}`]] = CustomStacks.app_type
+  customStacks[<string>customstack_name[`customStackName${i}`]] =
+    CustomStacks.app_type
   return customStacks
 }
 export async function createModules(
@@ -77,7 +78,7 @@ export async function createModules(
   do {
     const AppType: string = <string>await util.appType("Module Type :")
     if (AppType !== "CustomizableModule") {
-      stackname[`stackName${i}`] = `${AppType}${rover_helpers.makeId(5)}`
+      stackname[`stackName${i}`] = `${AppType}${roverHelpers.makeId(5)}`
       const stack_name = stackname
       const stackName: string = stack_name[`stackName${i}`]
       if (AppType === "CRUDModule") {