Skip to content

document event listeners are not removed when destroying a StickyWin #71

@wmwong

Description

@wmwong

Didn't realize bugs are here now.
Copy of bug #120 from http://code.google.com/p/cnetjavascript/issues/detail?id=120
HTML: http://code.google.com/p/cnetjavascript/issues/attachmentText?id=120&aid=-770559181411270546&name=test.html&token=e2f07b2468ea87d4c081c6d2bf885982

What steps will reproduce the problem?

  1. Load the attached HTML file. You should see 'hello world'.
  2. Click on the document.
  3. An alert saying 'destroy' should show up.
  4. 'hello world' should disappear and the StickyWin destroyed.
  5. Click on the document again.

What is the expected output? What do you see instead?
After the StickyWin is destroyed, clicking on the document should no longer trigger the alert. Instead, the event listeners stay around and are not removed.

Please provide any additional information below.
To fix this, a call to "this.attach( false );" can be added to the #destroy function of StickyWin before the event is fired. This will remove the event listeners from the document.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions