V0.8 (#124)

* Fix TimeInDay issues
* Fix issue when using DISTINCT with JOIN in models with custom SELECT
clause defined AFTER the joins.
* Fix mistake in spec and add specs
* Add changelog; update shard
* Add seed command in the CLI
* add `or_where` feature
* Fix FTS to remove ambiguous clauses
* Fix issue with nilable belongs_to which cannot be saved when set to nil
* Add RFC3339 support while converting string to time
* Fix caching with belongs_to
* Add colorize parameter to Clear::SQL::Logger module
* Migration: Add datatype conversion in add_column and alter_column methods
* Migration: Update migration add_column operation to allow contraints, nullable
and default value
* Update to latest version of pg gem
* Fix ambigous column name in with_xxx method for belongs_to relation
* Add possibility to have nulls first and nulls last in `order_by` method
* WIP on a SQL parser
* Add the possibility to convert from Array(JSON:Any)
* Fix misc typos

Author: anykeyh

manual/CHANGELOG.md

@@ -1,3 +1,30 @@
+# v0.8
+
+## Features
+
+- Add `or_where` clause
+
+This provide a way to chain where clause with `or` operator instead of `and`:
+
+```crystal
+query.where{ a == b }.or_where{ b == c } # WHERE (A = B) OR (b = C)
+query.where{ a == b }.where{ c == d}.or_where{ a == nil } # WHERE ( A=B AND C=D ) OR A IS NULL
+```
+
+- Add `raw` method into `Clear::SQL` module.
+
+This provide a fast way to create SQL fragment while escaping items, both with `?` and `:key` system:
+
+```crystal
+query = Mode.query.select( Clear::SQL.raw("CASE WHEN x=:x THEN 1 ELSE 0 END as check", x: "blabla") )
+query = Mode.query.select( Clear::SQL.raw("CASE WHEN x=? THEN 1 ELSE 0 END as check", "blabla") )
+```
+
+## Bugfixes
+
+- Migrate to crystal v0.29
+- Fix issue with combinaison of `join`, `distinct` and `select`
+
 # v0.7
 
 ## Features

sample/cli/cli.cr

@@ -34,6 +34,10 @@ class ApplyChange2
   end
 end
 
+Clear.seed do
+  puts "This is a seed"
+end
+
 Clear.with_cli do
   puts "Usage: crystal sample/cli/cli.cr -- clear [args]"
 end

shard.yml

@@ -1,5 +1,6 @@
 name: clear
-version: 0.7.2
+
+version: 0.8
 
 authors:
    - Yacine Petitprez <anykeyh@gmail.com>

spec/model/model_different_column_name_spec.cr

@@ -0,0 +1,45 @@
+require "../spec_helper"
+
+module ModelDifferentColumnNameSpec
+  class Brand
+    include Clear::Model
+
+    primary_key
+    column name : String, column_name: "brand_name"
+    self.table = "brands"
+  end
+
+  class ModelDifferentColumnNameSpecMigration8273
+    include Clear::Migration
+
+    def change(dir)
+      create_table "brands" do |t|
+        t.column "brand_name", "string"
+
+        t.timestamps
+      end
+    end
+  end
+
+  def self.reinit
+    reinit_migration_manager
+    ModelDifferentColumnNameSpecMigration8273.new.apply(Clear::Migration::Direction::UP)
+  end
+
+  describe "Clear::Model" do
+    context "Column definition" do
+      it "can define properties in the model with a name different of the column name in PG" do
+        # Here the column "name" is linked to "brand_name" in postgreSQL
+        temporary do
+          reinit
+
+          Brand.create! name: "Nike"
+          Brand.query.first!.name.should eq "Nike"
+          Brand.query.where(brand_name: "Nike").count.should eq 1
+        end
+      end
+    end
+  end
+
+
+end

spec/model/model_spec.cr

@@ -266,6 +266,15 @@ module ModelSpec
           #reload the model now
           u.reload.first_name.should eq "Malcom"
           u.changed?.should be_false
+
+          u2 = User.create!({id: 2, first_name: "y"})
+
+          p = Post.create! user: u, title: "Reload testing post"
+
+          p.user.id.should eq(1)
+          p.user = u2 #Change the user, DO NOT SAVE.
+          p.reload # Reload the model now:
+          p.user.id.should eq(1) # Cache should be invalidated
         end
       end
 
@@ -697,6 +706,25 @@ module ModelSpec
           user_with_a_post_minimum.with_posts.each { } # Should just execute
         end
       end
+
+      it "should wildcard with default model only if no select is made (before OR after)" do
+        temporary do
+          reinit
+          u = User.create!({first_name: "Join User"})
+          Post.create!({title: "A Post", user_id: u.id})
+
+          user_with_a_post_minimum = User.query.distinct
+            .join(:model_posts) { model_posts.user_id == model_users.id }
+            .select(:first_name, :last_name)
+
+          user_with_a_post_minimum.to_sql.should eq \
+            "SELECT DISTINCT \"first_name\", \"last_name\" FROM \"model_users\" INNER JOIN " +
+            "\"model_posts\" ON (\"model_posts\".\"user_id\" = \"model_users\".\"id\")"
+
+          user_with_a_post_minimum.with_posts.each { } # Should just execute
+        end
+      end
+
     end
 
     context "with pagination" do

spec/sql/misc_spec.cr

@@ -11,6 +11,33 @@ module SQLMiscSpec
 
   describe "Clear::SQL" do
     describe "miscalleanous" do
+
+      it "can escape for SQL-safe object" do
+        Clear::SQL.escape("order").should eq "\"order\""
+        Clear::SQL.escape("").should eq "\"\""
+        Clear::SQL.escape(:hello).should eq "\"hello\""
+
+        Clear::SQL.escape("some.weird.column name").should eq "\"some.weird.column name\""
+        Clear::SQL.escape("\"hello world\"").should eq "\"\"\"hello world\"\"\""
+      end
+
+      it "can sanitize for SQL-safe string" do
+        Clear::SQL.sanitize(1).should eq "1"
+        Clear::SQL.sanitize("").should eq "''"
+        Clear::SQL.sanitize(nil).should eq "NULL"
+        Clear::SQL.sanitize("l'hotel").should eq "'l''hotel'"
+      end
+
+      it "can create SQL fragment" do
+        Clear::SQL.raw("SELECT * FROM table WHERE x = ?", "hello").should eq(
+          %(SELECT * FROM table WHERE x = 'hello')
+        )
+
+        Clear::SQL.raw("SELECT * FROM table WHERE x = :x", x: 1).should eq(
+          %(SELECT * FROM table WHERE x = 1)
+        )
+      end
+
       it "can truncate a table" do
 
         begin

spec/sql/parser_spec.cr

@@ -0,0 +1,21 @@
+require "../spec_helper"
+
+module ParserSpec
+  extend self
+
+  describe "Clear::SQL" do
+    describe "Parser" do
+
+      it "parse correctly" do
+        Clear::SQL::Parser.parse(<<-SQL
+          SELECT * FROM "users" where (id > 100 and active is null);
+          SELECT 'string' as text;
+          -- This is a comment
+        SQL
+        ) do |token|
+          pp token
+        end
+      end
+    end
+  end
+end

spec/sql/select_spec.cr

@@ -53,6 +53,17 @@ module SelectSpec
           r.to_sql.should eq "SELECT *"
         end
 
+        it "can select distinct" do
+          r = select_request.distinct.select("*")
+          r.to_sql.should eq "SELECT DISTINCT *"
+
+          r = select_request.distinct.select("a", "b", "c")
+          r.to_sql.should eq "SELECT DISTINCT a, b, c"
+
+          r = select_request.distinct.select(:first_name, :last_name, :id)
+          r.to_sql.should eq "SELECT DISTINCT \"first_name\", \"last_name\", \"id\""
+        end
+
         it "can select any string" do
           r = select_request.select("1")
           r.to_sql.should eq "SELECT 1"
@@ -80,6 +91,13 @@ module SelectSpec
         end
       end
 
+      describe "the ORDER BY clause" do
+        it "can add NULLS FIRST and NULLS LAST" do
+          r = select_request.from("users").order_by("email", "ASC", "NULLS LAST")
+          r.to_sql.should eq "SELECT * FROM users ORDER BY email ASC NULLS LAST"
+        end
+      end
+
       describe "the FROM clause" do
         it "can build simple from" do
           r = select_request.from(:users)
@@ -156,6 +174,18 @@ module SelectSpec
             r.to_sql.should eq "SELECT * FROM \"users\" WHERE (\"user_id\" IS NULL)"
           end
 
+          it "can use or_where" do
+            select_request.from(:users).where("a = ?", {1}).or_where("b = ?", {2}).to_sql.should(
+              eq %(SELECT * FROM "users" WHERE ((a = 1) OR (b = 2)))
+            )
+
+            # First OR WHERE acts as a simple WHERE:
+            select_request.from(:users).or_where("a = ?", {1}).or_where("b = ?", {2}).to_sql.should(
+              eq %(SELECT * FROM "users" WHERE ((a = 1) OR (b = 2)))
+            )
+          end
+
+
           it "can use `in` operators in case of array" do
             r = select_request.from(:users).where({user_id: [1, 2, 3, 4, "hello"]})
             r.to_sql.should eq "SELECT * FROM \"users\" WHERE \"user_id\" IN (1, 2, 3, 4, 'hello')"
@@ -199,6 +229,11 @@ module SelectSpec
               select_request.from(:users).where("a LIKE :halo AND b LIKE :world",
                 {hello: "h", world: "w"})
             end
+
+            expect_raises Clear::SQL::QueryBuildingError do
+              select_request.from(:users).or_where("a LIKE :halo AND b LIKE :world",
+                {hello: "h", world: "w"})
+            end
           end
 
           it "can prepare group by query" do

src/clear/cli.cr

@@ -3,6 +3,7 @@ require "admiral"
 require "./core"
 require "./cli/command"
 require "./cli/migration"
+require "./cli/seed"
 require "./cli/generator"
 
 module Clear
@@ -19,6 +20,7 @@ module Clear
 
       register_sub_command migrate, type: Clear::CLI::Migration
       register_sub_command generate, type: Clear::CLI::Generator
+      register_sub_command seed, type: Clear::CLI::Seed
 
       def run_impl
         STDOUT.puts help