Merge pull request #200 from anyproto/GO-6379-stats-error-for-archived-spaces

GO-6379 space stats: check status

Author: cheggaaa

debug/nodedebugrpc/nodedebugrpc.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"encoding/json"
 	"errors"
-	"fmt"
 	"net/http"
 	"strconv"
 
@@ -121,17 +120,17 @@ func (s *nodeDebugRpc) handleSpaceStats(rw http.ResponseWriter, req *http.Reques
 			errStatus = http.StatusNotImplemented
 		}
 
-		errorStr := fmt.Sprintf("failed to get space stats: %s", err)
+		if errors.Is(err, nodespace.ErrSpaceStatus) {
+			errStatus = http.StatusBadRequest
+		}
+
 		errReply := statsError{
-			Error: errorStr,
+			Error: err.Error(),
 		}
 
-		log.Error(errorStr, zap.Error(err))
 		rw.WriteHeader(errStatus)
-
 		marshalledErr, _ := json.MarshalIndent(errReply, "", "  ")
 		rw.Write(marshalledErr)
-
 		return
 	}
 

nodespace/service.go

@@ -4,6 +4,7 @@ package nodespace
 import (
 	"context"
 	"errors"
+	"fmt"
 	"time"
 
 	"github.com/anyproto/any-sync/app"
@@ -100,7 +101,27 @@ func (s *service) PickSpace(ctx context.Context, id string) (NodeSpace, error) {
 	return v.(NodeSpace), nil
 }
 
+var ErrSpaceStatus = errors.New("space status error")
+
 func (s *service) GetStats(ctx context.Context, id string, treeTop int) (spaceStats nodestorage.SpaceStats, err error) {
+	status, err := s.spaceStorageProvider.IndexStorage().SpaceStatus(ctx, id)
+	if err != nil {
+		return
+	}
+	switch status {
+	case nodestorage.SpaceStatusError:
+		err = fmt.Errorf("%w: error state", ErrSpaceStatus)
+	case nodestorage.SpaceStatusRemove:
+		err = fmt.Errorf("%w: remove state", ErrSpaceStatus)
+	case nodestorage.SpaceStatusRemovePrepare:
+		err = fmt.Errorf("%w: remove prepare state", ErrSpaceStatus)
+	case nodestorage.SpaceStatusArchived:
+		err = fmt.Errorf("%w: archived state", ErrSpaceStatus)
+	case nodestorage.SpaceStatusOk:
+	}
+	if err != nil {
+		return
+	}
 	return s.spaceStorageProvider.GetStats(ctx, id, treeTop)
 }