chore: fixed some warnings

Author: Kirottu

anyrun/src/main.rs

@@ -816,7 +816,7 @@ fn handle_matches(plugin_view: PluginView, runtime_data: &RuntimeData, matches:
         }
     }
 
-    if let Some((row, view)) = combined_matches.get(0) {
+    if let Some((row, view)) = combined_matches.first() {
         view.list.select_row(Some(row));
     }
 }
@@ -866,6 +866,10 @@ fn create_info_box(info: &PluginInfo, hide_icons: bool) -> gtk::Box {
     main_box
 }
 
+// The linter warns about function pointer comparisons being unpredictable.
+// However in Anyrun's case since the function pointers reside in loaded libraries
+// they will always be predictable for comparison during runtime
+#[allow(unpredictable_function_pointer_comparisons)]
 /// Refresh the matches from the plugins
 fn refresh_matches(input: String, runtime_data: Rc<RefCell<RuntimeData>>) {
     for plugin_view in runtime_data.borrow().plugins.iter() {

plugins/applications/src/lib.rs

@@ -199,7 +199,7 @@ pub fn get_matches(input: RString, state: &State) -> RVec<Match> {
 
             // prioritize actions
             if entry.desc.is_some() {
-                score = score * 2;
+                score *= 2;
             }
 
             if score > 0 {
@@ -210,8 +210,7 @@ pub fn get_matches(input: RString, state: &State) -> RVec<Match> {
         })
         .collect::<Vec<_>>();
 
-    entries.sort_by(|a, b| b.2.cmp(&a.2)
-        .then(a.0.name.cmp(&b.0.name)));
+    entries.sort_by(|a, b| b.2.cmp(&a.2).then(a.0.name.cmp(&b.0.name)));
 
     entries.truncate(state.config.max_entries);
     entries

plugins/randr/src/lib.rs

@@ -146,7 +146,7 @@ pub fn get_matches(input: RString, state: &State) -> RVec<Match> {
                             ]
                             .iter()
                             .map(|configure| Match {
-                                title: format!("{} {}", configure.to_string(), _mon.name).into(),
+                                title: format!("{} {}", configure, _mon.name).into(),
                                 description: ROption::RNone,
                                 use_pango: false,
                                 icon: ROption::RSome(configure.icon().into()),

plugins/randr/src/randr/mod.rs

@@ -1,3 +1,5 @@
+use std::fmt::Display;
+
 pub mod dummy;
 pub mod hyprland;
 
@@ -47,20 +49,20 @@ impl<'a> Configure<'a> {
     }
 }
 
-impl<'a> ToString for Configure<'a> {
-    fn to_string(&self) -> String {
+impl Display for Configure<'_> {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {
-            Configure::Mirror(_) => "Mirror".to_string(),
-            Configure::LeftOf(_) => "Left of".to_string(),
-            Configure::RightOf(_) => "Right of".to_string(),
-            Configure::Below(_) => "Below".to_string(),
-            Configure::Above(_) => "Above".to_string(),
-            Configure::Zero => "Zero".to_string(),
+            Configure::Mirror(_) => f.write_str("Mirror"),
+            Configure::LeftOf(_) => f.write_str("Left of"),
+            Configure::RightOf(_) => f.write_str("Right of"),
+            Configure::Below(_) => f.write_str("Below"),
+            Configure::Above(_) => f.write_str("Above"),
+            Configure::Zero => f.write_str("Zero"),
         }
     }
 }
 
-impl<'a> From<&Configure<'a>> for u64 {
+impl From<&Configure<'_>> for u64 {
     fn from(configure: &Configure) -> u64 {
         match configure {
             Configure::Mirror(_) => 0,

plugins/stdin/src/lib.rs

@@ -35,7 +35,7 @@ fn init(config_dir: RString) -> State {
 
     State {
         config,
-        lines: stdin().lines().filter_map(|line| line.ok()).collect(),
+        lines: stdin().lines().map_while(Result::ok).collect(),
     }
 }