Skip to content

upd: Add support for AWS TF Provider v6.x#72

Merged
hongchaodeng merged 13 commits intomainfrom
brent/upd-aws-provider-version
Aug 11, 2025
Merged

upd: Add support for AWS TF Provider v6.x#72
hongchaodeng merged 13 commits intomainfrom
brent/upd-aws-provider-version

Conversation

@brent-anyscale
Copy link
Collaborator

@brent-anyscale brent-anyscale commented Jul 28, 2025

Update the AWS Provider version to support >= 5.0, < 7.0

Associated updates to READMEs and tests.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • pre-commit has been run
  • Tests for the changes have been added (for bug fixes / features)
  • All tests passing
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull Request Type

  • Bugfix
  • New feature
  • Refactoring (no functional changes)
  • Documentation change
  • Other (please describe):
    Support for AWS TF Provider v6.x

Does this introduce a breaking change?

  • Yes
  • No

@brent-anyscale
upd: aws-anyscale-efs: Expand AWS provider version range
a2b12a4 
On branch brent/upd-aws-provider-version
Changes to be committed:
	modified:   aws-anyscale-efs/README.md
	new file:   aws-anyscale-efs/examples/README.md
	renamed:    aws-anyscale-efs/test/anyscale-test/main.tf -> aws-anyscale-efs/examples/main.tf
	renamed:    aws-anyscale-efs/test/anyscale-test/outputs.tf -> aws-anyscale-efs/examples/outputs.tf
	renamed:    aws-anyscale-efs/test/anyscale-test/variables.tf -> aws-anyscale-efs/examples/variables.tf
	renamed:    aws-anyscale-efs/test/anyscale-test/versions.tf -> aws-anyscale-efs/examples/versions.tf
	deleted:    aws-anyscale-efs/test/README.md
	modified:   aws-anyscale-efs/versions.tf
@brent-anyscale
Merge remote-tracking branch 'origin/main' into brent/upd-aws-provide…
774ab15 
…r-version
@brent-anyscale
upd: AWS provider version for aws-anyscale-iam
2f4708c 
On branch brent/upd-aws-provider-version
Changes to be committed:
	modified:   aws-anyscale-iam/README.md
	modified:   aws-anyscale-iam/examples/versions.tf
	modified:   aws-anyscale-iam/versions.tf
@brent-anyscale
upd: AWS provider version for aws-anyscale-vpc
9e9be8f 
Changes to be committed:
	modified:   aws-anyscale-vpc/README.md
	modified:   aws-anyscale-vpc/examples/versions.tf
	modified:   aws-anyscale-vpc/versions.tf
@brent-anyscale
upd: AWS provider version for aws-anyscale-securitygroups
4e9bc2e 
Changes to be committed:
	modified:   aws-anyscale-securitygroups/README.md
	modified:   aws-anyscale-securitygroups/examples/versions.tf
	modified:   aws-anyscale-securitygroups/versions.tf
@brent-anyscale
upd: AWS provider version for aws-anyscale-s3
057845c 
Changes to be committed:
	modified:   aws-anyscale-s3/README.md
	modified:   aws-anyscale-s3/examples/versions.tf
	modified:   aws-anyscale-s3/versions.tf
@brent-anyscale
upd: AWS provider version for aws-anyscale-s3-policy
cccf9d3 
Changes to be committed:
	modified:   aws-anyscale-s3-policy/README.md
	modified:   aws-anyscale-s3-policy/examples/versions.tf
	modified:   aws-anyscale-s3-policy/versions.tf
@brent-anyscale
upd: AWS provider version for aws-anyscale-memorydb
ffbc98c 
Changes to be committed:
	modified:   aws-anyscale-memorydb/README.md
	modified:   aws-anyscale-memorydb/examples/versions.tf
	modified:   aws-anyscale-memorydb/versions.tf
@brent-anyscale
upd: README badges for AWS provider version
13eb246 
Changes to be committed:
	modified:   aws-anyscale-efs/README.md
	modified:   aws-anyscale-iam/README.md
	modified:   aws-anyscale-memorydb/README.md
	modified:   aws-anyscale-s3-policy/README.md
	modified:   aws-anyscale-s3/README.md
	modified:   aws-anyscale-securitygroups/README.md
	modified:   aws-anyscale-vpc/README.md
@brent-anyscale
upd: AWS provider version for examples and root module
2f0b3f8 
Changes to be committed:
	modified:   .gitignore
	modified:   CHANGELOG.md
	modified:   README.md
	modified:   examples/README.md
	modified:   examples/anyscale-v2-commonname/README.md
	modified:   examples/anyscale-v2-commonname/versions.tf
	modified:   examples/anyscale-v2-existing-s3/README.md
	modified:   examples/anyscale-v2-existing-s3/versions.tf
	modified:   examples/anyscale-v2-existing-vpc/README.md
	modified:   examples/anyscale-v2-existing-vpc/versions.tf
	modified:   examples/anyscale-v2-kitchensink/README.md
	modified:   examples/anyscale-v2-kitchensink/versions.tf
	modified:   examples/anyscale-v2-kms/README.md
	modified:   examples/anyscale-v2-kms/versions.tf
	modified:   examples/anyscale-v2-privatesubnets/README.md
	modified:   examples/anyscale-v2-privatesubnets/versions.tf
	modified:   examples/anyscale-v2/README.md
	modified:   examples/anyscale-v2/versions.tf
	modified:   versions.tf
@brent-anyscale brent-anyscale requested a review from a team as a code owner July 28, 2025 22:18
@github-actions github-actions bot added documentation Improvements or additions to documentation examples terraform unittests labels Jul 28, 2025
@brent-anyscale brent-anyscale removed documentation Improvements or additions to documentation unittests labels Jul 28, 2025
@RCdeWit
Copy link
Contributor

RCdeWit commented Jul 30, 2025 •
edited
Loading

Currently testing the examples, using the following approach for each:

  1. terraform apply with aws ~> 5.0
  2. terraform apply with aws ~> 6.0
  3. terraform destroy
  4. terraform apply with aws ~> 6.0
  5. anyscale cloud register
  6. terraform destroy

Progress

  • anyscale-v2
  • anyscale-v2-commonname
  • anyscale-v2-existing-3
  • anyscale-v2-existing-vpc
  • anyscale-v2-kitchensink
  • anyscale-v2-kms
  • anyscale-v2-privatesubnets

Issues/papercuts/frictions

  • anyscale_org_id is not optional in anyscale-v2-commonname, anyscale-v2-kitchensink, and anyscale-v2-privatesubnets`
  • s3_tag_value is not optional in anyscale-v2-existing-vpc
  • Failed to create workspace: API Exception (500) from POST /api/v2/experimental_workspaces/

@brent-anyscale
Copy link
Collaborator Author

brent-anyscale commented Jul 30, 2025

@RCdeWit

anyscale_org_id is not optional in anyscale-v2-commonname and anyscale-v2-kitchensink
This is expected - by requiring the org id, it allows us to skip requiring running the TF modules 2x to avoid drift during cloud registration. It uses the new --external-id during cloud registration.

@brent-anyscale
Copy link
Collaborator Author

brent-anyscale commented Jul 30, 2025

Failed to create workspace: API Exception (500) from POST /api/v2/experimental_workspaces/

Was this during cloud verification?

@RCdeWit
Copy link
Contributor

RCdeWit commented Jul 31, 2025 

anyscale_org_id is not optional in anyscale-v2-commonname and anyscale-v2-kitchensink
This is expected - by requiring the org id, it allows us to skip requiring running the TF modules 2x to avoid drift during cloud registration. It uses the new --external-id during cloud registration.

Think for those examples we should move the variables to the required section in variables.tf.

Was this during cloud verification?

Yes, need to dive a little deeper to find out what actually happened.

@RCdeWit
Copy link
Contributor

RCdeWit commented Aug 1, 2025

Verified all examples except for anyscale-v2-kms. Keep hitting a 400 error when setting the key_admin_role_name; not sure I have the appropriate permissions on AWS.

@brent-anyscale
upd: CommonName example to move org id to required variable
5106b13 
Changes to be committed:
	modified:   examples/anyscale-v2-commonname/README.md
	modified:   examples/anyscale-v2-commonname/variables.tf
@brent-anyscale
upd: PrivateSubnets example to move org id to required variable
529e729 
Changes to be committed:
	modified:   examples/anyscale-v2-privatesubnets/README.md
	modified:   examples/anyscale-v2-privatesubnets/variables.tf
@github-actions github-actions bot added documentation Improvements or additions to documentation unittests labels Aug 11, 2025
@brent-anyscale
upd: Kitchensink example to move org id to required variable
172854a 
Changes to be committed:
	modified:   examples/anyscale-v2-kitchensink/README.md
	modified:   examples/anyscale-v2-kitchensink/variables.tf
hongchaodeng
hongchaodeng approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@hongchaodeng hongchaodeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hongchaodeng
Copy link
Member

hongchaodeng commented Aug 11, 2025

Verified all examples except for anyscale-v2-kms. Keep hitting a 400 error when setting the key_admin_role_name

You need to provide key_admin_role_name which is a required variable.

@hongchaodeng
Copy link
Member

hongchaodeng commented Aug 11, 2025

Since most examples have been tested, we should have high confidence to merge now.

@hongchaodeng hongchaodeng merged commit 50245f0 into main Aug 11, 2025
4 checks passed
@hongchaodeng hongchaodeng deleted the brent/upd-aws-provider-version branch August 11, 2025 19:43
@RCdeWit
Copy link
Contributor

RCdeWit commented Aug 12, 2025

You need to provide key_admin_role_name which is a required variable.

What's the value I should have set there? Perhaps I misconfigured it, but all my attempts resulted in a 400.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hongchaodeng hongchaodeng hongchaodeng approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation examples terraform unittests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brent-anyscale @RCdeWit @hongchaodeng