fix remote-vnc

Author: neil

README.md

@@ -140,7 +140,7 @@ AnyVM includes a built-in, premium VNC Web UI that allows you to access the VM's
   - **Fullscreen**: Toggle fullscreen mode for an immersive experience.
   - **Stats**: Real-time FPS and latency monitoring.
 - **Accessibility**: Available at `http://localhost:6080` by default. If the port is occupied, AnyVM will automatically try the next available port (e.g., 6081, 6082).
-- **Remote Access**: Use `--remote-vnc` to automatically create a public, secure tunnel (via Cloudflare, Localhost.run, or Pinggy) to access your VM's display from anywhere in the world.
+- **Remote Access**: Use `--remote-vnc` to automatically create a public, secure tunnel (via Cloudflare, Localhost.run, or Pinggy) to access your VM's display from anywhere in the world. (In Google Cloud Shell, this is enabled by default; use `--remote-vnc no` to disable).
 
 ## 9. CLI options (with examples)
 
@@ -240,6 +240,7 @@ All examples below use `python3 anyvm.py ...`. You can also run `python3 anyvm.p
 - `--remote-vnc`: Create a public tunnel for the VNC Web UI using Cloudflare, Localhost.run, or Pinggy.
   - Example: `python3 anyvm.py --os freebsd --remote-vnc`
   - Advanced: Use `cf`, `lhr`, or `pinggy` to specify a service: `python3 anyvm.py --os freebsd --remote-vnc cf`
+  - Disable: Use `no` to disable (e.g., in Google Cloud Shell where it's default): `python3 anyvm.py --os freebsd --remote-vnc no`
 
 - `--mon <port>`: Expose the QEMU monitor via telnet on localhost.
   - Example: `python3 anyvm.py --os freebsd --mon 4444`

anyvm.py

@@ -2384,6 +2384,8 @@ def print_usage():
                          Use "--vnc off" to disable.
   --remote-vnc           Create a public URL for the VNC Web UI using Cloudflare, Localhost.run, or Pinggy.
                          Usage: --remote-vnc (auto), --remote-vnc cf, --remote-vnc lhr, --remote-vnc pinggy.
+                         Enabled by default if no local browser is detected (e.g., in Cloud Shell).
+                         Use "--remote-vnc no" to disable.
   --vga <type>           VGA device type (e.g., virtio, std, virtio-gpu). Default: virtio (std for NetBSD).
   --res, --resolution    Set initial screen resolution (e.g., 1280x800). Default: 1280x800.
   --mon <port>           QEMU monitor telnet port (localhost).
@@ -3460,7 +3462,8 @@ def main():
         'public_vnc': False,
         'public_ssh': False,
         'accept_vm_ssh': False,
-        'remote_vnc': False
+        'remote_vnc': None,
+        'remote_vnc_is_default': False
     }
 
     ssh_passthrough = []
@@ -3477,6 +3480,8 @@ def main():
         working_dir = "/tmp/anyvm.org"
         if not os.path.exists(working_dir):
             os.makedirs(working_dir)
+        config['remote_vnc'] = True
+        config['remote_vnc_is_default'] = True
 
     # Manual argument parsing
     args = sys.argv[1:]
@@ -3575,7 +3580,11 @@ def main():
             config['public_ssh'] = True
         elif arg == "--remote-vnc":
             if i + 1 < len(args) and not args[i+1].startswith("-"):
-                config['remote_vnc'] = args[i+1]
+                val = args[i+1]
+                if val.lower() in ["no", "off", "false", "0"]:
+                    config['remote_vnc'] = False
+                else:
+                    config['remote_vnc'] = val
                 i += 1
             else:
                 config['remote_vnc'] = True
@@ -3608,11 +3617,21 @@ def main():
                 i += 1
             else:
                 config['synctime'] = True
+        else:
+            log("Warning: Unrecognized argument: {}".format(arg))
         i += 1
 
     if config['debug']:
         debuglog(True, "Debug logging enabled")
 
+    # If remote VNC not explicitly specified, enable it by default if browser is unavailable
+    if config['remote_vnc'] is None:
+        if config['vnc'].lower() != "off" and not is_browser_available():
+            config['remote_vnc'] = True
+            config['remote_vnc_is_default'] = True
+        else:
+            config['remote_vnc'] = False
+
     is_vnc_console = (config.get('vnc') == "console")
 
     if not config['os']:
@@ -5165,6 +5184,9 @@ def finish_wait_timer():
                          if supports_ansi_color():
                              display_url = "\x1b[32m{}\x1b[0m".format(tunnel_url)
                          log("WebVNC ({}): {}".format(tunnel_service, display_url))
+                         if config.get('remote_vnc_is_default'):
+                             log("Notice: Remote VNC tunnel is enabled by default as no local browser was detected.")
+                             log("        Use '--remote-vnc off' to disable it.")
                  log("======================================")
 
             if not config['detach']:
@@ -5194,6 +5216,9 @@ def finish_wait_timer():
                         if supports_ansi_color():
                             display_url = "\x1b[32m{}\x1b[0m".format(tunnel_url)
                         log("WebVNC ({}): {}".format(tunnel_service, display_url))
+                        if config.get('remote_vnc_is_default'):
+                            log("Notice: Remote VNC tunnel is enabled by default as no local browser was detected.")
+                            log("        Use '--remote-vnc off' to disable it.")
                     log("======================================")
                 else:
                     log("VM has exited")