v2.1: Disallow --rocksdb-shred-compaction fifo in the validator (backport of #3451) (#3464)

Disallow --rocksdb-shred-compaction fifo in the validator (#3451)

The use of fifo compaction in rocksdb is deprecated (as of v2.0). The
current behavior emits a warning if fifo is set. This change removes
"fifo" as an option, leaving "level" as the only valid value for
--rocksdb-shred-compaction

(cherry picked from commit fddc554)

Co-authored-by: steviez <[email protected]>

Author: mergify[bot]

CHANGELOG.md

@@ -24,6 +24,8 @@ Release channels have their own copy of this changelog:
     * removed the unreleased `redelegate` instruction processor and CLI commands (#2213)
   * Banks-client:
     * relax functions to use `&self` instead of `&mut self` (#2591)
+  * `agave-validator`:
+    * Remove the deprecated value of `fifo` for `--rocksdb-shred-compaction` (#3451)
 * Changes
   * SDK:
     * removed the `respan` macro. This was marked as "internal use only" and was no longer used internally.

validator/src/cli.rs

@@ -666,14 +666,12 @@ pub fn app<'a>(version: &'a str, default_args: &'a DefaultArgs) -> App<'a, 'a> {
                 .long("rocksdb-shred-compaction")
                 .value_name("ROCKSDB_COMPACTION_STYLE")
                 .takes_value(true)
-                .possible_values(&["level", "fifo"])
+                .possible_values(&["level"])
                 .default_value(&default_args.rocksdb_shred_compaction)
                 .help(
                     "Controls how RocksDB compacts shreds. *WARNING*: You will lose your \
                      Blockstore data when you switch between options. Possible values are: \
-                     'level': stores shreds using RocksDB's default (level) compaction. \
-                     'fifo': stores shreds under RocksDB's FIFO compaction. This option is more \
-                     efficient on disk-write-bytes of the Blockstore.",
+                     'level': stores shreds using RocksDB's default (level) compaction.",
                 ),
         )
         .arg(